From nobody Sat May 4 00:21:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1555776233; cv=none; d=zoho.com; s=zohoarc; b=jZCGuYSidi8Fp99Ya71+A/oxry7+XqkWe/XG1317rDhVoGeVwRhu5ohE80RXAvbjFPvECNFpikRyknE44Hq7hu3cSIOSelp0eyT7uQq+/1gkgIhJrujtl87hRkPDTk3IbMC6FYQwfjaswYNskbci1RLr8Nae4yXeaeuZbLKvBDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555776233; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=w4ygKr81NYHHj0JHeCmMA9n1b8fxsPI3UkzRPp2GlvU=; b=Hbew4LbUg7Yq3FpwJQRE1aVGbrYz6n+nGwWkqNn3Q6HpqvEqY0Sd3cwTYjoANB7RGPLo/KjEt4QPJwyPYiASQvEeeaQNs4VnyHtMXbxLKT2cyA9SX6APQ1aTD9vG/gobp26N3G/RsaSQKIJ9F3QyAYOFczSbGie922zfJI20qZ0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155577623386934.948942275872355; Sat, 20 Apr 2019 09:03:53 -0700 (PDT) Received: from localhost ([127.0.0.1]:42822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsRq-0007PT-PL for importer@patchew.org; Sat, 20 Apr 2019 12:02:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsPK-0005w9-73 for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHsPJ-0008Fy-A8 for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:02 -0400 Received: from m12-11.163.com ([220.181.12.11]:33864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsPI-0008F3-4s for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:01 -0400 Received: from localhost.localdomain (unknown [183.159.69.175]) by smtp7 (Coremail) with SMTP id C8CowACX_I34QbtcELxpBQ--.29437S3; Sat, 20 Apr 2019 23:59:55 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=w4ygKr81NYHHj0JHeC mMA9n1b8fxsPI3UkzRPp2GlvU=; b=jp9HjPVsY8Snt97LB1FHL2YEcDpWnOfEFi ta8Uwku8yYxE1EAZNef/iiRRskYYcJco6dA1TALpAoDk7l37blOHbjwnJprzqvjp FF59xmbFgP+dwJ5liT0NIUtgOhK4gG6tIsGsHqPgqjJGZNKdirlGBPV0tflaa3cQ yDOGtVuyo= From: Li Qiang To: jslaby@suse.cz, pbonzini@redhat.com Date: Sat, 20 Apr 2019 08:59:47 -0700 Message-Id: <20190420155949.130968-2-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190420155949.130968-1-liq3ea@163.com> References: <20190420155949.130968-1-liq3ea@163.com> X-CM-TRANSID: C8CowACX_I34QbtcELxpBQ--.29437S3 X-Coremail-Antispam: 1Uf129KBjvJXoWrZF48CF17GFyxAFW3Ar1xuFg_yoW8JF13pF 1Uu3WYkrZ5JFZFqr13Gr1qqr1ftr97Cw18JrZxXFWjyw48Xr1DKa10ka4Fgrn8JF48Xanx Z3ZYqF43KF1DXaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UQNVkUUUUU= X-Originating-IP: [183.159.69.175] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiKRmcbVXlqvAo4QABsj X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.11 Subject: [Qemu-devel] [PATCH v2 1/3] tests: fw_cfg: add splash time test case X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Li Qiang --- tests/fw_cfg-test.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c index 9f75dbb5f4..de8e81ea9d 100644 --- a/tests/fw_cfg-test.c +++ b/tests/fw_cfg-test.c @@ -192,6 +192,24 @@ static void test_fw_cfg_reboot_timeout(void) qtest_quit(s); } =20 +static void test_fw_cfg_splash_time(void) +{ + QFWCFG *fw_cfg; + QTestState *s; + uint16_t splash_time =3D 0; + size_t filesize; + + s =3D qtest_init("-boot splash-time=3D12"); + fw_cfg =3D pc_fw_cfg_init(s); + + filesize =3D qfw_cfg_get_file(fw_cfg, "etc/boot-menu-wait", + &splash_time, sizeof(splash_time)); + g_assert_cmpint(filesize, =3D=3D, sizeof(splash_time)); + g_assert_cmpint(splash_time, =3D=3D, 12); + pc_fw_cfg_uninit(fw_cfg); + qtest_quit(s); +} + int main(int argc, char **argv) { int ret; @@ -214,6 +232,7 @@ int main(int argc, char **argv) qtest_add_func("fw_cfg/numa", test_fw_cfg_numa); qtest_add_func("fw_cfg/boot_menu", test_fw_cfg_boot_menu); qtest_add_func("fw_cfg/reboot_timeout", test_fw_cfg_reboot_timeout); + qtest_add_func("fw_cfg/splash_time", test_fw_cfg_splash_time); =20 ret =3D g_test_run(); =20 --=20 2.17.1 From nobody Sat May 4 00:21:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1555776337; cv=none; d=zoho.com; s=zohoarc; b=WZww04VH/itvdcGikbc6LKrphYb6NSf/pQiMiTC5cC9EW7nW2qp/DUzvO23gUSA2fRwfkRJLDrgjTUd1js1fJY3fFMuBSbLAlzr5PD8wVAEz5Vyp6b/9V1VhaLtNMaFphH5yI7uaJMYtTU2iWUKX1aAAFiOnvVChGzZazFOQUnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555776337; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=iRFD+zpf5l7TX1uoBr2sBdhb6Xv5dDZq2CEa09rVSBg=; b=mq3EuglDuT4qqMnaFGo26OHWzubNVVsyWXWRoMlrOOnKnly7ynqrFb7ucT3BMLMNr5V4YoN4J8j3CqTuL1mNI+uaFlalMMEvpO68dtSxWdiTdgmsy0xkc9308f8tYtCUxbnovbOj+GJ/dZPoh9tVPxrkqnLCdzr7hKOwHnWXr6w= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555776337594678.8012507370282; Sat, 20 Apr 2019 09:05:37 -0700 (PDT) Received: from localhost ([127.0.0.1]:42910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsUg-0001JP-F1 for importer@patchew.org; Sat, 20 Apr 2019 12:05:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsPL-0005wh-Ce for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHsPK-0008Hy-Eb for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:03 -0400 Received: from m12-11.163.com ([220.181.12.11]:33987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsPI-0008Ef-5R for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:02 -0400 Received: from localhost.localdomain (unknown [183.159.69.175]) by smtp7 (Coremail) with SMTP id C8CowACX_I34QbtcELxpBQ--.29437S4; Sat, 20 Apr 2019 23:59:57 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=iRFD+zpf5l7TX1uoBr 2sBdhb6Xv5dDZq2CEa09rVSBg=; b=pmQVPwGu0D3ehnmkzB+0Z/Fouoj5iGXIjH oxpm+9nXmz8lgLhU+WeVh4+dtKI80ps5vaFjVAoSJvolkewfWFdLCUXz3BMhN0A2 q2hk1SxNQccnPXHUjVjDak4OOdFqdpP/NlLxo/0OAMnvNa5jbes3wJv1v3EEj8Rk X+dEItyKw= From: Li Qiang To: jslaby@suse.cz, pbonzini@redhat.com Date: Sat, 20 Apr 2019 08:59:48 -0700 Message-Id: <20190420155949.130968-3-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190420155949.130968-1-liq3ea@163.com> References: <20190420155949.130968-1-liq3ea@163.com> X-CM-TRANSID: C8CowACX_I34QbtcELxpBQ--.29437S4 X-Coremail-Antispam: 1Uf129KBjvdXoWruFyfZF15Wr4kKr43AF18Zrb_yoW3tFX_Xw 1xKFZ7GrW5XFyayF90q3W5uryxW3yrAF1rCrs3Gr43Ja4fGr98Z3s2qrnxXr47Gw47Kwn5 AaykZFy5trnFgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbCzutUUUUU== X-Originating-IP: [183.159.69.175] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbBax2cbVetu+co+QAAsw X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.11 Subject: [Qemu-devel] [PATCH v2 2/3] edu: mmio: set 'max_access_size' to 8 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The edu spec said, the MMIO area can be accessed by 8 bytes. However currently the 'max_access_size' is not so the MMIO access dispatch can only access 4 bytes one time. This patch fixes this to respect the spec. Notice: here the 'min_access_size' is not a must, I set this for completement. Signed-off-by: Li Qiang --- hw/misc/edu.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index 91af452c9e..65fc32b928 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -289,6 +289,15 @@ static const MemoryRegionOps edu_mmio_ops =3D { .read =3D edu_mmio_read, .write =3D edu_mmio_write, .endianness =3D DEVICE_NATIVE_ENDIAN, + .valid =3D { + .min_access_size =3D 4, + .max_access_size =3D 8, + }, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 8, + }, + }; =20 /* --=20 2.17.1 From nobody Sat May 4 00:21:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1555776164; cv=none; d=zoho.com; s=zohoarc; b=hXvW71czHlQYvceMUAxjNP5uqsX8ThYoqYfMjZFbn1a14c7EquwRNyrm2oZOc+0gSx8avP9O/B1d/TR33bdGgaFHoHOFdP7Xnbttt36hcw8GjIEhg5WdKi8b2ooChnWeAzDffGP62iPl+F3BDUtT0x08K/e43CguyLEEsTvqqzo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555776164; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=RHRyZI7fVUtHDgRAfmW2Km7K6555bdcRIgzudZy0lNE=; b=GJVSLPZNpBprfECRirhSc4SKdMdGDq4YWt9kFPh/96uLjVql3ewS/QIR4b26loC1+tApzwPQ1qzQHaAsaI1Bra31NJCO4tWcZJtzvKRJWtLsvVxkLz+8ErjPIY5GeRAWa9IJ0o7dSVM6hLPSf8s/mXljwkuEIV8f1XZusIgLaco= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555776164890512.3899542142825; Sat, 20 Apr 2019 09:02:44 -0700 (PDT) Received: from localhost ([127.0.0.1]:42820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsRl-0007L3-Tv for importer@patchew.org; Sat, 20 Apr 2019 12:02:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsPK-0005wA-Es for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHsPJ-0008Gc-Kd for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:02 -0400 Received: from m12-11.163.com ([220.181.12.11]:34116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHsPI-0008FW-FH for qemu-devel@nongnu.org; Sat, 20 Apr 2019 12:00:01 -0400 Received: from localhost.localdomain (unknown [183.159.69.175]) by smtp7 (Coremail) with SMTP id C8CowACX_I34QbtcELxpBQ--.29437S5; Sat, 20 Apr 2019 23:59:58 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=RHRyZI7fVUtHDgRAfm W2Km7K6555bdcRIgzudZy0lNE=; b=mfvl2eP/dBNtQo9wGCcHAWyZfa+GdjP+0E raUPK8r/rH2I7NDbCZdAnKb7A3kAsP9lBKe9q6dgTsUnLvO39F1gbkkye72R48wa 7H5KQdHiqlP29bsKUOLZxwWASRaTyxcEcQ4KlP6x7MynxBET9OVDKtNRaerqTilF 3oDNi1+DU= From: Li Qiang To: jslaby@suse.cz, pbonzini@redhat.com Date: Sat, 20 Apr 2019 08:59:49 -0700 Message-Id: <20190420155949.130968-4-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190420155949.130968-1-liq3ea@163.com> References: <20190420155949.130968-1-liq3ea@163.com> X-CM-TRANSID: C8CowACX_I34QbtcELxpBQ--.29437S5 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUczVbDUUUU X-Originating-IP: [183.159.69.175] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiFB6cbVaD0UJN+AAAsI X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.11 Subject: [Qemu-devel] [PATCH v2 3/3] edu: mmio: allow mmio read dispatch accept 8 bytes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The edu spec said when address >=3D 0x80, the MMIO area can be accessed by 8 bytes. Signed-off-by: Li Qiang --- Change since v1: Fix format compile error on Windows hw/misc/edu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index 65fc32b928..4018dddcb8 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -189,6 +189,10 @@ static uint64_t edu_mmio_read(void *opaque, hwaddr add= r, unsigned size) return val; } =20 + if (addr >=3D 0x80 && size !=3D 4 && size !=3D 8) { + return val; + } + switch (addr) { case 0x00: val =3D 0x010000edu; --=20 2.17.1