From nobody Tue Feb 10 13:18:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1555746722; cv=none; d=zoho.com; s=zohoarc; b=UGklRV81AAe/L93jadXWTxtgd2EUyN5mu/v4FDqlRtrV6YdzlGN9g4ZReDtDHrFey453loK0Fm+Bc9/mXr5ZZcEE9nKxq6544XblBCZBFlL+P08zoUxXWMhXRfAOPKmrXEq1MOwMPjTc5zTssNWgfPAZJ4DsSdzmnb+3lmm1q0s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555746722; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=BobRUDDq3dnwwt/qXps0agrFTDkezRLKK87vg29L7R4=; b=ir6R6SQBov7SAa8P0WxtU4VhFFahmMeV3cYSRymfyYqNW/TBg8HDTsgMQbQpt3WQbX2rTTdpwR6JZ1xmwutwpoDdfOl8vbgh7Ks7ArVi1cpAaQ0CcpaN82D0jqs4kMIbKChgVuYdAkHMANkYKan82T2bmCrv3na1wLukOglyWfs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555746722163577.939850872455; Sat, 20 Apr 2019 00:52:02 -0700 (PDT) Received: from localhost ([127.0.0.1]:38299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHkn1-00063Q-6z for importer@patchew.org; Sat, 20 Apr 2019 03:51:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHkXG-0000gZ-IK for qemu-devel@nongnu.org; Sat, 20 Apr 2019 03:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHkXC-0000H0-0t for qemu-devel@nongnu.org; Sat, 20 Apr 2019 03:35:39 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:42015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHkXB-0008U2-Oj for qemu-devel@nongnu.org; Sat, 20 Apr 2019 03:35:37 -0400 Received: by mail-pl1-x642.google.com with SMTP id cv12so3533292plb.9 for ; Sat, 20 Apr 2019 00:35:24 -0700 (PDT) Received: from localhost.localdomain (rrcs-66-91-136-155.west.biz.rr.com. [66.91.136.155]) by smtp.gmail.com with ESMTPSA id z22sm7025492pgv.23.2019.04.20.00.35.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Apr 2019 00:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BobRUDDq3dnwwt/qXps0agrFTDkezRLKK87vg29L7R4=; b=Lq9jyXh8dPQfAeeu4RrTpPeVB2gyMKcVeSZMBgb5+1gQ/oyvIohjbIT9XgDzqxFuLW 3WdexrYihohU3f2hHtsidux2k6boZnbiC5f5zP1SkMnJmfbhVEQCDUZnToVTYe4NIAJA 5ICft3oUq+SgsijbfXuWdAzGJFsxF/Na9e53cLT7ha9EcKySJo0LSsGUmGeraVZBpUo/ KpY1gWMDl3B0gqhQP3islPdYkG2wOgeRXqVNdh32pz9GU0p623qaY7SJpHoDhVB+K6ka 5+nFUoCwT8BWH0pYcOAvGGqBcR6SYDeRezoWY3VRBfAJgOLtEDuehP59kHnL/RqHEw8P Lc2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BobRUDDq3dnwwt/qXps0agrFTDkezRLKK87vg29L7R4=; b=ldVaWplsR1jKH9HhIcZA2LsJrnWPWcZuP/NNpPASTKXtwkYDFTL6ZBtH/xav6kK21L 7SGl/nZocUmWyisSHiTogry612zdIhrDDDR1oGwSJ5zhTkWr8rkCZPKu+HnrctVKCjFR fbN0Tr2WL4LBkuw1Ne4R08o+fvlzxitXFizFjLzag3m4Zy5K+oKAP8K0Pv1EVkuYxnmu yTUdLnz0J/BL0waUiBDbW6TB40WWBNcHB02cSAncO1sm8rpDWIPMVVAspkY5raR/VHd/ mXrH/KHcP1w18SRSDjF77DXZvwhpS1XtkBz6UrcsYmrStcwyptS1EOmhJBSC82af6+ML Uz6A== X-Gm-Message-State: APjAAAVl7g/F7AL28jZg3iSQo57+ALrsVAMedR3aUFbuqeGJOzfBARqQ H3RgYSG8uu3TiCjNPhutNL7V3jUGypI= X-Google-Smtp-Source: APXvYqyruKzEVeVZw1fZQHuZSaox0yDBE5vRpFeyromre/MLinJhm9W4LHsizjhNcBUyyudnyj6J4A== X-Received: by 2002:a17:902:778d:: with SMTP id o13mr2589862pll.314.1555745723146; Sat, 20 Apr 2019 00:35:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 19 Apr 2019 21:34:27 -1000 Message-Id: <20190420073442.7488-24-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190420073442.7488-1-richard.henderson@linaro.org> References: <20190420073442.7488-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::642 Subject: [Qemu-devel] [PATCH 23/38] target/ppc: Use tcg_gen_abs_tl X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson --- target/ppc/translate.c | 80 +++++++++++++++++------------------------- 1 file changed, 32 insertions(+), 48 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index badc1ae1a3..97b8e8ddaf 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -5013,39 +5013,27 @@ static void gen_ecowx(DisasContext *ctx) /* abs - abs. */ static void gen_abs(DisasContext *ctx) { - TCGLabel *l1 =3D gen_new_label(); - TCGLabel *l2 =3D gen_new_label(); - tcg_gen_brcondi_tl(TCG_COND_GE, cpu_gpr[rA(ctx->opcode)], 0, l1); - tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - tcg_gen_br(l2); - gen_set_label(l1); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - gen_set_label(l2); - if (unlikely(Rc(ctx->opcode) !=3D 0)) - gen_set_Rc0(ctx, cpu_gpr[rD(ctx->opcode)]); + TCGv d =3D cpu_gpr[rD(ctx->opcode)]; + TCGv a =3D cpu_gpr[rA(ctx->opcode)]; + + tcg_gen_abs_tl(d, a); + if (unlikely(Rc(ctx->opcode) !=3D 0)) { + gen_set_Rc0(ctx, d); + } } =20 /* abso - abso. */ static void gen_abso(DisasContext *ctx) { - TCGLabel *l1 =3D gen_new_label(); - TCGLabel *l2 =3D gen_new_label(); - TCGLabel *l3 =3D gen_new_label(); - /* Start with XER OV disabled, the most likely case */ - tcg_gen_movi_tl(cpu_ov, 0); - tcg_gen_brcondi_tl(TCG_COND_GE, cpu_gpr[rA(ctx->opcode)], 0, l2); - tcg_gen_brcondi_tl(TCG_COND_NE, cpu_gpr[rA(ctx->opcode)], 0x80000000, = l1); - tcg_gen_movi_tl(cpu_ov, 1); - tcg_gen_movi_tl(cpu_so, 1); - tcg_gen_br(l2); - gen_set_label(l1); - tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - tcg_gen_br(l3); - gen_set_label(l2); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - gen_set_label(l3); - if (unlikely(Rc(ctx->opcode) !=3D 0)) - gen_set_Rc0(ctx, cpu_gpr[rD(ctx->opcode)]); + TCGv d =3D cpu_gpr[rD(ctx->opcode)]; + TCGv a =3D cpu_gpr[rA(ctx->opcode)]; + + tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_ov, a, 0x80000000); + tcg_gen_abs_tl(d, a); + tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov); + if (unlikely(Rc(ctx->opcode) !=3D 0)) { + gen_set_Rc0(ctx, d); + } } =20 /* clcs */ @@ -5265,33 +5253,29 @@ static void gen_mulo(DisasContext *ctx) /* nabs - nabs. */ static void gen_nabs(DisasContext *ctx) { - TCGLabel *l1 =3D gen_new_label(); - TCGLabel *l2 =3D gen_new_label(); - tcg_gen_brcondi_tl(TCG_COND_GT, cpu_gpr[rA(ctx->opcode)], 0, l1); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - tcg_gen_br(l2); - gen_set_label(l1); - tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - gen_set_label(l2); - if (unlikely(Rc(ctx->opcode) !=3D 0)) - gen_set_Rc0(ctx, cpu_gpr[rD(ctx->opcode)]); + TCGv d =3D cpu_gpr[rD(ctx->opcode)]; + TCGv a =3D cpu_gpr[rA(ctx->opcode)]; + + tcg_gen_abs_tl(d, a); + tcg_gen_neg_tl(d, d); + if (unlikely(Rc(ctx->opcode) !=3D 0)) { + gen_set_Rc0(ctx, d); + } } =20 /* nabso - nabso. */ static void gen_nabso(DisasContext *ctx) { - TCGLabel *l1 =3D gen_new_label(); - TCGLabel *l2 =3D gen_new_label(); - tcg_gen_brcondi_tl(TCG_COND_GT, cpu_gpr[rA(ctx->opcode)], 0, l1); - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - tcg_gen_br(l2); - gen_set_label(l1); - tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); - gen_set_label(l2); + TCGv d =3D cpu_gpr[rD(ctx->opcode)]; + TCGv a =3D cpu_gpr[rA(ctx->opcode)]; + + tcg_gen_abs_tl(d, a); + tcg_gen_neg_tl(d, d); /* nabs never overflows */ tcg_gen_movi_tl(cpu_ov, 0); - if (unlikely(Rc(ctx->opcode) !=3D 0)) - gen_set_Rc0(ctx, cpu_gpr[rD(ctx->opcode)]); + if (unlikely(Rc(ctx->opcode) !=3D 0)) { + gen_set_Rc0(ctx, d); + } } =20 /* rlmi - rlmi. */ --=20 2.17.1