From nobody Mon Feb 9 04:45:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555654572; cv=none; d=zoho.com; s=zohoarc; b=TJ6kJQWkT9lHrFpZeVkhQOL6cT7bhw0O6Ds5eWkmIG5Ee9/M4HWBD+Qy1J9QDVnSBVGMCF3jQrPiIUXTVIHEAuUr1HUFb+3llX4egHveHfNZA9ZHrFApT1v/T5iLnrCLL+2y8zxVn/hc8xixiP3NjPreCsibLLuislufc1THdIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555654572; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=IAG3rNr9fUJABK6XLSJLq/GIx3W39GS+OMKchSGJX2A=; b=SrgDmoadlB9bVwRzXLskCPBXdJqDLzlTx0cDWLTOfWs5bbluncic/twDn32ar2qbvP6BqJmAxcn/dkiKrsvy9JFzwhmNwq8RWENY6x/El5stj1WFT0b8xzAJqCQEGX0heoE1rI/oOdVZwzataM8DcRxMaf4yn7PGPKET4xTxQPE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555654572683740.0981379605408; Thu, 18 Apr 2019 23:16:12 -0700 (PDT) Received: from localhost ([127.0.0.1]:51863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHMoZ-0006Nn-KZ for importer@patchew.org; Fri, 19 Apr 2019 02:15:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHMmc-00055k-26 for qemu-devel@nongnu.org; Fri, 19 Apr 2019 02:13:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHMmb-0004l9-4n for qemu-devel@nongnu.org; Fri, 19 Apr 2019 02:13:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50586) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHMma-0004kq-VQ for qemu-devel@nongnu.org; Fri, 19 Apr 2019 02:13:57 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3504283F3A; Fri, 19 Apr 2019 06:13:56 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id B02735D9C5; Fri, 19 Apr 2019 06:13:55 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 19 Apr 2019 03:13:34 -0300 Message-Id: <20190419061349.17094-3-ehabkost@redhat.com> In-Reply-To: <20190419061349.17094-1-ehabkost@redhat.com> References: <20190419061349.17094-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 19 Apr 2019 06:13:56 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 02/17] vl.c: make find_default_machine() local X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Igor Mammedov , Wei Yang , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Wei Yang Function find_default_machine() is introduced by commit 2c8cffa599b7 "vl: make find_default_machine externally visible", and it was used outside of vl.c until commit a904410af5f1 "pc_sysfw: remove the rom_only property". Commit a904410af5f1 "pc_sysfw: remove the rom_only property" removed the only user of find_default_machine() outside vl.c, but neglected to make it static. Do that now. Signed-off-by: Wei Yang Message-Id: <20190405064121.23662-2-richardw.yang@linux.intel.com> Reviewed-by: Markus Armbruster Signed-off-by: Eduardo Habkost --- include/hw/boards.h | 1 - vl.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index fe1885cbff..6f7916f88f 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -57,7 +57,6 @@ void memory_region_allocate_system_memory(MemoryRegion *m= r, Object *owner, #define MACHINE_CLASS(klass) \ OBJECT_CLASS_CHECK(MachineClass, (klass), TYPE_MACHINE) =20 -MachineClass *find_default_machine(void); extern MachineState *current_machine; =20 void machine_run_board_init(MachineState *machine); diff --git a/vl.c b/vl.c index c696ad2a13..9d6a519d74 100644 --- a/vl.c +++ b/vl.c @@ -1488,7 +1488,7 @@ static MachineClass *find_machine(const char *name) return mc; } =20 -MachineClass *find_default_machine(void) +static MachineClass *find_default_machine(void) { GSList *el, *machines =3D object_class_get_list(TYPE_MACHINE, false); MachineClass *mc =3D NULL; --=20 2.18.0.rc1.1.g3f1ff2140