[Qemu-devel] [PULL for-4.1 00/36] Error reporting & monitor patches for 2019-04-18

Markus Armbruster posted 36 patches 4 years, 11 months ago
Test checkpatch failed
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190418205135.6686-1-armbru@redhat.com
Maintainers: Riku Voipio <riku.voipio@iki.fi>, Markus Armbruster <armbru@redhat.com>, Alistair Francis <Alistair.Francis@wdc.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Anthony Green <green@moxielogic.com>, Max Reitz <mreitz@redhat.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Andrzej Zaborowski <balrogg@gmail.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Eric Blake <eblake@redhat.com>, Stefan Weil <sw@weilnetz.de>, Richard Henderson <rth@twiddle.net>, Kevin Wolf <kwolf@redhat.com>, Stafford Horne <shorne@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, Halil Pasic <pasic@linux.ibm.com>, Laurent Vivier <laurent@vivier.eu>, Palmer Dabbelt <palmer@sifive.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, Paul Burton <pburton@wavecomp.com>, Stefan Hajnoczi <stefanha@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, David Hildenbrand <david@redhat.com>, Marek Vasut <marex@denx.de>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Michael Walle <michael@walle.cc>, David Gibson <david@gibson.dropbear.id.au>, "Richard W.M. Jones" <rjones@redhat.com>, Chris Wulff <crwulff@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Cornelia Huck <cohuck@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
MAINTAINERS                        |   2 +
accel/kvm/kvm-all.c                |   4 +-
accel/tcg/translate-all.c          |  49 ++---
block/qapi.c                       | 120 ++++++-------
block/ssh.c                        |  38 ++--
block/trace-events                 |   3 +
blockdev.c                         |   9 +-
bsd-user/main.c                    |   6 +-
chardev/char-pty.c                 |   5 +-
chardev/char.c                     |   3 +-
cpus.c                             |  21 ++-
disas.c                            |   5 +-
disas/alpha.c                      |   2 +-
disas/arm-a64.cc                   |   2 +-
disas/arm.c                        |   2 +-
disas/cris.c                       |   2 +-
disas/hppa.c                       |   2 +-
disas/i386.c                       |   2 +-
disas/lm32.c                       |   2 +-
disas/m68k.c                       |   2 +-
disas/microblaze.c                 |   2 +-
disas/mips.c                       |   2 +-
disas/moxie.c                      |   2 +-
disas/nanomips.cpp                 |   2 +-
disas/nios2.c                      |   2 +-
disas/ppc.c                        |   2 +-
disas/riscv.c                      |   2 +-
disas/s390.c                       |   2 +-
disas/sh4.c                        |   2 +-
disas/sparc.c                      |   2 +-
disas/tci.c                        |   2 +-
disas/xtensa.c                     |   2 +-
exec.c                             |  42 ++---
hmp.c                              |  12 +-
hw/core/loader-fit.c               |  62 ++++---
hw/mips/boston.c                   |   6 +-
hw/pci/pci.c                       |   2 +-
hw/timer/hpet.c                    |   2 +-
hw/vfio/pci.c                      |  19 +-
include/block/qapi.h               |   9 +-
include/disas/{bfd.h => dis-asm.h} |   5 +-
include/exec/cpu-all.h             |   4 +-
include/exec/cpu-common.h          |  13 --
include/exec/log.h                 |   2 +-
include/exec/memory-internal.h     |   3 +-
include/exec/memory.h              |   3 +-
include/monitor/monitor.h          |   8 +-
include/qemu-common.h              |   2 -
include/qemu/cutils.h              |   2 -
include/qemu/error-report.h        |  11 +-
include/qemu/fprintf-fn.h          |  14 --
include/qemu/qemu-print.h          |  23 +++
include/qemu/qsp.h                 |   6 +-
include/qom/cpu.h                  |  24 +--
include/sysemu/cpus.h              |   4 +-
linux-user/alpha/cpu_loop.c        |   2 +-
linux-user/cpu_loop-common.h       |   2 +-
linux-user/cris/cpu_loop.c         |   2 +-
linux-user/main.c                  |   4 +-
linux-user/microblaze/cpu_loop.c   |   4 +-
linux-user/s390x/cpu_loop.c        |   4 +-
linux-user/sh4/cpu_loop.c          |   2 +-
linux-user/sparc/cpu_loop.c        |   2 +-
memory.c                           | 156 ++++++++--------
monitor.c                          |  89 ++++------
qdev-monitor.c                     |  36 ++--
qemu-img.c                         |  14 +-
qemu-io-cmds.c                     |   2 +-
qemu-io.c                          |  14 +-
qemu-nbd.c                         |   2 +-
qom/cpu.c                          |  11 +-
scsi/qemu-pr-helper.c              |   1 +
stubs/error-printf.c               |  13 +-
stubs/monitor.c                    |   5 +
target/alpha/cpu.c                 |  15 +-
target/alpha/cpu.h                 |   5 +-
target/alpha/helper.c              |  24 +--
target/arm/arm-semi.c              |   2 +-
target/arm/cpu.c                   |   1 -
target/arm/cpu.h                   |   5 +-
target/arm/helper.c                |  15 +-
target/arm/translate-a64.c         |  82 ++++-----
target/arm/translate.c             |  58 +++---
target/arm/translate.h             |   7 +-
target/cris/cpu.c                  |  14 +-
target/cris/cpu.h                  |   5 +-
target/cris/helper.c               |   2 +-
target/cris/translate.c            |  36 ++--
target/hppa/cpu.c                  |  14 +-
target/hppa/cpu.h                  |   4 +-
target/hppa/helper.c               |  24 +--
target/i386/cpu.c                  |  29 ++-
target/i386/cpu.h                  |   8 +-
target/i386/hax-all.c              |   4 +-
target/i386/helper.c               | 356 ++++++++++++++++++-------------------
target/i386/monitor.c              |   3 +-
target/lm32/cpu.c                  |  14 +-
target/lm32/cpu.h                  |   5 +-
target/lm32/translate.c            |  36 ++--
target/m68k/cpu.h                  |   8 +-
target/m68k/helper.c               | 129 +++++++-------
target/m68k/monitor.c              |   2 +-
target/m68k/translate.c            |  86 ++++-----
target/microblaze/cpu.h            |   3 +-
target/microblaze/helper.c         |   2 +-
target/microblaze/translate.c      |  39 ++--
target/mips/cpu.h                  |   2 +-
target/mips/internal.h             |   3 +-
target/mips/translate.c            |  77 ++++----
target/mips/translate_init.inc.c   |   5 +-
target/moxie/cpu.h                 |   3 +-
target/moxie/helper.c              |   2 +-
target/moxie/translate.c           |  22 +--
target/nios2/cpu.h                 |   5 +-
target/nios2/helper.c              |   2 +-
target/nios2/mmu.c                 |   7 +-
target/nios2/monitor.c             |   2 +-
target/nios2/translate.c           |  24 +--
target/openrisc/cpu.c              |  15 +-
target/openrisc/cpu.h              |   5 +-
target/openrisc/disas.c            |   2 +-
target/openrisc/translate.c        |  11 +-
target/ppc/cpu.h                   |  10 +-
target/ppc/mmu-hash64.c            |   7 +-
target/ppc/mmu-hash64.h            |   2 +-
target/ppc/mmu_helper.c            |  70 ++++----
target/ppc/monitor.c               |   2 +-
target/ppc/translate.c             | 170 +++++++++---------
target/ppc/translate_init.inc.c    |  28 ++-
target/riscv/cpu.c                 |  54 +++---
target/riscv/cpu.h                 |   2 +-
target/s390x/cpu.h                 |   2 +-
target/s390x/cpu_models.c          |  21 +--
target/s390x/helper.c              |  42 ++---
target/s390x/internal.h            |   3 +-
target/s390x/kvm.c                 |   2 +-
target/sh4/cpu.c                   |  17 +-
target/sh4/cpu.h                   |   5 +-
target/sh4/translate.c             |  27 +--
target/sparc/cpu.c                 | 133 +++++++-------
target/sparc/cpu.h                 |   7 +-
target/sparc/ldst_helper.c         |  18 +-
target/sparc/mmu_helper.c          |  97 +++++-----
target/sparc/monitor.c             |   2 +-
target/tilegx/cpu.c                |  14 +-
target/tricore/cpu.h               |   5 +-
target/tricore/helper.c            |  15 +-
target/tricore/translate.c         |  26 +--
target/unicore32/cpu.h             |   3 +-
target/unicore32/translate.c       |  39 ++--
target/xtensa/cpu.h                |   7 +-
target/xtensa/helper.c             |   7 +-
target/xtensa/mmu_helper.c         |  24 ++-
target/xtensa/monitor.c            |   2 +-
target/xtensa/translate.c          |  40 +++--
tcg/tcg.c                          |  50 +++---
tcg/tcg.h                          |   4 +-
tests/test-util-sockets.c          |   1 +
trace/simple.c                     |   7 +-
trace/simple.h                     |   2 +-
util/Makefile.objs                 |   1 +
util/error.c                       |   9 +-
util/qemu-error.c                  |  67 ++++++-
util/qemu-print.c                  |  69 +++++++
util/qsp.c                         |  21 +--
vl.c                               |  14 +-
166 files changed, 1651 insertions(+), 1669 deletions(-)
rename include/disas/{bfd.h => dis-asm.h} (99%)
delete mode 100644 include/qemu/fprintf-fn.h
create mode 100644 include/qemu/qemu-print.h
create mode 100644 util/qemu-print.c
[Qemu-devel] [PULL for-4.1 00/36] Error reporting & monitor patches for 2019-04-18
Posted by Markus Armbruster 4 years, 11 months ago
Early pull request because I'll be on vacation when 4.1 opens.  Hope
that's okay.

The following changes since commit eeba63fc7fface36f438bcbc0d3b02e7dcb59983:

  Update version for v4.0.0-rc4 release (2019-04-16 21:53:00 +0100)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-error-monitor-2019-04-18

for you to fetch changes up to ede9a8a656c992deecce45f8175985dd81cc6be9:

  include: Move fprintf_function to disas/ (2019-04-18 22:18:59 +0200)

----------------------------------------------------------------
Error reporting & monitor patches for 2019-04-18

----------------------------------------------------------------
Christophe Fergeau (2):
      qemu-io: Use error_[gs]et_progname()
      log: Make glib logging go through QEMU

Markus Armbruster (33):
      error: Fix error_report_err(), warn_report_err() hint printing
      qemu-img: Use error_vreport() in error_exit()
      block/ssh: Do not report read/write/flush errors to the user
      loader-fit: Wean off error_printf()
      mips/boston: Report errors with error_report(), not error_printf()
      pci: Report fatal errors with error_report(), not error_printf()
      hpet: Report warnings with warn_report(), not error_printf()
      vfio: Report warnings with warn_report(), not error_printf()
      s390x/kvm: Report warnings with warn_report(), not error_printf()
      vl: Make -machine $TYPE,help and -accel help print to stdout
      monitor error: Make printf()-like functions return a value
      qemu-print: New qemu_printf(), qemu_vprintf() etc.
      blockdev: Make -drive format=help print to stdout
      char: Make -chardev help print to stdout
      char-pty: Print "char device redirected" message to stdout
      monitor: Simplify how -device/device_add print help
      include: Include fprintf-fn.h only where needed
      trace: Simplify how st_print_trace_file_status() prints
      tcg: Simplify how dump_opcount_info() prints
      tcg: Simplify how dump_exec_info() prints
      tcg: Simplify how dump_drift_info() prints
      qsp: Simplify how qsp_report() prints
      block/qapi: Clean up how we print to monitor or stdout
      memory: Clean up how mtree_info() prints
      target: Simplify how the TARGET_cpu_list() print
      target: Clean up how the dump_mmu() print
      target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
      qom/cpu: Simplify how CPUClass::dump_statistics() prints
      qemu-print: New qemu_fprintf(), qemu_vfprintf()
      qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
      monitor: Clean up how monitor_disas() funnels output to monitor
      disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
      include: Move fprintf_function to disas/

Vladimir Sementsov-Ogievskiy (1):
      util/error: do not free error on error_abort

 MAINTAINERS                        |   2 +
 accel/kvm/kvm-all.c                |   4 +-
 accel/tcg/translate-all.c          |  49 ++---
 block/qapi.c                       | 120 ++++++-------
 block/ssh.c                        |  38 ++--
 block/trace-events                 |   3 +
 blockdev.c                         |   9 +-
 bsd-user/main.c                    |   6 +-
 chardev/char-pty.c                 |   5 +-
 chardev/char.c                     |   3 +-
 cpus.c                             |  21 ++-
 disas.c                            |   5 +-
 disas/alpha.c                      |   2 +-
 disas/arm-a64.cc                   |   2 +-
 disas/arm.c                        |   2 +-
 disas/cris.c                       |   2 +-
 disas/hppa.c                       |   2 +-
 disas/i386.c                       |   2 +-
 disas/lm32.c                       |   2 +-
 disas/m68k.c                       |   2 +-
 disas/microblaze.c                 |   2 +-
 disas/mips.c                       |   2 +-
 disas/moxie.c                      |   2 +-
 disas/nanomips.cpp                 |   2 +-
 disas/nios2.c                      |   2 +-
 disas/ppc.c                        |   2 +-
 disas/riscv.c                      |   2 +-
 disas/s390.c                       |   2 +-
 disas/sh4.c                        |   2 +-
 disas/sparc.c                      |   2 +-
 disas/tci.c                        |   2 +-
 disas/xtensa.c                     |   2 +-
 exec.c                             |  42 ++---
 hmp.c                              |  12 +-
 hw/core/loader-fit.c               |  62 ++++---
 hw/mips/boston.c                   |   6 +-
 hw/pci/pci.c                       |   2 +-
 hw/timer/hpet.c                    |   2 +-
 hw/vfio/pci.c                      |  19 +-
 include/block/qapi.h               |   9 +-
 include/disas/{bfd.h => dis-asm.h} |   5 +-
 include/exec/cpu-all.h             |   4 +-
 include/exec/cpu-common.h          |  13 --
 include/exec/log.h                 |   2 +-
 include/exec/memory-internal.h     |   3 +-
 include/exec/memory.h              |   3 +-
 include/monitor/monitor.h          |   8 +-
 include/qemu-common.h              |   2 -
 include/qemu/cutils.h              |   2 -
 include/qemu/error-report.h        |  11 +-
 include/qemu/fprintf-fn.h          |  14 --
 include/qemu/qemu-print.h          |  23 +++
 include/qemu/qsp.h                 |   6 +-
 include/qom/cpu.h                  |  24 +--
 include/sysemu/cpus.h              |   4 +-
 linux-user/alpha/cpu_loop.c        |   2 +-
 linux-user/cpu_loop-common.h       |   2 +-
 linux-user/cris/cpu_loop.c         |   2 +-
 linux-user/main.c                  |   4 +-
 linux-user/microblaze/cpu_loop.c   |   4 +-
 linux-user/s390x/cpu_loop.c        |   4 +-
 linux-user/sh4/cpu_loop.c          |   2 +-
 linux-user/sparc/cpu_loop.c        |   2 +-
 memory.c                           | 156 ++++++++--------
 monitor.c                          |  89 ++++------
 qdev-monitor.c                     |  36 ++--
 qemu-img.c                         |  14 +-
 qemu-io-cmds.c                     |   2 +-
 qemu-io.c                          |  14 +-
 qemu-nbd.c                         |   2 +-
 qom/cpu.c                          |  11 +-
 scsi/qemu-pr-helper.c              |   1 +
 stubs/error-printf.c               |  13 +-
 stubs/monitor.c                    |   5 +
 target/alpha/cpu.c                 |  15 +-
 target/alpha/cpu.h                 |   5 +-
 target/alpha/helper.c              |  24 +--
 target/arm/arm-semi.c              |   2 +-
 target/arm/cpu.c                   |   1 -
 target/arm/cpu.h                   |   5 +-
 target/arm/helper.c                |  15 +-
 target/arm/translate-a64.c         |  82 ++++-----
 target/arm/translate.c             |  58 +++---
 target/arm/translate.h             |   7 +-
 target/cris/cpu.c                  |  14 +-
 target/cris/cpu.h                  |   5 +-
 target/cris/helper.c               |   2 +-
 target/cris/translate.c            |  36 ++--
 target/hppa/cpu.c                  |  14 +-
 target/hppa/cpu.h                  |   4 +-
 target/hppa/helper.c               |  24 +--
 target/i386/cpu.c                  |  29 ++-
 target/i386/cpu.h                  |   8 +-
 target/i386/hax-all.c              |   4 +-
 target/i386/helper.c               | 356 ++++++++++++++++++-------------------
 target/i386/monitor.c              |   3 +-
 target/lm32/cpu.c                  |  14 +-
 target/lm32/cpu.h                  |   5 +-
 target/lm32/translate.c            |  36 ++--
 target/m68k/cpu.h                  |   8 +-
 target/m68k/helper.c               | 129 +++++++-------
 target/m68k/monitor.c              |   2 +-
 target/m68k/translate.c            |  86 ++++-----
 target/microblaze/cpu.h            |   3 +-
 target/microblaze/helper.c         |   2 +-
 target/microblaze/translate.c      |  39 ++--
 target/mips/cpu.h                  |   2 +-
 target/mips/internal.h             |   3 +-
 target/mips/translate.c            |  77 ++++----
 target/mips/translate_init.inc.c   |   5 +-
 target/moxie/cpu.h                 |   3 +-
 target/moxie/helper.c              |   2 +-
 target/moxie/translate.c           |  22 +--
 target/nios2/cpu.h                 |   5 +-
 target/nios2/helper.c              |   2 +-
 target/nios2/mmu.c                 |   7 +-
 target/nios2/monitor.c             |   2 +-
 target/nios2/translate.c           |  24 +--
 target/openrisc/cpu.c              |  15 +-
 target/openrisc/cpu.h              |   5 +-
 target/openrisc/disas.c            |   2 +-
 target/openrisc/translate.c        |  11 +-
 target/ppc/cpu.h                   |  10 +-
 target/ppc/mmu-hash64.c            |   7 +-
 target/ppc/mmu-hash64.h            |   2 +-
 target/ppc/mmu_helper.c            |  70 ++++----
 target/ppc/monitor.c               |   2 +-
 target/ppc/translate.c             | 170 +++++++++---------
 target/ppc/translate_init.inc.c    |  28 ++-
 target/riscv/cpu.c                 |  54 +++---
 target/riscv/cpu.h                 |   2 +-
 target/s390x/cpu.h                 |   2 +-
 target/s390x/cpu_models.c          |  21 +--
 target/s390x/helper.c              |  42 ++---
 target/s390x/internal.h            |   3 +-
 target/s390x/kvm.c                 |   2 +-
 target/sh4/cpu.c                   |  17 +-
 target/sh4/cpu.h                   |   5 +-
 target/sh4/translate.c             |  27 +--
 target/sparc/cpu.c                 | 133 +++++++-------
 target/sparc/cpu.h                 |   7 +-
 target/sparc/ldst_helper.c         |  18 +-
 target/sparc/mmu_helper.c          |  97 +++++-----
 target/sparc/monitor.c             |   2 +-
 target/tilegx/cpu.c                |  14 +-
 target/tricore/cpu.h               |   5 +-
 target/tricore/helper.c            |  15 +-
 target/tricore/translate.c         |  26 +--
 target/unicore32/cpu.h             |   3 +-
 target/unicore32/translate.c       |  39 ++--
 target/xtensa/cpu.h                |   7 +-
 target/xtensa/helper.c             |   7 +-
 target/xtensa/mmu_helper.c         |  24 ++-
 target/xtensa/monitor.c            |   2 +-
 target/xtensa/translate.c          |  40 +++--
 tcg/tcg.c                          |  50 +++---
 tcg/tcg.h                          |   4 +-
 tests/test-util-sockets.c          |   1 +
 trace/simple.c                     |   7 +-
 trace/simple.h                     |   2 +-
 util/Makefile.objs                 |   1 +
 util/error.c                       |   9 +-
 util/qemu-error.c                  |  67 ++++++-
 util/qemu-print.c                  |  69 +++++++
 util/qsp.c                         |  21 +--
 vl.c                               |  14 +-
 166 files changed, 1651 insertions(+), 1669 deletions(-)
 rename include/disas/{bfd.h => dis-asm.h} (99%)
 delete mode 100644 include/qemu/fprintf-fn.h
 create mode 100644 include/qemu/qemu-print.h
 create mode 100644 util/qemu-print.c

-- 
2.17.2


Re: [Qemu-devel] [PULL for-4.1 00/36] Error reporting & monitor patches for 2019-04-18
Posted by no-reply@patchew.org 4 years, 11 months ago
Patchew URL: https://patchew.org/QEMU/20190418205135.6686-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190418205135.6686-1-armbru@redhat.com
Subject: [Qemu-devel] [PULL for-4.1 00/36] Error reporting & monitor patches for 2019-04-18

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190418205135.6686-1-armbru@redhat.com -> patchew/20190418205135.6686-1-armbru@redhat.com
Switched to a new branch 'test'
f65f9a57a6 include: Move fprintf_function to disas/
3613cf2952 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h
8362074a2c monitor: Clean up how monitor_disas() funnels output to monitor
41465772c0 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints
49fd3a8181 qemu-print: New qemu_fprintf(), qemu_vfprintf()
195a57362a qom/cpu: Simplify how CPUClass::dump_statistics() prints
b439ddf49d target/i386: Simplify how x86_cpu_dump_local_apic_state() prints
f02a059161 target: Clean up how the dump_mmu() print
71ad53d2d8 target: Simplify how the TARGET_cpu_list() print
e48c937bbb memory: Clean up how mtree_info() prints
de799bd96a block/qapi: Clean up how we print to monitor or stdout
de39c5a100 qsp: Simplify how qsp_report() prints
e597dab6a6 tcg: Simplify how dump_drift_info() prints
903672bb0a tcg: Simplify how dump_exec_info() prints
b011a591b1 tcg: Simplify how dump_opcount_info() prints
e2066e0297 trace: Simplify how st_print_trace_file_status() prints
ba66678390 include: Include fprintf-fn.h only where needed
6bf830e5fa monitor: Simplify how -device/device_add print help
f9837a2629 char-pty: Print "char device redirected" message to stdout
8ffea401ea char: Make -chardev help print to stdout
7e517c0c83 blockdev: Make -drive format=help print to stdout
4fc29bdae6 qemu-print: New qemu_printf(), qemu_vprintf() etc.
da66543644 monitor error: Make printf()-like functions return a value
bb86c3751c vl: Make -machine $TYPE, help and -accel help print to stdout
f0f1843fa5 s390x/kvm: Report warnings with warn_report(), not error_printf()
30004a79dd vfio: Report warnings with warn_report(), not error_printf()
86648932be hpet: Report warnings with warn_report(), not error_printf()
77849d6ae3 pci: Report fatal errors with error_report(), not error_printf()
5384051d57 mips/boston: Report errors with error_report(), not error_printf()
5542ac28ff loader-fit: Wean off error_printf()
390e511dee block/ssh: Do not report read/write/flush errors to the user
85da455e60 qemu-img: Use error_vreport() in error_exit()
376c0acbff util/error: do not free error on error_abort
d515fdf4f0 error: Fix error_report_err(), warn_report_err() hint printing
d4406797be log: Make glib logging go through QEMU
3c051888c6 qemu-io: Use error_[gs]et_progname()

=== OUTPUT BEGIN ===
1/36 Checking commit 3c051888c617 (qemu-io: Use error_[gs]et_progname())
2/36 Checking commit d4406797beb3 (log: Make glib logging go through QEMU)
3/36 Checking commit d515fdf4f02b (error: Fix error_report_err(), warn_report_err() hint printing)
4/36 Checking commit 376c0acbff33 (util/error: do not free error on error_abort)
5/36 Checking commit 85da455e604b (qemu-img: Use error_vreport() in error_exit())
6/36 Checking commit 390e511dee92 (block/ssh: Do not report read/write/flush errors to the user)
7/36 Checking commit 5542ac28ff9b (loader-fit: Wean off error_printf())
8/36 Checking commit 5384051d5721 (mips/boston: Report errors with error_report(), not error_printf())
9/36 Checking commit 77849d6ae3cf (pci: Report fatal errors with error_report(), not error_printf())
10/36 Checking commit 86648932bea9 (hpet: Report warnings with warn_report(), not error_printf())
11/36 Checking commit 30004a79dd0d (vfio: Report warnings with warn_report(), not error_printf())
12/36 Checking commit f0f1843fa518 (s390x/kvm: Report warnings with warn_report(), not error_printf())
13/36 Checking commit bb86c3751c7d (vl: Make -machine $TYPE, help and -accel help print to stdout)
14/36 Checking commit da6654364435 (monitor error: Make printf()-like functions return a value)
15/36 Checking commit 4fc29bdae6ff (qemu-print: New qemu_printf(), qemu_vprintf() etc.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 94 lines checked

Patch 15/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/36 Checking commit 7e517c0c8383 (blockdev: Make -drive format=help print to stdout)
17/36 Checking commit 8ffea401ea28 (char: Make -chardev help print to stdout)
18/36 Checking commit f9837a26297b (char-pty: Print "char device redirected" message to stdout)
19/36 Checking commit 6bf830e5fac5 (monitor: Simplify how -device/device_add print help)
20/36 Checking commit ba6667839046 (include: Include fprintf-fn.h only where needed)
21/36 Checking commit e2066e029740 (trace: Simplify how st_print_trace_file_status() prints)
22/36 Checking commit b011a591b165 (tcg: Simplify how dump_opcount_info() prints)
23/36 Checking commit 903672bb0a4a (tcg: Simplify how dump_exec_info() prints)
24/36 Checking commit e597dab6a65a (tcg: Simplify how dump_drift_info() prints)
25/36 Checking commit de39c5a100c3 (qsp: Simplify how qsp_report() prints)
26/36 Checking commit de799bd96ae3 (block/qapi: Clean up how we print to monitor or stdout)
27/36 Checking commit e48c937bbbe0 (memory: Clean up how mtree_info() prints)
28/36 Checking commit 71ad53d2d8cf (target: Simplify how the TARGET_cpu_list() print)
29/36 Checking commit f02a05916155 (target: Clean up how the dump_mmu() print)
WARNING: line over 80 characters
#950: FILE: target/xtensa/mmu_helper.c:784:
+                    qemu_printf("\tVaddr       Paddr       ASID  Attr RWX Cache\n"

total: 0 errors, 1 warnings, 848 lines checked

Patch 29/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/36 Checking commit b439ddf49dd3 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints)
31/36 Checking commit 195a57362a6f (qom/cpu: Simplify how CPUClass::dump_statistics() prints)
32/36 Checking commit 49fd3a8181f6 (qemu-print: New qemu_fprintf(), qemu_vfprintf())
33/36 Checking commit 41465772c004 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints)
ERROR: line over 90 characters
#1051: FILE: target/i386/helper.c:419:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1052: FILE: target/i386/helper.c:420:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1053: FILE: target/i386/helper.c:421:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1054: FILE: target/i386/helper.c:422:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#1055: FILE: target/i386/helper.c:423:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n",

WARNING: line over 80 characters
#1163: FILE: target/i386/helper.c:494:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n",

WARNING: line over 80 characters
#1751: FILE: target/mips/translate.c:29791:
+    qemu_fprintf(f, "CP0 Status  0x%08x Cause   0x%08x EPC    0x" TARGET_FMT_lx "\n",

total: 5 errors, 2 warnings, 2551 lines checked

Patch 33/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

34/36 Checking commit 8362074a2c1b (monitor: Clean up how monitor_disas() funnels output to monitor)
35/36 Checking commit 3613cf29520d (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#297: 
rename from include/disas/bfd.h

total: 0 errors, 1 warnings, 192 lines checked

Patch 35/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/36 Checking commit f65f9a57a620 (include: Move fprintf_function to disas/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 17 lines checked

Patch 36/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190418205135.6686-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PULL for-4.1 00/36] Error reporting & monitor patches for 2019-04-18
Posted by Peter Maydell 4 years, 11 months ago
On Thu, 18 Apr 2019 at 21:53, Markus Armbruster <armbru@redhat.com> wrote:
>
> Early pull request because I'll be on vacation when 4.1 opens.  Hope
> that's okay.
>
> The following changes since commit eeba63fc7fface36f438bcbc0d3b02e7dcb59983:
>
>   Update version for v4.0.0-rc4 release (2019-04-16 21:53:00 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-error-monitor-2019-04-18
>
> for you to fetch changes up to ede9a8a656c992deecce45f8175985dd81cc6be9:
>
>   include: Move fprintf_function to disas/ (2019-04-18 22:18:59 +0200)
>
> ----------------------------------------------------------------
> Error reporting & monitor patches for 2019-04-18
>

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1
for any user-visible changes.

-- PMM