From nobody Mon Feb 9 06:00:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555599996; cv=none; d=zoho.com; s=zohoarc; b=lcy1FQ+kVvh0BB3RsgSmpEXwGlgtnBDJPkHhcfPEH8oTbAo3Pcd5uY7yh+B2zCy4rorMXUr2gjqklDeAXzeSdeNNcQkdeYAuS3XuFaqmZaQN0qJuMu3OToDF2ugHAHBmjg7iBJUWhw62dyyuJhQcgaTaYkqiiWV6aYBMrqCBq4U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555599996; h=Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=81yEl79UN014Ldk49tBKmyia4UR5eluXZD9EF1FvyRo=; b=cpuh7aErpc637xseQ9cn25rvS2O3AzAzBGrX+gLBhuKCIQ9NdEBPPWFIrgSdnDY9syRA/8fko+aRs9IayJgeJbUYR1RuJ80G/bg2lcKP2KqZpfN1izPTtggxkOu13oQqKr2CDuTr1tG0hy/0Z0QUuwD3Ju1NniAF+gjVWABQ998= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555599996643357.7597670389488; Thu, 18 Apr 2019 08:06:36 -0700 (PDT) Received: from localhost ([127.0.0.1]:42686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hH8cQ-0000H0-4l for importer@patchew.org; Thu, 18 Apr 2019 11:06:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hH8V2-0002P9-Jk for qemu-devel@nongnu.org; Thu, 18 Apr 2019 10:58:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hH8QL-0002Be-SA for qemu-devel@nongnu.org; Thu, 18 Apr 2019 10:54:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50504) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hH8QL-0002Aj-LC for qemu-devel@nongnu.org; Thu, 18 Apr 2019 10:54:01 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9365A756 for ; Thu, 18 Apr 2019 14:53:57 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6460460BEC for ; Thu, 18 Apr 2019 14:53:57 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DBA4E1132BB6; Thu, 18 Apr 2019 16:53:55 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 18 Apr 2019 16:53:50 +0200 Message-Id: <20190418145355.21100-2-armbru@redhat.com> In-Reply-To: <20190418145355.21100-1-armbru@redhat.com> References: <20190418145355.21100-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 18 Apr 2019 14:53:57 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" parse_acl_file() passes char values to isspace(). Undefined behavior when the value is negative. Not a security issue, because the characters come from trusted $prefix/etc/qemu/bridge.conf and the files it includes. Fix by using qemu_isspace() instead. Signed-off-by: Markus Armbruster --- qemu-bridge-helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index 5396fbfbb6..0d60c07655 100644 --- a/qemu-bridge-helper.c +++ b/qemu-bridge-helper.c @@ -29,6 +29,7 @@ #include #endif =20 +#include "qemu-common.h" #include "qemu/queue.h" =20 #include "net/tap-linux.h" @@ -75,7 +76,7 @@ static int parse_acl_file(const char *filename, ACLList *= acl_list) char *ptr =3D line; char *cmd, *arg, *argend; =20 - while (isspace(*ptr)) { + while (qemu_isspace(*ptr)) { ptr++; } =20 @@ -99,12 +100,12 @@ static int parse_acl_file(const char *filename, ACLLis= t *acl_list) =20 *arg =3D 0; arg++; - while (isspace(*arg)) { + while (qemu_isspace(*arg)) { arg++; } =20 argend =3D arg + strlen(arg); - while (arg !=3D argend && isspace(*(argend - 1))) { + while (arg !=3D argend && qemu_isspace(*(argend - 1))) { argend--; } *argend =3D 0; --=20 2.17.2