From nobody Mon Feb 9 14:10:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555344465; cv=none; d=zoho.com; s=zohoarc; b=kGJVQwjPEi+kOhapOL9Y7IBxza3zivbEP+Mx+vku7Le29mDI1jedIqywauItxm3u4uSXRB82Ujost0z8c/G3iRkHvuCn5XUfcCHBU7ayQEkcgQAn1enXIJclfauNLENdo15U8o3RInXX+NWxqvzVuf8OxQEunjRRFkxeZIb1Slo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555344465; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=9QdQuMIFV6tEhVy1u3t6FsTVF2Kx7qtBIjAvWtgWwV8=; b=mc1Xu0ELtUtr3zDYuRxoWplO4xqF8Z4wIv9gfrI8fR1+o5/yvzHP2joerYOl9mC2nuLo/1wWOQyluLZ07yAuckoXaCPW2TplTXU2JsfqavK41A6R5eYfm4TrMbXfrRFHXPfXevYTKT2+o4w6hRg1AnLhpRUz5eQ+eRqi9B6/uFY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155534446507956.19399720919955; Mon, 15 Apr 2019 09:07:45 -0700 (PDT) Received: from localhost ([127.0.0.1]:52664 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG48y-0008Cj-Ra for importer@patchew.org; Mon, 15 Apr 2019 12:07:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG47b-0007Xc-Rq for qemu-devel@nongnu.org; Mon, 15 Apr 2019 12:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG47a-0003Ob-Vb for qemu-devel@nongnu.org; Mon, 15 Apr 2019 12:06:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39094) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hG47a-0003Md-Nt for qemu-devel@nongnu.org; Mon, 15 Apr 2019 12:06:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 274ACC0578F2 for ; Mon, 15 Apr 2019 16:06:13 +0000 (UTC) Received: from localhost (unknown [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 878E960123; Mon, 15 Apr 2019 16:06:10 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Mon, 15 Apr 2019 18:06:09 +0200 Message-Id: <20190415160609.24240-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 15 Apr 2019 16:06:13 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2] socket: allow wait=false for client socket X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Commit 767abe7 ("chardev: forbid 'wait' option with client sockets") is a bit too strict. Current libvirt always set wait=3Dfalse, and will thus fail to add client chardev. Make the code more permissive, allowing wait=3Dfalse with client socket chardevs. Fixes: 767abe7f49e8be14d29da5db3527817b5d696a52 Cc: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- chardev/char-socket.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 3916505d67..ebc1adb83e 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1263,9 +1263,13 @@ static bool qmp_chardev_validate_socket(ChardevSocke= t *sock, return false; } if (sock->has_wait) { - error_setg(errp, "%s", - "'wait' option is incompatible with " - "socket in client connect mode"); + warn_report("'wait' option is deprecated with " + "socket in client connect mode"); + if (sock->wait) { + error_setg(errp, "%s", + "'wait' option is incompatible with " + "socket in client connect mode"); + } return false; } } --=20 2.21.0.313.ge35b8cb8e2