From nobody Sat Apr 27 00:32:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1555338409; cv=none; d=zoho.com; s=zohoarc; b=G1geQGQJwHq+XnuwbRish+t0BTvvm5XogBU7oaF1Ku+7EViLWBjsEUfXrFLE5QctAXkYVJNSoXMh8mEfNq+KwajaZ1NGkXjg15lJsxLrMJYDsrYPmZRwsjA1Kkch+fOB5kFm5VOk6MoHAyLhavPuM91qin14xFf5pUmWgcyHzLk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555338409; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=gdMZE4Vky5UoJ81dddmrKZ1+IsI/nD2OSIVXKpoCc0g=; b=MB+aP87+QF9LqVyAC9q9dFC/9bj2YRPWCI58nfsF/5whYzk0IOyeL8EgVjmWPCnw1rTgEPZrLUwqcsHLqhnga6d/7hmLDa3UDu3mZOqGLCSx2f+9fqyazgkYw5BfP+gUTjIXzsHcaqJL6FmHtIhTxiDMW54YDlgqOxBw9kKTlmQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555338409913612.9547114512017; Mon, 15 Apr 2019 07:26:49 -0700 (PDT) Received: from localhost ([127.0.0.1]:51023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2ZI-0000mz-0g for importer@patchew.org; Mon, 15 Apr 2019 10:26:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG2YB-0008UC-Qe for qemu-devel@nongnu.org; Mon, 15 Apr 2019 10:25:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG2YA-0000Vz-Tr for qemu-devel@nongnu.org; Mon, 15 Apr 2019 10:25:35 -0400 Received: from relay.sw.ru ([185.231.240.75]:47676) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hG2Y9-0000LS-BO for qemu-devel@nongnu.org; Mon, 15 Apr 2019 10:25:34 -0400 Received: from [10.28.8.145] (helo=kvm.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1hG2Xw-0001tW-D0; Mon, 15 Apr 2019 17:25:20 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Date: Mon, 15 Apr 2019 17:25:19 +0300 Message-Id: <20190415142519.73060-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH v2] util/error: do not free error on error_abort X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It would be nice to have Error object not freed away when debugging a coredump. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster --- v2: don't change error output format util/error.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/util/error.c b/util/error.c index 934a78e1b1..22f8a7924f 100644 --- a/util/error.c +++ b/util/error.c @@ -34,7 +34,10 @@ static void error_handle_fatal(Error **errp, Error *err) if (errp =3D=3D &error_abort) { fprintf(stderr, "Unexpected error in %s() at %s:%d:\n", err->func, err->src, err->line); - error_report_err(err); + error_report("%s", error_get_pretty(err)); + if (err->hint) { + error_printf_unless_qmp("%s", err->hint->str); + } abort(); } if (errp =3D=3D &error_fatal) { --=20 2.18.0