From nobody Wed May 8 03:11:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1555171746; cv=none; d=zoho.com; s=zohoarc; b=APp3hGEy7/ZUacXXXd3GfGQcj+KWhV6GvTWXpjwZX+kz0q2oUwn9J6lqj2/aerutG2MOiU5Vzr14+IW3VzsfHPmD1qJ30/6771YFc6J97eLvikTGIrouK+g44qGpIB+0OZw7tROF3FeCElPTJbdnFWGwWiyAdRKkeQTI/oCUItE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555171746; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=ZBa7qOqWTRmA/o9Pi5tmaLqXs6HgtVc+aepJkPscR6c=; b=jby/yYrkbM06+kocgOuiBztk7giB/iP8tZmJCoKmdjyOj1IKs+Ryipo0grMy87pc/ADtAtZEfLZKVDFBUtx0LGjGeJgCn2RBhYd0Js4cpEgeHP3nFbatGv3ZJM72f8+ph3lot9XUh+X3X96JQ6CRYcBtW5xMDC1ZOxtJJDHI80w= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15551717457991.0072516871094876; Sat, 13 Apr 2019 09:09:05 -0700 (PDT) Received: from localhost ([127.0.0.1]:53360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFLD8-0008K0-Iz for importer@patchew.org; Sat, 13 Apr 2019 12:08:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFLBs-0007ch-Ag for qemu-devel@nongnu.org; Sat, 13 Apr 2019 12:07:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFLBr-0002Ss-IK for qemu-devel@nongnu.org; Sat, 13 Apr 2019 12:07:40 -0400 Received: from relay.sw.ru ([185.231.240.75]:34450) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hFLBr-0002Qp-A1 for qemu-devel@nongnu.org; Sat, 13 Apr 2019 12:07:39 -0400 Received: from [10.28.8.145] (helo=kvm.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1hFLBm-0004w2-64; Sat, 13 Apr 2019 19:07:34 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Date: Sat, 13 Apr 2019 19:07:32 +0300 Message-Id: <20190413160732.55505-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH] util/error: do not free error on error_abort X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It would be nice to have Error object not freed away when debugging a coredump. Signed-off-by: Vladimir Sementsov-Ogievskiy --- util/error.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/util/error.c b/util/error.c index 934a78e1b1..f9180c0f30 100644 --- a/util/error.c +++ b/util/error.c @@ -32,9 +32,11 @@ Error *error_fatal; static void error_handle_fatal(Error **errp, Error *err) { if (errp =3D=3D &error_abort) { - fprintf(stderr, "Unexpected error in %s() at %s:%d:\n", - err->func, err->src, err->line); - error_report_err(err); + error_report("Unexpected error in %s() at %s:%d: %s", + err->func, err->src, err->line, error_get_pretty(err)= ); + if (err->hint) { + error_printf_unless_qmp("%s", err->hint->str); + } abort(); } if (errp =3D=3D &error_fatal) { --=20 2.18.0