From nobody Sat Feb 7 09:58:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555071716; cv=none; d=zoho.com; s=zohoarc; b=Diklu4vzJY9uPivWW1I1AZQdROHOpQtEgufP60ywZQUStLPngLKTP1KMcUMHGv941+QIuiQAIb5RssYJnxVeA4K4CDHQk0cXuXl82SgndrY6a3V+3H/WZ5AHGs5Up4yuc59ZKTuQtWMZiT2qGbFW8rlVLEyM09kmJxeO32agHPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555071716; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=D23Jx4Rc2B2w1jxyD/9mz6+H5P4JDeKt83vWoa0/Afc=; b=UeCzNIKRIPDXZuPCD/xc1sZcj8bJn4OIxAjulDiaEyME9olb6N5LRp7LTHjIU1vwDYw8bmf1Jt3vvf+ok3uO6GBOf6DA4fXutwe+SBCNb3dXxb4m170BeSA8odMtyf1gaYYpqR1pC5e1NZInsTUn4LT4s0vR8Z7FnYUuWNgKCeE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555071716851390.41190555369496; Fri, 12 Apr 2019 05:21:56 -0700 (PDT) Received: from localhost ([127.0.0.1]:35537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEvBp-0006Md-PG for importer@patchew.org; Fri, 12 Apr 2019 08:21:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEv6j-0002h9-0m for qemu-devel@nongnu.org; Fri, 12 Apr 2019 08:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEv6i-0004Va-63 for qemu-devel@nongnu.org; Fri, 12 Apr 2019 08:16:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62442) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEv6h-0004VM-W2 for qemu-devel@nongnu.org; Fri, 12 Apr 2019 08:16:36 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55548C05D3F5; Fri, 12 Apr 2019 12:16:35 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-27.ams2.redhat.com [10.36.112.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 813FF5D9CC; Fri, 12 Apr 2019 12:16:33 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Date: Fri, 12 Apr 2019 13:16:22 +0100 Message-Id: <20190412121626.19829-2-berrange@redhat.com> In-Reply-To: <20190412121626.19829-1-berrange@redhat.com> References: <20190412121626.19829-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 12 Apr 2019 12:16:35 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/5] linux-user: avoid string truncation warnings in uname field copying X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" In file included from /usr/include/string.h:494, from include/qemu/osdep.h:101, from linux-user/uname.c:20: In function =E2=80=98strncpy=E2=80=99, inlined from =E2=80=98sys_uname=E2=80=99 at linux-user/uname.c:94:3: /usr/include/bits/string_fortified.h:106:10: warning: =E2=80=98__builtin_st= rncpy=E2=80=99 output may be truncated copying 64 bytes from a string of le= ngth 64 [-Wstringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__de= st)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~ We don't care where the NUL terminator in the original uname field was. It suffices to copy the entire original field and simply force a NUL terminator at the end of the new field. Signed-off-by: Daniel P. Berrang=C3=A9 --- linux-user/uname.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/uname.c b/linux-user/uname.c index 313b79dbad..3dff33effe 100644 --- a/linux-user/uname.c +++ b/linux-user/uname.c @@ -73,7 +73,7 @@ const char *cpu_to_uname_machine(void *cpu_env) #define COPY_UTSNAME_FIELD(dest, src) \ do { \ /* __NEW_UTS_LEN doesn't include terminating null */ \ - (void) strncpy((dest), (src), __NEW_UTS_LEN); \ + memcpy((dest), (src), MIN(sizeof(src), __NEW_UTS_LEN)); \ (dest)[__NEW_UTS_LEN] =3D '\0'; \ } while (0) =20 --=20 2.20.1