From nobody Sat Feb 7 08:53:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555065022; cv=none; d=zoho.com; s=zohoarc; b=RkKmmPIfKjsrEo08nwLqCvuil5vZcUixekQ+Y+TCIhRVwmnIdFoibONAAF2jh/Zvbj8Lw7OZYRFZw99XrwTJ3i/s5UKhOjv+Z5dTru1v6Hxuyo7SFlq0RpdKf9x3gZG+0wDHBTQys3ymncSSUDnFbTN47fwnU4XvHzt4P1LeYvU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555065022; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=YRhfjVjXalHQaaYi8dDtAHbIRjpqNxfQpbuKMLjKMM8=; b=G7J3/JyJnC7a1uPoUbvBa1kSP2pQSkphk8Umfxt4HLzj9ImVP6vpGH42PcR9tbzVW6kbB2ma9LPD2EM0Rl50MSpEI1RmhgjzTkrmJBH9vYxnTjGRZOCF08SPJv/hEyzkysNMu1RNHqfe3z4tQxjdoGpHOAdmTwJFtPohQlp7jLQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555065022248513.7392941561794; Fri, 12 Apr 2019 03:30:22 -0700 (PDT) Received: from localhost ([127.0.0.1]:33937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEtRn-0007QS-7x for importer@patchew.org; Fri, 12 Apr 2019 06:30:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEt5T-0003df-TV for qemu-devel@nongnu.org; Fri, 12 Apr 2019 06:07:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEt5S-0005n7-Rw for qemu-devel@nongnu.org; Fri, 12 Apr 2019 06:07:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33888) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEt5Q-0005l8-DN; Fri, 12 Apr 2019 06:07:08 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A11BD3145426; Fri, 12 Apr 2019 10:07:07 +0000 (UTC) Received: from laptop.redhat.com (ovpn-117-161.ams2.redhat.com [10.36.117.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52D3B19728; Fri, 12 Apr 2019 10:07:01 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Date: Fri, 12 Apr 2019 12:03:54 +0200 Message-Id: <20190412100354.6409-28-eric.auger@redhat.com> In-Reply-To: <20190412100354.6409-1-eric.auger@redhat.com> References: <20190412100354.6409-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 12 Apr 2019 10:07:07 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC v3 27/27] vfio-pci: Implement the DMA fault handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yi.l.liu@intel.com, mst@redhat.com, jean-philippe.brucker@arm.com, peterx@redhat.com, alex.williamson@redhat.com, vincent.stehle@arm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Whenever the eventfd is triggered, we retrieve the DMA faults from the mmapped fault region and inject them in the iommu memory region. Signed-off-by: Eric Auger --- hw/vfio/pci.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++ hw/vfio/pci.h | 1 + 2 files changed, 54 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 89399a290f..fcbb92cf27 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2820,10 +2820,63 @@ static void vfio_unregister_req_notifier(VFIOPCIDev= ice *vdev) static void vfio_dma_fault_notifier_handler(void *opaque) { VFIOPCIDevice *vdev =3D opaque; + PCIDevice *pdev =3D &vdev->pdev; + AddressSpace *as =3D pci_device_iommu_address_space(pdev); + IOMMUMemoryRegion *iommu_mr =3D IOMMU_MEMORY_REGION(as->root); + struct vfio_region_fault_prod header; + struct iommu_fault *queue; + char *queue_buffer =3D NULL; + ssize_t bytes; =20 if (!event_notifier_test_and_clear(&vdev->dma_fault_notifier)) { return; } + + if (!vdev->fault_prod_region.size || !vdev->fault_cons_region.size) { + return; + } + + bytes =3D pread(vdev->vbasedev.fd, &header, sizeof(header), + vdev->fault_prod_region.fd_offset); + if (bytes !=3D sizeof(header)) { + error_report("%s unable to read the fault region header (0x%lx)", + __func__, bytes); + return; + } + + /* Normally the fault queue is mmapped */ + queue =3D (struct iommu_fault *)vdev->fault_prod_region.mmaps[0].mmap; + if (!queue) { + size_t queue_size =3D header.nb_entries * header.entry_size; + + error_report("%s: fault queue not mmapped: slower fault handling", + vdev->vbasedev.name); + + queue_buffer =3D g_malloc(queue_size); + bytes =3D pread(vdev->vbasedev.fd, queue_buffer, queue_size, + vdev->fault_prod_region.fd_offset + header.offset); + if (bytes !=3D queue_size) { + error_report("%s unable to read the fault queue (0x%lx)", + __func__, bytes); + return; + } + + queue =3D (struct iommu_fault *)queue_buffer; + } + + while (vdev->fault_cons_index !=3D header.prod) { + memory_region_inject_faults(iommu_mr, 1, + &queue[vdev->fault_cons_index]); + vdev->fault_cons_index =3D + (vdev->fault_cons_index + 1) % header.nb_entries; + } + bytes =3D pwrite(vdev->vbasedev.fd, &vdev->fault_cons_index, 4, + vdev->fault_cons_region.fd_offset + 4); + if (bytes !=3D 4) { + error_report("%s unable to write the fault region cons index (0x%l= x)", + __func__, bytes); + } + g_free(queue_buffer); } =20 static void vfio_register_dma_fault_notifier(VFIOPCIDevice *vdev) diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h index 24ec43ac81..aef69c4487 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -138,6 +138,7 @@ typedef struct VFIOPCIDevice { EventNotifier dma_fault_notifier; VFIORegion fault_prod_region; VFIORegion fault_cons_region; + uint32_t fault_cons_index; int (*resetfn)(struct VFIOPCIDevice *); uint32_t vendor_id; uint32_t device_id; --=20 2.20.1