From nobody Mon Feb 9 16:51:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554994680; cv=none; d=zoho.com; s=zohoarc; b=hmNN8SfCe72MO7StJg9kpJYkoQSWcbQDnK6YF28qoSZxRP+itCLSNQQjjzJSlMR3VtMixRfASe6/4jhGTshrJAWnJfklxfedve4Hz0arR8TdULZx4iB94OrByBbc5a6K8YjYz6W1Q1d9U4EHN9/uJy5pYk9WraCtpWi7vG00Jlc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554994680; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=hfN6utArzJ0Q+aTTpEj6bfs1Pgpc7oeBTQsthPA15pc=; b=bwElyO5sNwC9DjG24PkAdEoE7V3FYUHACy5WozoYKXcND4ig/ZjX4xgLhynkE740lmke+w/EPrc6rZ22o8H/tPCK0oKWbD6fC1u14O0ug/93i9XYzlcLWr9v18oZjs/Xbc4QOKzJwW3hMgtatDPN5gFDCEWpRgIliv4BWAShWTU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15549946808801015.4596006246941; Thu, 11 Apr 2019 07:58:00 -0700 (PDT) Received: from localhost ([127.0.0.1]:50229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEb9J-0007IK-Rd for importer@patchew.org; Thu, 11 Apr 2019 10:57:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEb4d-0003Mx-1C for qemu-devel@nongnu.org; Thu, 11 Apr 2019 10:53:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEb4b-0000o4-34 for qemu-devel@nongnu.org; Thu, 11 Apr 2019 10:53:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4041) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEb4X-0000lj-Um for qemu-devel@nongnu.org; Thu, 11 Apr 2019 10:53:03 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C23F69AE78 for ; Thu, 11 Apr 2019 14:53:00 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9DB8E19747; Thu, 11 Apr 2019 14:52:59 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D882A11329CD; Thu, 11 Apr 2019 16:52:56 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 11 Apr 2019 16:52:49 +0200 Message-Id: <20190411145256.8614-9-armbru@redhat.com> In-Reply-To: <20190411145256.8614-1-armbru@redhat.com> References: <20190411145256.8614-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 11 Apr 2019 14:53:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 08/15] vfio: Report warnings with warn_report(), not error_printf() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Williamson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Cc: Alex Williamson Signed-off-by: Markus Armbruster --- hw/vfio/pci.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 504019c458..0142819ea6 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -947,8 +947,10 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev) if (vdev->pdev.romfile || !vdev->pdev.rom_bar) { /* Since pci handles romfile, just print a message and return */ if (vfio_blacklist_opt_rom(vdev) && vdev->pdev.romfile) { - error_printf("Warning : Device at %s is known to cause system = instability issues during option rom execution. Proceeding anyway since use= r specified romfile\n", - vdev->vbasedev.name); + warn_report("Device at %s is known to cause system instability" + " issues during option rom execution", + vdev->vbasedev.name); + error_printf("Proceeding anyway since user specified romfile\n= "); } return; } @@ -973,11 +975,16 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev) =20 if (vfio_blacklist_opt_rom(vdev)) { if (dev->opts && qemu_opt_get(dev->opts, "rombar")) { - error_printf("Warning : Device at %s is known to cause system = instability issues during option rom execution. Proceeding anyway since use= r specified non zero value for rombar\n", - vdev->vbasedev.name); + warn_report("Device at %s is known to cause system instability" + " issues during option rom execution", + vdev->vbasedev.name); + error_printf("Proceeding anyway since user specified" + " non zero value for rombar\n"); } else { - error_printf("Warning : Rom loading for device at %s has been = disabled due to system instability issues. Specify rombar=3D1 or romfile to= force\n", - vdev->vbasedev.name); + warn_report("Rom loading for device at %s has been disabled" + " due to system instability issues", + vdev->vbasedev.name); + error_printf("Specify rombar=3D1 or romfile to force\n"); return; } } --=20 2.17.2