From nobody Sat May 18 20:15:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554858771; cv=none; d=zoho.com; s=zohoarc; b=Dx4/d0qU2kiIuOW3rVQqZATdZteozQiFxw0chOWKVgdibURoTYr4MfFO1KeCOmkgTBthcr/L+ov/8fGAiddOOeDIJhWqPqeGs0DZAIjGdvMlanhA/ThxKAbp6idZ8wS50iRL4w06TqzEyRfoc59LzHpbxnieKkVpXmmjszWy8jg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554858771; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=5ZOncL0y7kOqwc1qK1QMEmChyc2NKGk6gazWAqMU0M4=; b=ocHAhxA4QJxooshveZeiOnjBkFjlWCjOEAUkFirx+E0TedAwariy0XQaIuCnViiTOr5fP73+c1froUEbAPXzxjjwvALOi8IBskdnrSpyoSr9Pv1EXVr2a42BGBvhLcOVH8hRgqZUIEuN6DH2kyaykMKjkNQhbII/CakkWMldwUQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1554858771055933.6410168038328; Tue, 9 Apr 2019 18:12:51 -0700 (PDT) Received: from localhost ([127.0.0.1]:51531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE1nB-0005Pq-2a for importer@patchew.org; Tue, 09 Apr 2019 21:12:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE0v7-0003h2-07 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 20:16:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE0v5-0001m4-U6 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 20:16:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45460) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE0v5-0001kf-Lw for qemu-devel@nongnu.org; Tue, 09 Apr 2019 20:16:51 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0763D3DFCD for ; Wed, 10 Apr 2019 00:08:09 +0000 (UTC) Received: from rhel74-ghook-amd.khw1.lab.eng.bos.redhat.com (rhel74-ghook-amd.khw1.lab.eng.bos.redhat.com [10.16.200.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AF326146F; Wed, 10 Apr 2019 00:08:08 +0000 (UTC) From: Gary R Hook To: rhvirt-patches@redhat.com Date: Tue, 9 Apr 2019 20:08:02 -0400 Message-Id: <20190410000803.1744-2-ghook@redhat.com> In-Reply-To: <20190410000803.1744-1-ghook@redhat.com> References: <20190410000803.1744-1-ghook@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 10 Apr 2019 00:08:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Mailman-Approved-At: Tue, 09 Apr 2019 21:10:01 -0400 Subject: [Qemu-devel] [RHEL-8.1 virt 1/2] memory: Fix the memory region type assignment order X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , ghook@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" BZ: 1667249 Branch: rhel-8.1.0 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=3D1667249 Upstream Status: 4.0.0-rc1 Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=3D2= 0980582 Conflicts: None commit 2ddb89b00f947f785c9ca6742f28f954e3b75e62 Author: Singh, Brijesh Date: Mon Feb 4 22:23:39 2019 +0000 memory: Fix the memory region type assignment order Currently, a callback registered through the RAMBlock notifier is not able to get the memory region type (i.e callback is not able to use memory_region_is_ram_device function). This is because mr->ram assignment happens _after_ the memory is allocated whereas the callback is executed during allocation. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1667249 Suggested-by: Alex Williamson Cc: Paolo Bonzini Reviewed-by: Alex Williamson Signed-off-by: Brijesh Singh Message-Id: <20190204222322.26766-2-brijesh.singh@amd.com> Signed-off-by: Paolo Bonzini Cc: Paolo Bonzini =20 Cc: qemu-devel@nongnu.org=20 Acked-by: Eduardo Habkost Acked-by: Paolo Bonzini --- memory.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 4974f972d5..04ff5e9108 100644 --- a/memory.c +++ b/memory.c @@ -1631,10 +1631,17 @@ void memory_region_init_ram_device_ptr(MemoryRegion= *mr, uint64_t size, void *ptr) { - memory_region_init_ram_ptr(mr, owner, name, size, ptr); + memory_region_init(mr, owner, name, size); + mr->ram =3D true; + mr->terminates =3D true; mr->ram_device =3D true; mr->ops =3D &ram_device_mem_ops; mr->opaque =3D mr; + mr->destructor =3D memory_region_destructor_ram; + mr->dirty_log_mask =3D tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0; + /* qemu_ram_alloc_from_ptr cannot fail with ptr !=3D NULL. */ + assert(ptr !=3D NULL); + mr->ram_block =3D qemu_ram_alloc_from_ptr(size, ptr, mr, &error_fatal); } =20 void memory_region_init_alias(MemoryRegion *mr, --=20 2.18.1 From nobody Sat May 18 20:15:17 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554858703; cv=none; d=zoho.com; s=zohoarc; b=OqJzqx8MSOBpXLtuRHnqc1mo9qxdlgDoxlYt6NTe43Jm3jvuF0xvmCR+SVF1HzDqtA6Fe+/1jV4a2udHvj2sPR4De38rWQs6dKiRjJUSib1zsDLXNUr2lk23HtGJWSqO8zFIHCVFiOMPJ1Nzpgna9IxRT6qvp99rAfMUiTbZBGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554858703; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=x1XtU1htnxMF+f93okVADc6Zo5QvXDL01A6iHQXvzto=; b=PNDNyxxtWfw0NwPRzNiBQ6J0tJysWcgq2YwT3OPEjbsjguPFXizX5YI9MXABoM3Ec26w1LHZN7VzFktJ2Ib4KScAh3Vavh0D0hVNKo6wXegtUad4mqzrWdnhRZ7qeIdo5TKT4DNReW8Xk4EmG40DYLGH+KcORJm9xYl0cV2IdJY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1554858703846583.6768992731871; Tue, 9 Apr 2019 18:11:43 -0700 (PDT) Received: from localhost ([127.0.0.1]:51519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE1lm-0004US-Nx for importer@patchew.org; Tue, 09 Apr 2019 21:11:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE0sZ-0003PI-2J for qemu-devel@nongnu.org; Tue, 09 Apr 2019 20:14:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE0sX-0003c1-W1 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 20:14:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39760) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE0sW-0003Rn-Ei for qemu-devel@nongnu.org; Tue, 09 Apr 2019 20:14:13 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D02F83003B44; Wed, 10 Apr 2019 00:08:09 +0000 (UTC) Received: from rhel74-ghook-amd.khw1.lab.eng.bos.redhat.com (rhel74-ghook-amd.khw1.lab.eng.bos.redhat.com [10.16.200.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A3C41716C; Wed, 10 Apr 2019 00:08:09 +0000 (UTC) From: Gary R Hook To: rhvirt-patches@redhat.com Date: Tue, 9 Apr 2019 20:08:03 -0400 Message-Id: <20190410000803.1744-3-ghook@redhat.com> In-Reply-To: <20190410000803.1744-1-ghook@redhat.com> References: <20190410000803.1744-1-ghook@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 10 Apr 2019 00:08:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Mailman-Approved-At: Tue, 09 Apr 2019 21:10:01 -0400 Subject: [Qemu-devel] [RHEL-8.1 virt 2/2] target/i386: sev: Do not pin the ram device memory region X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Paolo Bonzini , ghook@redhat.com, Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" BZ: 1667249 Branch: rhel-8.1.0 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=3D1667249 Upstream Status: 4.0.0-rc1 Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=3D2= 0980582 Conflicts: None commit cedc0ad539afbbb669dba9e73dfad2915bc1c25b Author: Singh, Brijesh Date: Mon Feb 4 22:23:40 2019 +0000 target/i386: sev: Do not pin the ram device memory region The RAM device presents a memory region that should be handled as an IO region and should not be pinned. In the case of the vfio-pci, RAM device represents a MMIO BAR and the memory region is not backed by pages hence KVM_MEMORY_ENCRYPT_REG_REGION fails to lock the memory range. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1667249 Cc: Alex Williamson Cc: Paolo Bonzini Signed-off-by: Brijesh Singh Message-Id: <20190204222322.26766-3-brijesh.singh@amd.com> Signed-off-by: Paolo Bonzini Cc: Paolo Bonzini =20 Cc: Richard Henderson =20 Cc: Eduardo Habkost =20 Cc: qemu-devel@nongnu.org=20 Acked-by: Eduardo Habkost Acked-by: Paolo Bonzini --- target/i386/sev.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index 2395171acf..b8009b001a 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -130,6 +130,17 @@ sev_ram_block_added(RAMBlockNotifier *n, void *host, s= ize_t size) { int r; struct kvm_enc_region range; + ram_addr_t offset; + MemoryRegion *mr; + + /* + * The RAM device presents a memory region that should be treated + * as IO region and should not be pinned. + */ + mr =3D memory_region_from_host(host, &offset); + if (mr && memory_region_is_ram_device(mr)) { + return; + } =20 range.addr =3D (__u64)(unsigned long)host; range.size =3D size; --=20 2.18.1