[Qemu-devel] [PATCH] docs: replace min-glib with fedora

Marc-André Lureau posted 1 patch 4 years, 11 months ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190409154435.28807-1-marcandre.lureau@redhat.com
docs/devel/testing.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[Qemu-devel] [PATCH] docs: replace min-glib with fedora
Posted by Marc-André Lureau 4 years, 11 months ago
min-glib.docker was removed in commit
e7b3af81597db1a6b55f2c15d030d703c6b2c6ac ("glib: bump min required
glib library version to 2.40").

Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 docs/devel/testing.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 60f897d915..cec7d56c57 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -317,17 +317,17 @@ the container, with parameters defined by the make target):
 
 .. code::
 
-  make docker-test-build@min-glib
+  make docker-test-build@fedora
 
-This will create a container instance using the ``min-glib`` image (the image
+This will create a container instance using the ``fedora`` image (the image
 is downloaded and initialized automatically), in which the ``test-build`` job
 is executed.
 
 Images
 ------
 
-Along with many other images, the ``min-glib`` image is defined in a Dockerfile
-in ``tests/docker/dockefiles/``, called ``min-glib.docker``. ``make docker``
+Along with many other images, the ``fedora`` image is defined in a Dockerfile
+in ``tests/docker/dockefiles/``, called ``fedora.docker``. ``make docker``
 command will list all the available images.
 
 To add a new image, simply create a new ``.docker`` file under the
-- 
2.21.0.196.g041f5ea1cf


Re: [Qemu-devel] [PATCH] docs: replace min-glib with fedora
Posted by Philippe Mathieu-Daudé 4 years, 11 months ago
On 4/9/19 5:44 PM, Marc-André Lureau wrote:
> min-glib.docker was removed in commit
> e7b3af81597db1a6b55f2c15d030d703c6b2c6ac ("glib: bump min required
> glib library version to 2.40").
> 
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  docs/devel/testing.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> index 60f897d915..cec7d56c57 100644
> --- a/docs/devel/testing.rst
> +++ b/docs/devel/testing.rst
> @@ -317,17 +317,17 @@ the container, with parameters defined by the make target):
>  
>  .. code::
>  
> -  make docker-test-build@min-glib
> +  make docker-test-build@fedora
>  
> -This will create a container instance using the ``min-glib`` image (the image
> +This will create a container instance using the ``fedora`` image (the image
>  is downloaded and initialized automatically), in which the ``test-build`` job
>  is executed.
>  
>  Images
>  ------
>  
> -Along with many other images, the ``min-glib`` image is defined in a Dockerfile
> -in ``tests/docker/dockefiles/``, called ``min-glib.docker``. ``make docker``
> +Along with many other images, the ``fedora`` image is defined in a Dockerfile
> +in ``tests/docker/dockefiles/``, called ``fedora.docker``. ``make docker``
>  command will list all the available images.
>  
>  To add a new image, simply create a new ``.docker`` file under the
> 

Re: [Qemu-devel] [PATCH] docs: replace min-glib with fedora
Posted by Stefano Garzarella 4 years, 11 months ago
On Tue, Apr 09, 2019 at 05:44:35PM +0200, Marc-André Lureau wrote:
> min-glib.docker was removed in commit
> e7b3af81597db1a6b55f2c15d030d703c6b2c6ac ("glib: bump min required
> glib library version to 2.40").
> 
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  docs/devel/testing.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano

Re: [Qemu-devel] [PATCH] docs: replace min-glib with fedora
Posted by Daniel P. Berrangé 4 years, 11 months ago
On Tue, Apr 09, 2019 at 05:44:35PM +0200, Marc-André Lureau wrote:
> min-glib.docker was removed in commit
> e7b3af81597db1a6b55f2c15d030d703c6b2c6ac ("glib: bump min required
> glib library version to 2.40").
> 
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  docs/devel/testing.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|