From nobody Sat May 4 09:12:55 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1554789594058161.4490256727023; Mon, 8 Apr 2019 22:59:54 -0700 (PDT) Received: from localhost ([127.0.0.1]:35747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjnJ-0003Md-0a for importer@patchew.org; Tue, 09 Apr 2019 01:59:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjlo-0002Yr-S9 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 01:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDjlm-0003tG-S3 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 01:58:08 -0400 Received: from mail.weilnetz.de ([37.120.169.71]:43272 helo=v2201612906741603.powersrv.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjlk-0003sR-45; Tue, 09 Apr 2019 01:58:04 -0400 Received: from localhost (localhost [127.0.0.1]) by v2201612906741603.powersrv.de (Postfix) with ESMTP id 8D2F1DB6049; Tue, 9 Apr 2019 07:49:05 +0200 (CEST) Received: from v2201612906741603.powersrv.de ([127.0.0.1]) by localhost (v2201612906741603.powersrv.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9HxXChr5P8uJ; Tue, 9 Apr 2019 07:49:04 +0200 (CEST) Received: from qemu.weilnetz.de (qemu.weilnetz.de [188.68.58.204]) by v2201612906741603.powersrv.de (Postfix) with ESMTP id B169DDB6046; Tue, 9 Apr 2019 07:49:04 +0200 (CEST) Received: by qemu.weilnetz.de (Postfix, from userid 1000) id A90C946000F; Tue, 9 Apr 2019 07:49:04 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at v2201612906741603.powersrv.de From: Stefan Weil To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Peter Maydell Date: Tue, 9 Apr 2019 07:48:52 +0200 Message-Id: <20190409054852.22547-1-sw@weilnetz.de> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 37.120.169.71 Subject: [Qemu-devel] [PATCH v2] Fix type of cluster_index X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The type should be the same as the type of cluster_id. This fixed a runtime error reported by sanitizers: /qemu/include/exec/tb-lookup.h:33:35: runtime error: left shift of nega= tive value -1 /qemu/accel/tcg/translate-all.c:1692:34: runtime error: left shift of n= egative value -1 Signed-off-by: Stefan Weil --- v2: Fixed my e-mail address. include/qom/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 1d6099e5d4..6a753caed7 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -422,7 +422,7 @@ struct CPUState { =20 /* TODO Move common fields from CPUArchState here. */ int cpu_index; - int cluster_index; + uint32_t cluster_index; uint32_t halted; uint32_t can_do_io; int32_t exception_index; @@ -1129,6 +1129,6 @@ extern const struct VMStateDescription vmstate_cpu_co= mmon; #endif /* NEED_CPU_H */ =20 #define UNASSIGNED_CPU_INDEX -1 -#define UNASSIGNED_CLUSTER_INDEX -1 +#define UNASSIGNED_CLUSTER_INDEX UINT32_MAX =20 #endif --=20 2.11.0