From nobody Sun May 19 01:15:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1554789274122752.1999846216369; Mon, 8 Apr 2019 22:54:34 -0700 (PDT) Received: from localhost ([127.0.0.1]:35694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjiG-0001Wk-6o for importer@patchew.org; Tue, 09 Apr 2019 01:54:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjgu-0000o0-Hl for qemu-devel@nongnu.org; Tue, 09 Apr 2019 01:53:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDjgt-0007ng-8m for qemu-devel@nongnu.org; Tue, 09 Apr 2019 01:53:04 -0400 Received: from mail.weilnetz.de ([37.120.169.71]:43046 helo=v2201612906741603.powersrv.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjgs-0007nK-TT; Tue, 09 Apr 2019 01:53:03 -0400 Received: from localhost (localhost [127.0.0.1]) by v2201612906741603.powersrv.de (Postfix) with ESMTP id EC62EDA062F; Tue, 9 Apr 2019 07:43:31 +0200 (CEST) Received: from v2201612906741603.powersrv.de ([127.0.0.1]) by localhost (v2201612906741603.powersrv.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Osi-OF68DGjv; Tue, 9 Apr 2019 07:43:31 +0200 (CEST) Received: from qemu.weilnetz.de (qemu.weilnetz.de [188.68.58.204]) by v2201612906741603.powersrv.de (Postfix) with ESMTP id 17CD3DA0606; Tue, 9 Apr 2019 07:43:31 +0200 (CEST) Received: by qemu.weilnetz.de (Postfix, from userid 1000) id DBE5F46000F; Tue, 9 Apr 2019 07:43:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at v2201612906741603.powersrv.de From: Stefan Weil To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Peter Maydell Date: Tue, 9 Apr 2019 07:43:25 +0200 Message-Id: <20190409054325.22427-1-sw@weilnetz.de> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 37.120.169.71 Subject: [Qemu-devel] [PATCH] Fix type of cluster_index X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Stefan Weil The type should be the same as the type of cluster_id. This fixed a runtime error reported by sanitizers: /qemu/include/exec/tb-lookup.h:33:35: runtime error: left shift of nega= tive value -1 /qemu/accel/tcg/translate-all.c:1692:34: runtime error: left shift of n= egative value -1 Signed-off-by: Stefan Weil --- include/qom/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 1d6099e5d4..6a753caed7 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -422,7 +422,7 @@ struct CPUState { =20 /* TODO Move common fields from CPUArchState here. */ int cpu_index; - int cluster_index; + uint32_t cluster_index; uint32_t halted; uint32_t can_do_io; int32_t exception_index; @@ -1129,6 +1129,6 @@ extern const struct VMStateDescription vmstate_cpu_co= mmon; #endif /* NEED_CPU_H */ =20 #define UNASSIGNED_CPU_INDEX -1 -#define UNASSIGNED_CLUSTER_INDEX -1 +#define UNASSIGNED_CLUSTER_INDEX UINT32_MAX =20 #endif --=20 2.11.0