From nobody Fri May 3 20:49:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1554726622333673.1216019176696; Mon, 8 Apr 2019 05:30:22 -0700 (PDT) Received: from localhost ([127.0.0.1]:52365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDTPm-0007ck-O3 for importer@patchew.org; Mon, 08 Apr 2019 08:30:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDTOx-0007JY-06 for qemu-devel@nongnu.org; Mon, 08 Apr 2019 08:29:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDTOv-000135-Po for qemu-devel@nongnu.org; Mon, 08 Apr 2019 08:29:26 -0400 Received: from smtpbgau1.qq.com ([54.206.16.166]:58206) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDTOv-0000yg-3M for qemu-devel@nongnu.org; Mon, 08 Apr 2019 08:29:25 -0400 Received: from localhost.localdomain (unknown [117.32.216.84]) by esmtp4.qq.com (ESMTP) with id ; Mon, 08 Apr 2019 20:28:57 +0800 (CST) X-QQ-mid: bizesmtp15t1554726538t3hvpuy8 X-QQ-SSF: 01100000002000508440000A0000000 X-QQ-FEAT: nSUdqPGu3tuo5s9ubsWqzMGBc2awxL6l21fTCpOGVnDxRVk+Me1n84r8PSmpG oq1sipd4teo7EtDiTBLhfClTPIAuThwlUxzlKSA74ySd16CmRK1n+swMzFd8unf/oJdF1Cr gwXDCb7r5xMkOYj8qkMTmzG4PSsBmvWrz9XFvjqH3BOSOKGY6zqvSmRSuI9VncPuCSY9WVT 6cg7H1LOy3yfjUnemSDVaqGSuhy14/tpAfsbGR7x3oxBgdsfQWJ3xzDxFf/vv+djsAXiAT8 iw9I3PVzhEhm6ZHg9P1beFtQ8= X-QQ-GoodBg: 0 From: ghorges To: qemu-devel@nongnu.org Date: Mon, 8 Apr 2019 20:28:16 +0800 Message-Id: <20190408122816.595-1-ghorges@xiyoulinux.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Signed-off-by: ghorges X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:xiyoulinux.org:qybgforeign:qybgforeign2 X-QQ-Bgrelay: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 54.206.16.166 Subject: [Qemu-devel] Wshadow in qemu/linux-user/syscall.c:Changed some variable names X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: riku.voipio@iki.fi, laurent@vivier.eu, ghorges Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" --- linux-user/syscall.c | 66 ++++++++++++++++++++++---------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 208fd1813d..985095e4d5 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8240,7 +8240,7 @@ static abi_long do_syscall1(void *cpu_env, int num, a= bi_long arg1, size_t size; } sig, *sig_ptr; =20 - abi_ulong arg_sigset, arg_sigsize, *arg7; + abi_ulong arg_sigset, arg_sigsize, *arg7s; target_sigset_t *target_sigset; =20 n =3D arg1; @@ -8280,13 +8280,13 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, sig_ptr =3D &sig; sig.size =3D SIGSET_T_SIZE; =20 - arg7 =3D lock_user(VERIFY_READ, arg6, sizeof(*arg7) * 2, 1= ); - if (!arg7) { + arg7s =3D lock_user(VERIFY_READ, arg6, sizeof(*arg7s) * 2,= 1); + if (!arg7s) { return -TARGET_EFAULT; } - arg_sigset =3D tswapal(arg7[0]); - arg_sigsize =3D tswapal(arg7[1]); - unlock_user(arg7, arg6, 0); + arg_sigset =3D tswapal(arg7s[0]); + arg_sigsize =3D tswapal(arg7s[1]); + unlock_user(arg7s, arg6, 0); =20 if (arg_sigset) { sig.set =3D &set; @@ -9479,14 +9479,14 @@ static abi_long do_syscall1(void *cpu_env, int num,= abi_long arg1, } case TARGET_NR_getcpu: { - unsigned cpu, node; - ret =3D get_errno(sys_getcpu(arg1 ? &cpu : NULL, + unsigned cpus, node; + ret =3D get_errno(sys_getcpu(arg1 ? &cpus : NULL, arg2 ? &node : NULL, NULL)); if (is_error(ret)) { return ret; } - if (arg1 && put_user_u32(cpu, arg1)) { + if (arg1 && put_user_u32(cpus, arg1)) { return -TARGET_EFAULT; } if (arg2 && put_user_u32(node, arg2)) { @@ -10649,24 +10649,24 @@ static abi_long do_syscall1(void *cpu_env, int nu= m, abi_long arg1, case TARGET_NR_listxattr: case TARGET_NR_llistxattr: { - void *p, *b =3D 0; + void *q, *b =3D 0; if (arg2) { b =3D lock_user(VERIFY_WRITE, arg2, arg3, 0); if (!b) { return -TARGET_EFAULT; } } - p =3D lock_user_string(arg1); - if (p) { + q =3D lock_user_string(arg1); + if (q) { if (num =3D=3D TARGET_NR_listxattr) { - ret =3D get_errno(listxattr(p, b, arg3)); + ret =3D get_errno(listxattr(q, b, arg3)); } else { - ret =3D get_errno(llistxattr(p, b, arg3)); + ret =3D get_errno(llistxattr(q, b, arg3)); } } else { ret =3D -TARGET_EFAULT; } - unlock_user(p, arg1, 0); + unlock_user(q, arg1, 0); unlock_user(b, arg2, arg3); return ret; } @@ -10686,25 +10686,25 @@ static abi_long do_syscall1(void *cpu_env, int nu= m, abi_long arg1, case TARGET_NR_setxattr: case TARGET_NR_lsetxattr: { - void *p, *n, *v =3D 0; + void *q, *n, *v =3D 0; if (arg3) { v =3D lock_user(VERIFY_READ, arg3, arg4, 1); if (!v) { return -TARGET_EFAULT; } } - p =3D lock_user_string(arg1); + q =3D lock_user_string(arg1); n =3D lock_user_string(arg2); - if (p && n) { + if (q && n) { if (num =3D=3D TARGET_NR_setxattr) { - ret =3D get_errno(setxattr(p, n, v, arg4, arg5)); + ret =3D get_errno(setxattr(q, n, v, arg4, arg5)); } else { - ret =3D get_errno(lsetxattr(p, n, v, arg4, arg5)); + ret =3D get_errno(lsetxattr(q, n, v, arg4, arg5)); } } else { ret =3D -TARGET_EFAULT; } - unlock_user(p, arg1, 0); + unlock_user(q, arg1, 0); unlock_user(n, arg2, 0); unlock_user(v, arg3, 0); } @@ -10731,25 +10731,25 @@ static abi_long do_syscall1(void *cpu_env, int nu= m, abi_long arg1, case TARGET_NR_getxattr: case TARGET_NR_lgetxattr: { - void *p, *n, *v =3D 0; + void *q, *n, *v =3D 0; if (arg3) { v =3D lock_user(VERIFY_WRITE, arg3, arg4, 0); if (!v) { return -TARGET_EFAULT; } } - p =3D lock_user_string(arg1); + q =3D lock_user_string(arg1); n =3D lock_user_string(arg2); - if (p && n) { + if (q && n) { if (num =3D=3D TARGET_NR_getxattr) { - ret =3D get_errno(getxattr(p, n, v, arg4)); + ret =3D get_errno(getxattr(q, n, v, arg4)); } else { - ret =3D get_errno(lgetxattr(p, n, v, arg4)); + ret =3D get_errno(lgetxattr(q, n, v, arg4)); } } else { ret =3D -TARGET_EFAULT; } - unlock_user(p, arg1, 0); + unlock_user(q, arg1, 0); unlock_user(n, arg2, 0); unlock_user(v, arg3, arg4); } @@ -10776,19 +10776,19 @@ static abi_long do_syscall1(void *cpu_env, int nu= m, abi_long arg1, case TARGET_NR_removexattr: case TARGET_NR_lremovexattr: { - void *p, *n; - p =3D lock_user_string(arg1); + void *q, *n; + q =3D lock_user_string(arg1); n =3D lock_user_string(arg2); - if (p && n) { + if (q && n) { if (num =3D=3D TARGET_NR_removexattr) { - ret =3D get_errno(removexattr(p, n)); + ret =3D get_errno(removexattr(q, n)); } else { - ret =3D get_errno(lremovexattr(p, n)); + ret =3D get_errno(lremovexattr(q, n)); } } else { ret =3D -TARGET_EFAULT; } - unlock_user(p, arg1, 0); + unlock_user(q, arg1, 0); unlock_user(n, arg2, 0); } return ret; --=20 2.17.0