[Qemu-devel] [PATCH] qdev: Delete unused LostTickPolicy "merge"

Markus Armbruster posted 1 patch 4 years, 12 months ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190401150140.29151-1-armbru@redhat.com
Maintainers: Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>
qapi/misc.json | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
[Qemu-devel] [PATCH] qdev: Delete unused LostTickPolicy "merge"
Posted by Markus Armbruster 4 years, 12 months ago
Commit 4e4fa398db6 "qdev: Introduce lost tick policy property"
(v1.1.0) created PropertyType PROP_TYPE_LOSTTICKPOLICY with values
"discard", "delay", "merge", and "slew".  Value "merge" has never been
used.  Delete it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/misc.json | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/qapi/misc.json b/qapi/misc.json
index 8b3ca4fdd3..dc4cf9da20 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -172,17 +172,13 @@
 # @delay: continue to deliver ticks at the normal rate.  Guest time will be
 #         delayed due to the late tick
 #
-# @merge: merge the missed tick(s) into one tick and inject.  Guest time
-#         may be delayed, depending on how the OS reacts to the merging
-#         of ticks
-#
 # @slew: deliver ticks at a higher rate to catch up with the missed tick. The
 #        guest time should not be delayed once catchup is complete.
 #
 # Since: 2.0
 ##
 { 'enum': 'LostTickPolicy',
-  'data': ['discard', 'delay', 'merge', 'slew' ] }
+  'data': ['discard', 'delay', 'slew' ] }
 
 ##
 # @add_client:
-- 
2.17.2


Re: [Qemu-devel] [PATCH] qdev: Delete unused LostTickPolicy "merge"
Posted by Eric Blake 4 years, 12 months ago
On 4/1/19 10:01 AM, Markus Armbruster wrote:
> Commit 4e4fa398db6 "qdev: Introduce lost tick policy property"
> (v1.1.0) created PropertyType PROP_TYPE_LOSTTICKPOLICY with values
> "discard", "delay", "merge", and "slew".  Value "merge" has never been
> used.  Delete it.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/misc.json | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Doesn't hurt if you try to cram it in -rc2, but also doesn't hurt if you
delay to 4.1.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org