[Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field

Zhang Chen posted 1 patch 4 years, 12 months ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190329202003.30988-1-chen.zhang@intel.com
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
[Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field
Posted by Zhang Chen 4 years, 12 months ago
From: Zhang Chen <chen.zhang@intel.com>

Add bitmap.h and bitops.h to Dirty Bitmaps field.

Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 56139ac8ab..360af3e8ca 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1773,6 +1773,8 @@ S: Supported
 F: util/hbitmap.c
 F: block/dirty-bitmap.c
 F: include/qemu/hbitmap.h
+F: include/qemu/bitmap.h
+F: include/qemu/bitops.h
 F: include/block/dirty-bitmap.h
 F: tests/test-hbitmap.c
 F: docs/interop/bitmaps.rst
-- 
2.17.GIT


Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field
Posted by John Snow 4 years, 12 months ago

On 3/29/19 4:20 PM, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
> 
> Add bitmap.h and bitops.h to Dirty Bitmaps field.
> 
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 56139ac8ab..360af3e8ca 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1773,6 +1773,8 @@ S: Supported
>  F: util/hbitmap.c
>  F: block/dirty-bitmap.c
>  F: include/qemu/hbitmap.h
> +F: include/qemu/bitmap.h
> +F: include/qemu/bitops.h
>  F: include/block/dirty-bitmap.h
>  F: tests/test-hbitmap.c
>  F: docs/interop/bitmaps.rst
> 

Actually, these bitmaps aren't the same kind as is used by the block
storage module -- these are a more generic, primitive kind that I have
no association with.

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field
Posted by Zhang, Chen 4 years, 12 months ago
> -----Original Message-----
> From: John Snow [mailto:jsnow@redhat.com]
> Sent: Wednesday, April 3, 2019 5:07 AM
> To: Zhang, Chen <chen.zhang@intel.com>; Laurent Vivier <laurent@vivier.eu>;
> qemu-dev <qemu-devel@nongnu.org>; Fam Zheng <fam@euphon.net>
> Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap
> file to related field
> 
> 
> 
> On 3/29/19 4:20 PM, Zhang Chen wrote:
> > From: Zhang Chen <chen.zhang@intel.com>
> >
> > Add bitmap.h and bitops.h to Dirty Bitmaps field.
> >
> > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > ---
> >  MAINTAINERS | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index 56139ac8ab..360af3e8ca
> > 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1773,6 +1773,8 @@ S: Supported
> >  F: util/hbitmap.c
> >  F: block/dirty-bitmap.c
> >  F: include/qemu/hbitmap.h
> > +F: include/qemu/bitmap.h
> > +F: include/qemu/bitops.h
> >  F: include/block/dirty-bitmap.h
> >  F: tests/test-hbitmap.c
> >  F: docs/interop/bitmaps.rst
> >
> 
> Actually, these bitmaps aren't the same kind as is used by the block storage
> module -- these are a more generic, primitive kind that I have no association
> with.

OK, but these two files are lack of maintenance.
Which maintenance area do you think these two files should belong to?


Thanks
Zhang Chen


Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field
Posted by John Snow 4 years, 11 months ago

On 4/2/19 9:25 PM, Zhang, Chen wrote:
> 
>> -----Original Message-----
>> From: John Snow [mailto:jsnow@redhat.com]
>> Sent: Wednesday, April 3, 2019 5:07 AM
>> To: Zhang, Chen <chen.zhang@intel.com>; Laurent Vivier <laurent@vivier.eu>;
>> qemu-dev <qemu-devel@nongnu.org>; Fam Zheng <fam@euphon.net>
>> Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap
>> file to related field
>>
>>
>>
>> On 3/29/19 4:20 PM, Zhang Chen wrote:
>>> From: Zhang Chen <chen.zhang@intel.com>
>>>
>>> Add bitmap.h and bitops.h to Dirty Bitmaps field.
>>>
>>> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
>>> ---
>>>  MAINTAINERS | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS index 56139ac8ab..360af3e8ca
>>> 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1773,6 +1773,8 @@ S: Supported
>>>  F: util/hbitmap.c
>>>  F: block/dirty-bitmap.c
>>>  F: include/qemu/hbitmap.h
>>> +F: include/qemu/bitmap.h
>>> +F: include/qemu/bitops.h
>>>  F: include/block/dirty-bitmap.h
>>>  F: tests/test-hbitmap.c
>>>  F: docs/interop/bitmaps.rst
>>>
>>
>> Actually, these bitmaps aren't the same kind as is used by the block storage
>> module -- these are a more generic, primitive kind that I have no association
>> with.
> 
> OK, but these two files are lack of maintenance.
> Which maintenance area do you think these two files should belong to?
> 
> 
> Thanks
> Zhang Chen
> 
> 

Ehm, I'm not sure. Looks like Paolo and Stefan are the active developers
who have touched it the most.

Do the two of you want me to fold this into the bitmaps section so that
it has a point of contact?

--js