From nobody Wed May 1 22:22:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1553606859471493.5235342811659; Tue, 26 Mar 2019 06:27:39 -0700 (PDT) Received: from localhost ([127.0.0.1]:59943 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8m76-0004Lr-Cz for importer@patchew.org; Tue, 26 Mar 2019 09:27:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8lya-0005R2-Cu for qemu-devel@nongnu.org; Tue, 26 Mar 2019 09:18:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8lr7-00011j-2f for qemu-devel@nongnu.org; Tue, 26 Mar 2019 09:11:09 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:35755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8lr5-0000wZ-JO for qemu-devel@nongnu.org; Tue, 26 Mar 2019 09:11:04 -0400 Received: by mail-wm1-x334.google.com with SMTP id y197so12873880wmd.0 for ; Tue, 26 Mar 2019 06:11:01 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id x14sm8582494wmj.3.2019.03.26.06.10.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 06:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=zWnYxbAcOWgLgsyQpqqPGlVSJCDS0TJrcXzOjIoAl6k=; b=oKQpy08jescyA/cAEI40TtvL+PzZkQ0zTvLjQ6pSyCRW9fpSZcByRgYhOSFILusrW9 +ENzoRZvJXBIN8g3MXtFvNyhTiqxJwUPilLqQ/nlEnOBvxisHQVbCITdheh47xiw7pr5 jWBdRLARrUkJgTQeZNkLM93B+LZs6L6xGdfpFPksc2PFEPcDg6MqGBIKXxAD4PxeESW4 wNB9SxHyLnfqg38H6sW0t+LMKeETNImwbKd38ZfLH064RDtGgtMmwM1fjssxQvkQyWzS paymRETKBWh4E9EUXXOb6lHQZNimaBjnCm1Wxjbp1t/rNqXNaSQhfFTlYVnA6GqGd0sj TFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zWnYxbAcOWgLgsyQpqqPGlVSJCDS0TJrcXzOjIoAl6k=; b=YSxn97fegBErSqNBGBfkXVhvDkmf92hVy+Q8t5wePsiK+tqb6wgE32i8TASwZYW3gB FvaM/MIn05Ij6oJu7ZwhHKLstNrnZicaAVvjZohXnMJ3DhIKDrnPNtLW8o7GwpGpDTx3 o6qK0dqUObBy/CYQkxSvxhWX4VDBvkSmtoW6NfodA0fqEL/jnWOc+ecJfeOBuJrOAQKm SuSTHwXHzPiDEZfwinSDJZTVe7rndqbTEnDT66CE+sihFMas9D3hZ9/dWIWctahwh3F2 vIRb+A4OhXWzCc44Fr/CR+AXsetHdu0G1oV0X9n9dEuRR23bovmKtRVL7e/JaAXqBb0T rnhA== X-Gm-Message-State: APjAAAXtgkEg9HBM5gMPVRoDnTS5mM4bkXWSY/pr8tX3LpuSfaDHBzw9 xaXlQV5f+eT6OyjVgPs7GDInDMyTieo= X-Google-Smtp-Source: APXvYqzYlsABbePCKHBGVUfCmN2tXH8rQHVJN6kv8QkN2XDx7KZ4FI3qzwEikyK49XIjkGUZRlBmgg== X-Received: by 2002:a1c:d189:: with SMTP id i131mr15390970wmg.151.1553605860443; Tue, 26 Mar 2019 06:11:00 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 26 Mar 2019 13:10:55 +0000 Message-Id: <20190326131056.28451-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190326131056.28451-1-peter.maydell@linaro.org> References: <20190326131056.28451-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::334 Subject: [Qemu-devel] [PULL 1/2] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Richard Henderson Fixes: https://bugs.launchpad.net/bugs/1821430 Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Message-id: 20190325161338.6536-1-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 504a4771fbd..41557821974 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -2028,6 +2028,11 @@ static void arm_max_initfn(Object *obj) t =3D FIELD_DP32(t, ID_ISAR6, SPECRES, 1); cpu->isar.id_isar6 =3D t; =20 + t =3D cpu->isar.mvfr2; + t =3D FIELD_DP32(t, MVFR2, SIMDMISC, 3); /* SIMD MaxNum */ + t =3D FIELD_DP32(t, MVFR2, FPMISC, 4); /* FP MaxNum */ + cpu->isar.mvfr2 =3D t; + t =3D cpu->id_mmfr4; t =3D FIELD_DP32(t, ID_MMFR4, HPDS, 1); /* AA32HPD */ cpu->id_mmfr4 =3D t; --=20 2.20.1 From nobody Wed May 1 22:22:46 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1553606683824290.31261563274074; Tue, 26 Mar 2019 06:24:43 -0700 (PDT) Received: from localhost ([127.0.0.1]:59869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8m44-0001ZC-Jy for importer@patchew.org; Tue, 26 Mar 2019 09:24:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8lyf-0005IE-Up for qemu-devel@nongnu.org; Tue, 26 Mar 2019 09:18:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8lr7-000124-MS for qemu-devel@nongnu.org; Tue, 26 Mar 2019 09:11:09 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:51669) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8lr7-00010t-Df for qemu-devel@nongnu.org; Tue, 26 Mar 2019 09:11:05 -0400 Received: by mail-wm1-x344.google.com with SMTP id 4so12578722wmf.1 for ; Tue, 26 Mar 2019 06:11:02 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id x14sm8582494wmj.3.2019.03.26.06.11.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 06:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=BzMiWTOMRhLgNp4RFZYHSq9epp4Md3jkRfGSNm+ICm0=; b=et7HVs5Lp1xyroO7GY6u5qbEcn+a3epF16W5UT0hTpdu4fYhg9jNTNkqVe0bFCPdDj AueuikjXR4SGY7fmWXCrbWQqZu4O8weL5uoq/qh4CIUr+nUIPa3Ny5xbjsMpkt3Y4xR8 6rH+XfzoNzQWW3r9eGZDD+VN2Sw67zo9vRT3s/oyUKfCRGPJqMq5fdZmoGmkabUkni2q OAQQYZ6RXLoteC1XIFKpHdH2e/nOHdv02alxQHXrjE4E7jObzVNi+zzJtWmKYUMaWUNW S+d8aZk2Uee7SIiLLidLHBGBpR9yHfghe4BUEb134BZE7Ksh1pwnFROWIaSY4+40ckbU l70A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BzMiWTOMRhLgNp4RFZYHSq9epp4Md3jkRfGSNm+ICm0=; b=JzSHyDf+biY87uFDyGyjklmBgy94leyyLzlVHRsWqT5jUIFEapAw2p1pWIERfziJc7 zbj5+Kb4AbOdYnj0RG9Gn0qp5xK7wquiEnIt+Drr03YINSaxUYcF3E+hf6H+jlWm8feH RsnhwtcW22rliEwuag+41EG9mSBIFDbM3/QVkHlh4y9Vo9x5YYaA9IC/IxKFjbpt8bQt GmU6J1G/YsSEHmuuelIokXVDDPftkftCi4+t6VNCtTgZTmnN7QcloezUfT1VVVa/IqAX KRIBC3p1lGDPwcd+9DbKTBOqDFXqEx3Inl4DIELDTiGFogKWYlwL2vjrJKpFSV1hyFvi Ud8A== X-Gm-Message-State: APjAAAUsjUNqCSutu24j2bHT4HG92PXik5TT6lYNJzU847jGEugBciTc 1/hyiVifBHIiuXyKcO8HXaD7g8gcWwo= X-Google-Smtp-Source: APXvYqwvps0JqA9ZXIELmQ+Ko97Sle0SPHoSW0WsJi0aT0HtRe2jGxDHBClHc0aUxjvRfMSEJQJXpQ== X-Received: by 2002:a1c:9cc1:: with SMTP id f184mr9246906wme.150.1553605861624; Tue, 26 Mar 2019 06:11:01 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 26 Mar 2019 13:10:56 +0000 Message-Id: <20190326131056.28451-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190326131056.28451-1-peter.maydell@linaro.org> References: <20190326131056.28451-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PULL 2/2] gdbstub: fix vCont packet handling when no thread is specified X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Luc Michel The vCont packet accepts a series of actions, each being applied on a given thread ID. Giving no thread ID for an action is valid and means "all threads". This commit fixes vCont packets being incorrectly rejected when no thread ID was given for an action. In multiprocess mode, the GDB Remote Protocol specification is unclear on what "all threads" means. We choose to apply the action on all threads of all attached processes. This commit is based on the initial fix by Lucien Murray-Pitts. Fixes: e40e5204af8388 Reported-by: Lucien Murray-Pitts Reported-by: Jan Kiszka Signed-off-by: Luc Michel Reviewed-by: Richard Henderson Message-id: 20190325110452.6756-1-luc.michel@greensocs.com Signed-off-by: Peter Maydell --- gdbstub.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index bc774ae9925..d54abd17cc2 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1152,6 +1152,7 @@ static int gdb_handle_vcont(GDBState *s, const char *= p) uint32_t pid, tid; GDBProcess *process; CPUState *cpu; + GDBThreadIdKind kind; #ifdef CONFIG_USER_ONLY int max_cpus =3D 1; /* global variable max_cpus exists only in system = mode */ =20 @@ -1194,12 +1195,21 @@ static int gdb_handle_vcont(GDBState *s, const char= *p) goto out; } =20 - if (*p++ !=3D ':') { + if (*p =3D=3D '\0' || *p =3D=3D ';') { + /* + * No thread specifier, action is on "all threads". The + * specification is unclear regarding the process to act on. We + * choose all processes. + */ + kind =3D GDB_ALL_PROCESSES; + } else if (*p++ =3D=3D ':') { + kind =3D read_thread_id(p, &p, &pid, &tid); + } else { res =3D -ENOTSUP; goto out; } =20 - switch (read_thread_id(p, &p, &pid, &tid)) { + switch (kind) { case GDB_READ_THREAD_ERR: res =3D -EINVAL; goto out; --=20 2.20.1