From nobody Fri May 17 12:14:42 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1553528982577407.62907119058275; Mon, 25 Mar 2019 08:49:42 -0700 (PDT) Received: from localhost ([127.0.0.1]:44449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8Rqh-0002B0-T0 for importer@patchew.org; Mon, 25 Mar 2019 11:49:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8RpK-0001eX-Qy for qemu-devel@nongnu.org; Mon, 25 Mar 2019 11:47:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8RpJ-0000LO-Sv for qemu-devel@nongnu.org; Mon, 25 Mar 2019 11:47:54 -0400 Received: from relay.sw.ru ([185.231.240.75]:53368) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8RpJ-0000J4-H9 for qemu-devel@nongnu.org; Mon, 25 Mar 2019 11:47:53 -0400 Received: from [10.28.8.145] (helo=kvm.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1h8RpF-0004xh-0d; Mon, 25 Mar 2019 18:47:49 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Date: Mon, 25 Mar 2019 18:47:48 +0300 Message-Id: <20190325154748.66381-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH] qapi/qmp-dispatch: fix return value in do_qmp_dispatch X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There are no harm but just looks weird to return bool in pointer-returning function. Introduced in 69240fe62d1 with the whole failure-checking "if" chunk. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- qapi/qmp-dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 5f812bb9f2..e2c366e09e 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -111,7 +111,7 @@ static QObject *do_qmp_dispatch(QmpCommandList *cmds, Q= Object *request, if (oob && !(cmd->options & QCO_ALLOW_OOB)) { error_setg(errp, "The command %s does not support OOB", command); - return false; + return NULL; } =20 if (runstate_check(RUN_STATE_PRECONFIG) && --=20 2.18.0