From nobody Tue Feb 10 09:58:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=126.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155344704979520.99580622251051; Sun, 24 Mar 2019 10:04:09 -0700 (PDT) Received: from localhost ([127.0.0.1]:58505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h86XV-00039B-SP for importer@patchew.org; Sun, 24 Mar 2019 13:04:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h86Ql-0006bI-Kz for qemu-devel@nongnu.org; Sun, 24 Mar 2019 12:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h86Mg-0005i0-Lt for qemu-devel@nongnu.org; Sun, 24 Mar 2019 12:52:55 -0400 Received: from m50-112.126.com ([123.125.50.112]:38534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h86Mf-0005hH-Vn for qemu-devel@nongnu.org; Sun, 24 Mar 2019 12:52:54 -0400 Received: from n3-021-211.byted.org (unknown [49.7.44.57]) by smtp6 (Coremail) with SMTP id j9KowABnE7HBtZdcGev0AA--.5136S7; Mon, 25 Mar 2019 00:52:38 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=/ubb8b8wtHGhdorPRE lnukABdB/FSKpUdzPZoL1jw4U=; b=Zx87wmtA3T0PqrmeqI7GDKgbD4M4LAUdXO 7tFioI2KZdD21zD0FAvCAiw7dgZL/IqFYH3TbaItu2K8Jn6kLz8HZ+ac/dXbR25t D2dsj28r1l79XhTe3lY0smZ48CQ4AMt7uys3QToiAT9OZc/+rtdwoLeX7vcmT2SX J2gSSPlAg= From: Fei Li To: qemu-devel@nongnu.org, shirley17fei@gmail.com Date: Mon, 25 Mar 2019 00:52:00 +0800 Message-Id: <20190324165206.25766-6-lifei1214@126.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190324165206.25766-1-lifei1214@126.com> References: <20190324165206.25766-1-lifei1214@126.com> X-CM-TRANSID: j9KowABnE7HBtZdcGev0AA--.5136S7 X-Coremail-Antispam: 1Uf129KBjvJXoW7WF4fuw4DAw4UZF4UAw1xuFg_yoW8WrWDpr Wakr90yr4xG3ZFy39Iyan7Z3W5XrnIga43ArZ3Zw1fCwsxGwsxurW5J3s09rWrCF1xJF4U ZFWS9r1UC3ZxtFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j6hFcUUUUU= X-Originating-IP: [49.7.44.57] X-CM-SenderInfo: 5olivxarsrkqqrswhudrp/1tbiaReBIVpD8EOosQACsv X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 123.125.50.112 Subject: [Qemu-devel] [PATCH v12 for-4.1 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , Peter Xu , "Dr . David Alan Gilbert" , Fei Li , Gerd Hoffmann , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Fei Li Add a local_err to hold the error, and return the corresponding error code to replace the temporary &error_abort. Cc: Markus Armbruster Cc: David Gibson Signed-off-by: Fei Li Acked-by: David Gibson Reviewed-by: Markus Armbruster --- hw/ppc/spapr_hcall.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index 900b71f4a6..25e385d9a1 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -447,6 +447,7 @@ static target_ulong h_resize_hpt_prepare(PowerPCCPU *cp= u, SpaprPendingHpt *pending =3D spapr->pending_hpt; uint64_t current_ram_size; int rc; + Error *local_err =3D NULL; =20 if (spapr->resize_hpt =3D=3D SPAPR_RESIZE_HPT_DISABLED) { return H_AUTHORITY; @@ -507,10 +508,13 @@ static target_ulong h_resize_hpt_prepare(PowerPCCPU *= cpu, pending->shift =3D shift; pending->ret =3D H_HARDWARE; =20 - /* TODO: let the further caller handle the error instead of abort() he= re */ - qemu_thread_create(&pending->thread, "sPAPR HPT prepare", - hpt_prepare_thread, pending, - QEMU_THREAD_DETACHED, &error_abort); + if (qemu_thread_create(&pending->thread, "sPAPR HPT prepare", + hpt_prepare_thread, pending, + QEMU_THREAD_DETACHED, &local_err) < 0) { + error_reportf_err(local_err, "failed to create hpt_prepare_thread:= "); + g_free(pending); + return H_HARDWARE; + } =20 spapr->pending_hpt =3D pending; =20 --=20 2.11.0