From nobody Tue Feb 10 17:30:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1553216169283672.7784039904438; Thu, 21 Mar 2019 17:56:09 -0700 (PDT) Received: from localhost ([127.0.0.1]:49097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h78TZ-00015A-Op for importer@patchew.org; Thu, 21 Mar 2019 20:56:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7836-00030C-FS for qemu-devel@nongnu.org; Thu, 21 Mar 2019 20:28:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h77qn-0000sD-ST for qemu-devel@nongnu.org; Thu, 21 Mar 2019 20:15:58 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:57603) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h77qm-0000gk-Ue; Thu, 21 Mar 2019 20:15:57 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 44QPMB6n5mz9sS7; Fri, 22 Mar 2019 11:15:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1553213750; bh=rtabmjbJ3UDD/n3QHZQ8eicK+udCKYnEc4rarH22mZc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PcoFBHCyuTo0ge5jApquZI2BSEkxDABFhSVaNepmnar92+yjjRDGwI71xmEUtIS2d w2GlG3VPaMTsrn536TYfxNnWo/QfKeRoAzIE0xDIBTsmcSCShnfmG5VS2Xa38pmnc/ hrQ3IqhwnNEIZf7sRkmjSqh9H0eWXYDHrjJBRU6o= From: David Gibson To: richard.henderson@linaro.org, qemu-devel@nongnu.org, groug@nongnu.org, qemu-ppc@nongnu.org Date: Fri, 22 Mar 2019 11:15:35 +1100 Message-Id: <20190322001544.9794-17-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190322001544.9794-1-david@gibson.dropbear.id.au> References: <20190322001544.9794-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash32.[ch] X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, mark.cave-ayland@ilande.co.uk, Alex Williamson , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , clg@kaod.org, aik@ozlabs.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: David Gibson Reviewed-by: C=C3=A9dric Le Goater --- target/ppc/mmu-hash32.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c index e8562a7c87..f83944b78c 100644 --- a/target/ppc/mmu-hash32.c +++ b/target/ppc/mmu-hash32.c @@ -27,7 +27,7 @@ #include "mmu-hash32.h" #include "exec/log.h" =20 -//#define DEBUG_BAT +/* #define DEBUG_BAT */ =20 #ifdef DEBUG_BATS # define LOG_BATS(...) qemu_log_mask(CPU_LOG_MMU, __VA_ARGS__) @@ -228,8 +228,10 @@ static int ppc_hash32_direct_store(PowerPCCPU *cpu, ta= rget_ulong sr, qemu_log_mask(CPU_LOG_MMU, "direct store...\n"); =20 if ((sr & 0x1FF00000) >> 20 =3D=3D 0x07f) { - /* Memory-forced I/O controller interface access */ - /* If T=3D1 and BUID=3Dx'07F', the 601 performs a memory access + /* + * Memory-forced I/O controller interface access + * + * If T=3D1 and BUID=3Dx'07F', the 601 performs a memory access * to SR[28-31] LA[4-31], bypassing all protection mechanisms. */ *raddr =3D ((sr & 0xF) << 28) | (eaddr & 0x0FFFFFFF); @@ -266,8 +268,9 @@ static int ppc_hash32_direct_store(PowerPCCPU *cpu, tar= get_ulong sr, return 1; case ACCESS_CACHE: /* dcba, dcbt, dcbtst, dcbf, dcbi, dcbst, dcbz, or icbi */ - /* Should make the instruction do no-op. - * As it already do no-op, it's quite easy :-) + /* + * Should make the instruction do no-op. As it already do + * no-op, it's quite easy :-) */ *raddr =3D eaddr; return 0; @@ -519,8 +522,10 @@ int ppc_hash32_handle_mmu_fault(PowerPCCPU *cpu, vaddr= eaddr, int rwx, if (rwx =3D=3D 1) { new_pte1 |=3D HPTE32_R_C; /* set changed (dirty) bit */ } else { - /* Treat the page as read-only for now, so that a later write - * will pass through this function again to set the C bit */ + /* + * Treat the page as read-only for now, so that a later write + * will pass through this function again to set the C bit + */ prot &=3D ~PAGE_WRITE; } =20 --=20 2.20.1