From nobody Tue May 21 01:59:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1553179334979438.99333754677696; Thu, 21 Mar 2019 07:42:14 -0700 (PDT) Received: from localhost ([127.0.0.1]:38571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6ytQ-0006DG-FB for importer@patchew.org; Thu, 21 Mar 2019 10:42:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6yrn-0005Lm-8S for qemu-devel@nongnu.org; Thu, 21 Mar 2019 10:40:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6yhs-0004fb-47 for qemu-devel@nongnu.org; Thu, 21 Mar 2019 10:30:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52972) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h6yhq-0004T1-2W for qemu-devel@nongnu.org; Thu, 21 Mar 2019 10:30:07 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1AF330832CD for ; Thu, 21 Mar 2019 14:30:01 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id C606660BF3; Thu, 21 Mar 2019 14:29:59 +0000 (UTC) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 21 Mar 2019 15:29:58 +0100 Message-Id: <20190321142958.4088-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 21 Mar 2019 14:30:02 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] virtio-vga: only enable for specific boards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When virtio-vga was added, the intention was to only support it for those machines where the firmware does not know about virtio-gpu, and supported VGA legacy hardware before virtio-{gpu,vga} were introduced. The Kconfig switch however enabled virtio-vga for all machines with a PCI bus, and libvirt then prefers it even on hardware where virtio-gpu would be preferrable. At least for now, only enable virtio-vga for PC, hppa and pSeries machines, as was the case before Kconfig dependencies were introduced. Reported-by: Laszlo Ersek Signed-off-by: Paolo Bonzini Reviewed-by: Laszlo Ersek Reviewed-by: Thomas Huth Tested-by: Laszlo Ersek --- hw/display/Kconfig | 2 +- hw/hppa/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/ppc/Kconfig | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/display/Kconfig b/hw/display/Kconfig index 86c1d544c5..72be57a403 100644 --- a/hw/display/Kconfig +++ b/hw/display/Kconfig @@ -100,7 +100,7 @@ config VIRTIO_GPU =20 config VIRTIO_VGA bool - default y if PCI_DEVICES + # defaults to "N", enabled by specific boards depends on VIRTIO_PCI select VGA =20 diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig index 7334f57081..6e5d74a825 100644 --- a/hw/hppa/Kconfig +++ b/hw/hppa/Kconfig @@ -2,6 +2,7 @@ config DINO bool imply PCI_DEVICES imply E1000_PCI + imply VIRTIO_VGA select PCI select SERIAL select ISA_BUS diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 8e8444dbf9..a6aed7c131 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -19,6 +19,7 @@ config PC imply TPM_CRB imply TPM_TIS imply VGA_PCI + imply VIRTIO_VGA select FDC select I8259 select I8254 diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index ae07b4da63..a3465155f0 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -2,6 +2,7 @@ config PSERIES bool imply PCI_DEVICES imply TEST_DEVICES + imply VIRTIO_VGA select DIMM select PCI select SPAPR_VSCSI --=20 2.20.1