From nobody Fri May 3 15:31:57 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552916490703132.40120224717054; Mon, 18 Mar 2019 06:41:30 -0700 (PDT) Received: from localhost ([127.0.0.1]:41841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5sW4-0002NY-4w for importer@patchew.org; Mon, 18 Mar 2019 09:41:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5sV7-000209-Lv for qemu-devel@nongnu.org; Mon, 18 Mar 2019 09:40:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5sV6-0008Sd-U9 for qemu-devel@nongnu.org; Mon, 18 Mar 2019 09:40:25 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:34966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5sV6-0008Rg-Bx for qemu-devel@nongnu.org; Mon, 18 Mar 2019 09:40:24 -0400 Received: by mail-wr1-x444.google.com with SMTP id w1so11157773wrp.2 for ; Mon, 18 Mar 2019 06:40:23 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id o8sm10868797wma.1.2019.03.18.06.40.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 06:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+e3wFMAIpNcD1ZZw82NEFyji4nDuNmWJWIOik8ad87s=; b=rnnQNbjd+EsoxLeLEi1rDS6JqLV/Qtam7KvoAMHonhTUuzzfV+qy31QUg0kEh0y36L hs/+Kp10EGdulHMHIv1IjW+VQqRhimyGEutU876WTl/oiFDBN7AIi1b2NJjrOmWyPEhN 5b8VZnC8MxcGhpkHsVKSPH+KOryyKXxgUOAzW0VWJBqf9aSPtgLRx6YiLGRVYvmuBVkm ZeiuJvUK93Jm7VK8VjwquaP0CwXXi2WriXzaoBoD3J4FYL0BO7vRBV5LjDxItB3/fUP1 xgaMOckj5geP6PDRqKcUuxDMWbVq68qHZNgTp6sfs0/d/10NER7Eu6zM2oDY7wGovKoB q8jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+e3wFMAIpNcD1ZZw82NEFyji4nDuNmWJWIOik8ad87s=; b=CxXKRWM5kWd5+QZcLERDqTBpfvRTpoZQNrZau1GRPIvYlTsAChjngZ7rAYWMYU0Ed9 FWSBBmDyG/jpi4ejXvFFFipJJ6QUvKAxu1nmMJb4uMNa3Pdbbl0tjEdYT/pKifb0bcMm f+mISUI24759QItUG/+vDkZJqSwSBpCcPtR0eNAwriWG7CxQTQfQynTm9s1fTjdL27rv aFIlfomHg8Wf3Q2+xEyqBXC25+hy/U8hSUiQ4gLn63Z0yDISQn62QGGWlK1lUXopdSZv +gi8PfRbqutWdS/Qh2OuwBHKX3q8DWIWQ5u+0hw41KBXl7ToR2Le5r3IgArZL76soUCb AKNw== X-Gm-Message-State: APjAAAWGvqUCdrpP7mNbGIVGR5e12K4n/G5n5il1Oz5piU+sAG8tvBpy FG6n9sc9B+Lv7DVUJuXSbeJcvU2xeRw= X-Google-Smtp-Source: APXvYqyyhtzHFMKOxIC5ShDOx8mxxEGhmbaMNrf4zO0GE0mrd+Ol7u5OuFC+B4Pvu3DwDQdZYbxnOw== X-Received: by 2002:adf:f64d:: with SMTP id x13mr7191016wrp.298.1552916422357; Mon, 18 Mar 2019 06:40:22 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 18 Mar 2019 13:40:19 +0000 Message-Id: <20190318134019.23729-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH] configure: Remove --source-path option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Ospite , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Normally configure identifies the source path by looking at the location where the configure script itself exists. We also provide a --source-path option which lets the user manually override this. There isn't really an obvious use case for the --source-path option, and in commit 927128222b0a91f56c13a in 2017 we accidentally added some logic that looks at $source_path before the command line option that overrides it has been processed. The fact that nobody complained suggests that there isn't any use of this option and we aren't testing it either; remove it. This allows us to move the "make $source_path absolute" logic up so that there is no window in the script where $source_path is set but not yet absolute. Signed-off-by: Peter Maydell Reviewed-by: Daniel P. Berrang=C3=A9 --- Since this is a "noticed while reading code" issue rather than one that's actually causing a problem, it's probably 4.1 material at this point. Cc'ing Antonio since they also have a patch to configure which this will affect. --- configure | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 7071f525843..bc2953e6114 100755 --- a/configure +++ b/configure @@ -278,6 +278,8 @@ ld_has() { =20 # default parameters source_path=3D$(dirname "$0") +# make source path absolute +source_path=3D$(cd "$source_path"; pwd) cpu=3D"" iasl=3D"iasl" interp_prefix=3D"/usr/gnemul/qemu-%M" @@ -519,8 +521,6 @@ for opt do ;; --cxx=3D*) CXX=3D"$optarg" ;; - --source-path=3D*) source_path=3D"$optarg" - ;; --cpu=3D*) cpu=3D"$optarg" ;; --extra-cflags=3D*) QEMU_CFLAGS=3D"$QEMU_CFLAGS $optarg" @@ -599,9 +599,6 @@ if test "$debug_info" =3D "yes"; then LDFLAGS=3D"-g $LDFLAGS" fi =20 -# make source path absolute -source_path=3D$(cd "$source_path"; pwd) - # running configure in the source tree? # we know that's the case if configure is there. if test -f "./configure"; then @@ -945,8 +942,6 @@ for opt do ;; --interp-prefix=3D*) interp_prefix=3D"$optarg" ;; - --source-path=3D*) - ;; --cross-prefix=3D*) ;; --cc=3D*) @@ -1624,7 +1619,6 @@ $(echo Available targets: $default_target_list | \ fold -s -w 53 | sed -e 's/^/ /') =20 Advanced options (experts only): - --source-path=3DPATH path of source code [$source_path] --cross-prefix=3DPREFIX use PREFIX for compile tools [$cross_prefix] --cc=3DCC use C compiler CC [$cc] --iasl=3DIASL use ACPI compiler IASL [$iasl] --=20 2.20.1