From nobody Mon Feb 9 15:11:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552908304580959.7955808567018; Mon, 18 Mar 2019 04:25:04 -0700 (PDT) Received: from localhost ([127.0.0.1]:39735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5qO5-0007Be-JQ for importer@patchew.org; Mon, 18 Mar 2019 07:25:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5qJz-0004Nm-HK for qemu-devel@nongnu.org; Mon, 18 Mar 2019 07:20:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5qJx-00049W-UD for qemu-devel@nongnu.org; Mon, 18 Mar 2019 07:20:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52736) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5qJv-00047n-Oz for qemu-devel@nongnu.org; Mon, 18 Mar 2019 07:20:44 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B1E836887; Mon, 18 Mar 2019 11:20:42 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-24.ams2.redhat.com [10.36.116.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id E58F160C54; Mon, 18 Mar 2019 11:20:38 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 25D4017534; Mon, 18 Mar 2019 12:20:38 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Mon, 18 Mar 2019 12:20:34 +0100 Message-Id: <20190318112038.11223-2-kraxel@redhat.com> In-Reply-To: <20190318112038.11223-1-kraxel@redhat.com> References: <20190318112038.11223-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 18 Mar 2019 11:20:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/5] vnc: fix unalignment access in tight_pack24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Qiang When adding '-fsanitize=3Dundefined' in compiling configuration and connect VM with vnc, it reports following error: ui/vnc-enc-tight.c:910:13: runtime error: load of misaligned address 0x621000466513 for type 'uint32_t', which requires 4 byte alignment This patch fix this issue. Signed-off-by: Li Qiang Message-id: 20190318010442.14897-1-liq3ea@163.com Signed-off-by: Gerd Hoffmann --- ui/vnc-enc-tight.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 0b4a5ac71f77..d20cd1d86dfe 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -886,11 +886,11 @@ static int tight_compress_data(VncState *vs, int stre= am_id, size_t bytes, */ static void tight_pack24(VncState *vs, uint8_t *buf, size_t count, size_t = *ret) { - uint32_t *buf32; + uint8_t *buf8; uint32_t pix; int rshift, gshift, bshift; =20 - buf32 =3D (uint32_t *)buf; + buf8 =3D buf; =20 if (1 /* FIXME */) { rshift =3D vs->client_pf.rshift; @@ -907,10 +907,11 @@ static void tight_pack24(VncState *vs, uint8_t *buf, = size_t count, size_t *ret) } =20 while (count--) { - pix =3D *buf32++; + pix =3D ldl_he_p(buf8); *buf++ =3D (char)(pix >> rshift); *buf++ =3D (char)(pix >> gshift); *buf++ =3D (char)(pix >> bshift); + buf8 +=3D 4; } } =20 --=20 2.18.1