From nobody Tue Apr 30 04:30:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552824575353935.5646533442244; Sun, 17 Mar 2019 05:09:35 -0700 (PDT) Received: from localhost ([127.0.0.1]:55031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5UbZ-0002ov-0E for importer@patchew.org; Sun, 17 Mar 2019 08:09:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Uaa-0002Rf-4n for qemu-devel@nongnu.org; Sun, 17 Mar 2019 08:08:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5UaX-0005RH-UC for qemu-devel@nongnu.org; Sun, 17 Mar 2019 08:08:28 -0400 Received: from m12-18.163.com ([220.181.12.18]:54837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5UaT-0005NP-MK for qemu-devel@nongnu.org; Sun, 17 Mar 2019 08:08:23 -0400 Received: from localhost.localdomain (unknown [115.206.1.253]) by smtp14 (Coremail) with SMTP id EsCowAB30NrgN45cX9J4Kw--.41753S2; Sun, 17 Mar 2019 20:04:49 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=a2bmS2vX8GpVKGsC9O XMVosGnqrMy/aagRMCNf9T4ck=; b=Gdbt4b9dRgqy2ZpqOhdEL7PZY5qHKDzx0E y8S3T9J+DpMqX+FT4h7ZhniCjeRXkhM3iquYyuAbrlvMtaUrR8NaoR9tRkSAkdWy TCTnoZsIZq/+eQKit2BQwKY2KxjnWwUbBGxR98h2/S2Qz1AW+BuRFC8L/P9ENIeg lLwiUVVMo= From: Li Qiang To: kraxel@redhat.com Date: Sun, 17 Mar 2019 05:04:41 -0700 Message-Id: <20190317120441.64846-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: EsCowAB30NrgN45cX9J4Kw--.41753S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Jry7XF4xXFWrCr48ur4xtFb_yoW8JrW8pr yUC3WqgayxAF1xtFZ7K34UCF1UCrWkuF13Cr4UX3WfAFy7Jr9Yvr13Ka4kAa48Gr93Zr17 XFs3WF17u3Wayr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UlApOUUUUU= X-Originating-IP: [115.206.1.253] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiFAh6bVaDztKXaQAAs8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.18 Subject: [Qemu-devel] [PATCH] vnc: fix unalignment access in tight_pack24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When adding '-fsanitize=3Dundefined' in compiling configuration and connect VM with vnc, it reports following error: ui/vnc-enc-tight.c:910:13: runtime error: load of misaligned address 0x621000466513 for type 'uint32_t', which requires 4 byte alignment This patch fix this issue. Signed-off-by: Li Qiang --- ui/vnc-enc-tight.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 0b4a5ac71f..7e1be63af3 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -886,11 +886,11 @@ static int tight_compress_data(VncState *vs, int stre= am_id, size_t bytes, */ static void tight_pack24(VncState *vs, uint8_t *buf, size_t count, size_t = *ret) { - uint32_t *buf32; + uint8_t *buf8; uint32_t pix; int rshift, gshift, bshift; =20 - buf32 =3D (uint32_t *)buf; + buf8 =3D buf; =20 if (1 /* FIXME */) { rshift =3D vs->client_pf.rshift; @@ -907,10 +907,11 @@ static void tight_pack24(VncState *vs, uint8_t *buf, = size_t count, size_t *ret) } =20 while (count--) { - pix =3D *buf32++; + memcpy(&pix, buf8, sizeof(uint32_t)); *buf++ =3D (char)(pix >> rshift); *buf++ =3D (char)(pix >> gshift); *buf++ =3D (char)(pix >> bshift); + buf8 +=3D 4; } } =20 --=20 2.17.1