From nobody Wed May 8 17:18:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552776260967525.107452310017; Sat, 16 Mar 2019 15:44:20 -0700 (PDT) Received: from localhost ([127.0.0.1]:47422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5I2I-0007lp-Q3 for importer@patchew.org; Sat, 16 Mar 2019 18:44:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Hxs-0004Te-5R for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5Hxq-0002Cr-PU for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52352) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5Hxq-0002CM-EZ; Sat, 16 Mar 2019 18:39:38 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 906E03DDB6; Sat, 16 Mar 2019 22:39:37 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-28.brq.redhat.com [10.40.204.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACDE71001E61; Sat, 16 Mar 2019 22:39:32 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini Date: Sat, 16 Mar 2019 23:39:14 +0100 Message-Id: <20190316223918.11917-2-philmd@redhat.com> In-Reply-To: <20190316223918.11917-1-philmd@redhat.com> References: <20190316223918.11917-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 16 Mar 2019 22:39:37 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/5] hw/isa/Kconfig: PIIX4 southbridge requires USB UHCI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , David Hildenbrand , Aleksandar Rikalo , Aleksandar Markovic , Helge Deller , Cornelia Huck , Mark Cave-Ayland , Eduardo Habkost , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This fixes when configuring with --without-default-devices: $ qemu-system-mips64 -M malta --nodefaults -bios /dev/null qemu-system-mips64: Unknown device 'piix4-usb-uhci' for bus 'PCI' Aborted (core dumped) (gdb) bt #0 0x00007ffff5a4353f in __GI_raise (sig=3Dsig@entry=3D6) at ../sysdeps/= unix/sysv/linux/raise.c:50 #1 0x00007ffff5a2d895 in __GI_abort () at abort.c:79 #2 0x00005555558745c3 in qdev_create (bus=3Dbus@entry=3D0x555556336260, = name=3Dname@entry=3D0x555555b13a4d "piix4-usb-uhci") at hw/core/qdev.c:131 #3 0x00005555558cb3e1 in pci_create_multifunction (bus=3Dbus@entry=3D0x5= 55556336260, devfn=3Ddevfn@entry=3D82, multifunction=3Dmultifunction@entry= =3Dfalse, name=3Dname@entry=3D0x555555b13a4d "piix4-usb-uhci") at hw/pci/pc= i.c:2104 #4 0x00005555558cb88b in pci_create_simple_multifunction (name=3Dname@en= try=3D0x555555b13a4d "piix4-usb-uhci", multifunction=3Dfalse, devfn=3Ddevfn= @entry=3D82, bus=3Dbus@entry=3D0x555556336260) at hw/pci/pci.c:2126 #5 0x00005555558cb88b in pci_create_simple (bus=3Dbus@entry=3D0x55555633= 6260, devfn=3Ddevfn@entry=3D82, name=3Dname@entry=3D0x555555b13a4d "piix4-u= sb-uhci") at hw/pci/pci.c:2126 #6 0x000055555575ea38 in mips_malta_init (machine=3D0x555555ffe430) at h= w/mips/mips_malta.c:1392 #7 0x000055555587bf2b in machine_run_board_init (machine=3D0x555555ffe43= 0) at hw/core/machine.c:1030 Fixes: 7c28b925b7e Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 57e09a0cb8..c942b47d03 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -29,6 +29,7 @@ config PIIX4 # For historical reasons, SuperIO devices are created in the board # for PIIX4. select ISA_BUS + select USB_UHCI =20 config VT82C686 bool --=20 2.20.1 From nobody Wed May 8 17:18:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552776100047603.0207379541821; Sat, 16 Mar 2019 15:41:40 -0700 (PDT) Received: from localhost ([127.0.0.1]:47385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Hzk-0005gp-Dm for importer@patchew.org; Sat, 16 Mar 2019 18:41:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Hxx-0004WR-8w for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5Hxw-0002El-8H for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55986) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5Hxv-0002ES-U8; Sat, 16 Mar 2019 18:39:44 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AB043084212; Sat, 16 Mar 2019 22:39:43 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-28.brq.redhat.com [10.40.204.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 255C61001E61; Sat, 16 Mar 2019 22:39:37 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini Date: Sat, 16 Mar 2019 23:39:15 +0100 Message-Id: <20190316223918.11917-3-philmd@redhat.com> In-Reply-To: <20190316223918.11917-1-philmd@redhat.com> References: <20190316223918.11917-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Sat, 16 Mar 2019 22:39:43 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 2/5] hw/isa/Kconfig: VT82C686 southbridge requires USB UHCI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , David Hildenbrand , Aleksandar Rikalo , Aleksandar Markovic , Helge Deller , Cornelia Huck , Mark Cave-Ayland , Eduardo Habkost , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This fixes when configuring with --without-default-devices: $ qemu-system-mips64 -M malta --nodefaults -bios /dev/null qemu-system-mips64el: Unknown device 'vt82c686b-usb-uhci' for bus 'PCI' Aborted (core dumped) (gdb) bt #1 0x00007ffff5a2d895 in __GI_abort () at abort.c:79 #2 0x00005555558745c3 in qdev_create (bus=3Dbus@entry=3D0x55555623d160, = name=3Dname@entry=3D0x555555b13ee8 "vt82c686b-usb-uhci") at hw/core/qdev.c:= 131 #3 0x00005555558cb3e1 in pci_create_multifunction (bus=3Dbus@entry=3D0x5= 5555623d160, devfn=3Ddevfn@entry=3D42, multifunction=3Dmultifunction@entry= =3Dfalse, name=3Dname@entry=3D0x555555b13ee8 "vt82c686b-usb-uhci") at hw/pc= i/pci.c:2104 #4 0x00005555558cb88b in pci_create_simple_multifunction (name=3Dname@en= try=3D0x555555b13ee8 "vt82c686b-usb-uhci", multifunction=3Dfalse, devfn=3Dd= evfn@entry=3D42, bus=3Dbus@entry=3D0x55555623d160) at hw/pci/pci.c:2126 #5 0x00005555558cb88b in pci_create_simple (bus=3Dbus@entry=3D0x55555623= d160, devfn=3Ddevfn@entry=3D42, name=3Dname@entry=3D0x555555b13ee8 "vt82c68= 6b-usb-uhci") at hw/pci/pci.c:2126 #6 0x0000555555760d18 in vt82c686b_southbridge_init (slot=3D5, p_isa_bus= =3D, i2c_bus=3D, intc=3D, pci_bus=3D0x55555623d160) at hw/mips/mips_fulong2e.c:243 #7 0x0000555555760d18 in mips_fulong2e_init (machine=3D) = at hw/mips/mips_fulong2e.c:348 #8 0x000055555587bf2b in machine_run_board_init (machine=3D0x555555ffe43= 0) at hw/core/machine.c:1030 Fixes: 7c28b925b7e Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index c942b47d03..1bb5ccdba7 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -35,6 +35,7 @@ config VT82C686 bool select ISA_BUS select ACPI_SMBUS + select USB_UHCI select SERIAL_ISA select FDC =20 --=20 2.20.1 From nobody Wed May 8 17:18:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552776337139415.7794525559584; Sat, 16 Mar 2019 15:45:37 -0700 (PDT) Received: from localhost ([127.0.0.1]:47458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5I3Y-0000SY-7j for importer@patchew.org; Sat, 16 Mar 2019 18:45:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HyA-0004kY-5U for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5Hy8-0002LZ-U4 for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50390) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5Hy8-0002L3-Hg; Sat, 16 Mar 2019 18:39:56 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C1B5307D910; Sat, 16 Mar 2019 22:39:55 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-28.brq.redhat.com [10.40.204.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F4281001DDE; Sat, 16 Mar 2019 22:39:43 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini Date: Sat, 16 Mar 2019 23:39:16 +0100 Message-Id: <20190316223918.11917-4-philmd@redhat.com> In-Reply-To: <20190316223918.11917-1-philmd@redhat.com> References: <20190316223918.11917-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Sat, 16 Mar 2019 22:39:55 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 3/5] hw/isa/Kconfig: i82378 SuperIO requires PC speaker device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , David Hildenbrand , Aleksandar Rikalo , Aleksandar Markovic , Helge Deller , Cornelia Huck , Mark Cave-Ayland , Eduardo Habkost , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This fixes when configuring with --without-default-devices: $ qemu-system-ppc -M prep --nodefaults qemu-system-ppc: Machine type 'prep' is deprecated: use 40p machine type = instead qemu-system-ppc: Unknown device 'isa-pcspk' for bus 'ISA' Aborted (core dumped) (gdb) bt #1 0x00007ffff5a11895 in __GI_abort () at abort.c:79 #2 0x0000555555845db3 in qdev_create (bus=3D0x55555641e360, name=3Dname@= entry=3D0x555555b1f338 "isa-pcspk") at hw/core/qdev.c:131 #3 0x000055555586b03e in isa_create (bus=3Dbus@entry=3D0x55555641e360, n= ame=3Dname@entry=3D0x555555b1f338 "isa-pcspk") at hw/isa/isa-bus.c:162 #4 0x000055555586bf7b in pcspk_init (pit=3D0x5555561696b0, bus=3D0x55555= 641e360) at include/hw/audio/pcspk.h:38 #5 0x000055555586bf7b in i82378_realize (pci=3D, errp=3D0= x7fffffffc960) at hw/isa/i82378.c:104 #6 0x000055555587e288 in pci_qdev_realize (qdev=3D0x55555641be60, errp= =3D) at hw/pci/pci.c:2076 #7 0x0000555555846fb4 in device_set_realized (obj=3D, val= ue=3D, errp=3D0x7fffffffcaf0) at hw/core/qdev.c:834 #8 0x00005555559273f7 in property_set_bool (obj=3D0x55555641be60, v=3D, name=3D, opaque=3D0x5555563df1c0, errp=3D0x7f= ffffffcaf0) at qom/object.c:2074 #9 0x000055555592ba1f in object_property_set_qobject (obj=3Dobj@entry=3D= 0x55555641be60, value=3Dvalue@entry=3D0x55555641d2b0, name=3Dname@entry=3D0= x555555b17175 "realized", errp=3Derrp@entry=3D0x7fffffffcaf0) at qom/qom-qo= bject.c:27 #10 0x0000555555929355 in object_property_set_bool (obj=3D0x55555641be60,= value=3D, name=3D0x555555b17175 "realized", errp=3D0x7fffff= ffcaf0) at qom/object.c:1332 #11 0x0000555555845f42 in qdev_init_nofail (dev=3Ddev@entry=3D0x55555641b= e60) at hw/core/qdev.c:321 #12 0x000055555587ce06 in pci_create_simple_multifunction (name=3Dname@en= try=3D0x555555b1f346 "i82378", multifunction=3Dfalse, devfn=3Ddevfn@entry= =3D8, bus=3Dbus@entry=3D0x55555628cfe8) at hw/pci/pci.c:2115 #13 0x000055555587ce06 in pci_create_simple (bus=3Dbus@entry=3D0x55555628= cfe8, devfn=3Ddevfn@entry=3D8, name=3Dname@entry=3D0x555555b1f346 "i82378")= at hw/pci/pci.c:2126 #14 0x000055555575e62c in ppc_prep_init (machine=3D0x55555609af00) at hw/= ppc/prep.c:516 #15 0x000055555584d57b in machine_run_board_init (machine=3D0x55555609af0= 0) at hw/core/machine.c:1030 Fixes: dd0ff8191ab Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 1bb5ccdba7..b40075df89 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -11,6 +11,7 @@ config I82378 select I8254 select I82374 select MC146818RTC + select PCSPK =20 config PC87312 bool --=20 2.20.1 From nobody Wed May 8 17:18:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552776118083775.422730472617; Sat, 16 Mar 2019 15:41:58 -0700 (PDT) Received: from localhost ([127.0.0.1]:47389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5I03-0005w7-01 for importer@patchew.org; Sat, 16 Mar 2019 18:41:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HyF-0004oa-9u for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5HyE-0002Nr-3Z for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:40:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52996) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5HyD-0002Nc-P9; Sat, 16 Mar 2019 18:40:02 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5D00C057E68; Sat, 16 Mar 2019 22:40:00 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-28.brq.redhat.com [10.40.204.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F26C81001E61; Sat, 16 Mar 2019 22:39:55 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini Date: Sat, 16 Mar 2019 23:39:17 +0100 Message-Id: <20190316223918.11917-5-philmd@redhat.com> In-Reply-To: <20190316223918.11917-1-philmd@redhat.com> References: <20190316223918.11917-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sat, 16 Mar 2019 22:40:01 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 4/5] hw/mips/Kconfig: Fulong 2e board requires ati-vga display device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , David Hildenbrand , Aleksandar Rikalo , Aleksandar Markovic , Helge Deller , Cornelia Huck , Mark Cave-Ayland , Eduardo Habkost , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This fixes when configuring with --without-default-devices: $ qemu-system-mips64el -M fulong2e --nodefaults -bios /dev/null qemu-system-mips64el: Unknown device 'ati-vga' for bus 'PCI' Aborted (core dumped) (gdb) bt #1 0x00007ffff5a11895 in __GI_abort () at abort.c:79 #2 0x00005555558768d3 in qdev_create (bus=3Dbus@entry=3D0x5555562664b0, = name=3Dname@entry=3D0x555555b24efb "ati-vga") at hw/core/qdev.c:131 #3 0x00005555558d15e1 in pci_create_multifunction (bus=3Dbus@entry=3D0x5= 555562664b0, devfn=3Ddevfn@entry=3D-1, multifunction=3Dmultifunction@entry= =3Dfalse, name=3Dname@entry=3D0x555555b24efb "ati-vga") at hw/pci/pci.c:2104 #4 0x00005555558d1a7a in pci_create (bus=3Dbus@entry=3D0x5555562664b0, d= evfn=3Ddevfn@entry=3D-1, name=3Dname@entry=3D0x555555b24efb "ati-vga") at h= w/pci/pci.c:2121 #5 0x0000555555763081 in mips_fulong2e_init (machine=3D) = at hw/mips/mips_fulong2e.c:352 #6 0x000055555587e23b in machine_run_board_init (machine=3D0x5555560b200= 0) at hw/core/machine.c:1030 Fixes: 862b4a291dc Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- default-configs/mips64el-softmmu.mak | 2 ++ 1 file changed, 2 insertions(+) diff --git a/default-configs/mips64el-softmmu.mak b/default-configs/mips64e= l-softmmu.mak index 8b255efc54..a67c9517a2 100644 --- a/default-configs/mips64el-softmmu.mak +++ b/default-configs/mips64el-softmmu.mak @@ -6,6 +6,8 @@ CONFIG_RC4030=3Dy CONFIG_DP8393X=3Dy CONFIG_DS1225Y=3Dy CONFIG_FULONG=3Dy +CONFIG_ATI_VGA=3Dy +CONFIG_RTL8139_PCI=3Dy CONFIG_JAZZ=3Dy CONFIG_G364FB=3Dy CONFIG_JAZZ_LED=3Dy --=20 2.20.1 From nobody Wed May 8 17:18:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552776414162680.3426619481212; Sat, 16 Mar 2019 15:46:54 -0700 (PDT) Received: from localhost ([127.0.0.1]:47469 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5I4o-0001Aw-8X for importer@patchew.org; Sat, 16 Mar 2019 18:46:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HyS-00055a-DT for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:40:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5HyR-0002XW-5n for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:40:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50452) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5HyQ-0002XH-Re; Sat, 16 Mar 2019 18:40:15 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01490307D910; Sat, 16 Mar 2019 22:40:14 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-28.brq.redhat.com [10.40.204.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 640531001E61; Sat, 16 Mar 2019 22:40:01 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini Date: Sat, 16 Mar 2019 23:39:18 +0100 Message-Id: <20190316223918.11917-6-philmd@redhat.com> In-Reply-To: <20190316223918.11917-1-philmd@redhat.com> References: <20190316223918.11917-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Sat, 16 Mar 2019 22:40:14 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 5/5] hw/sparc/Kconfig: SPARCstation machine requires the TCX display X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , David Hildenbrand , Aleksandar Rikalo , Aleksandar Markovic , Helge Deller , Cornelia Huck , Mark Cave-Ayland , Eduardo Habkost , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno , David Gibson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This is the default display device used in sun4m_hw_init(): /* If no display specified, default to TCX */ This fixes when configuring with --without-default-devices: $ sparc-softmmu/qemu-system-sparc --nodefaults qemu-system-sparc: Unknown device 'SUNW,tcx' for default sysbus Aborted (core dumped) (gdb) bt #0 0x00007fc78d19353f in __GI_raise (sig=3Dsig@entry=3D6) at ../sysdeps/= unix/sysv/linux/raise.c:50 #1 0x00007fc78d17d895 in __GI_abort () at abort.c:79 #2 0x0000560beaf637f3 in qdev_create (bus=3Dbus@entry=3D0x0, name=3Dname= @entry=3D0x560beb1be36b "SUNW,tcx") at hw/core/qdev.c:131 #3 0x0000560beaf1392d in tcx_init (vram_size=3D1048576, width=3D1024, he= ight=3D768, depth=3D8, irq=3D0x560bed1a0230, addr=3D1342177280) at hw/sparc= /sun4m.c:477 #4 0x0000560beaf1392d in sun4m_hw_init (hwdef=3D0x560beb1be780 , machine=3D0x560becf65f00) at hw/sparc/sun4m.c:943 #5 0x0000560beaf6b15b in machine_run_board_init (machine=3D0x560becf65f0= 0) at hw/core/machine.c:1030 Fixes: 8c75eec06d4 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- default-configs/sparc-softmmu.mak | 1 - hw/sparc/Kconfig | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/default-configs/sparc-softmmu.mak b/default-configs/sparc-soft= mmu.mak index ee85218115..56509bf263 100644 --- a/default-configs/sparc-softmmu.mak +++ b/default-configs/sparc-softmmu.mak @@ -2,7 +2,6 @@ =20 # Uncomment the following lines to disable these optional devices: # -#CONFIG_TCX=3Dn #CONFIG_CG3=3Dn =20 # Boards: diff --git a/hw/sparc/Kconfig b/hw/sparc/Kconfig index 2a83a8010e..5383dbd910 100644 --- a/hw/sparc/Kconfig +++ b/hw/sparc/Kconfig @@ -1,6 +1,6 @@ config SUN4M bool - imply TCX + select TCX imply CG3 select CS4231 select ECCMEMCTL --=20 2.20.1