From nobody Mon Feb 9 09:33:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552747362275798.0899226379507; Sat, 16 Mar 2019 07:42:42 -0700 (PDT) Received: from localhost ([127.0.0.1]:42666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5AWF-0007H6-5m for importer@patchew.org; Sat, 16 Mar 2019 10:42:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5AOp-00019c-MF for qemu-devel@nongnu.org; Sat, 16 Mar 2019 10:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5AOn-0000lm-6K for qemu-devel@nongnu.org; Sat, 16 Mar 2019 10:34:59 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37471) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5AOl-0000k5-9z for qemu-devel@nongnu.org; Sat, 16 Mar 2019 10:34:55 -0400 Received: by mail-wm1-x341.google.com with SMTP id v14so67814wmf.2 for ; Sat, 16 Mar 2019 07:34:54 -0700 (PDT) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id l8sm7518895wrv.45.2019.03.16.07.34.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Mar 2019 07:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oiO5oNvvyneKbtGtvgIPhk2yPowBzz1y7czxQX6rDtY=; b=Qa2yXGSZdh0vrrTobGdhZ8rl2ZaH/iEJAxh6iFxYqEXUJdoAwsiS8LKis/I7vyV7ht aAoWKmTKQaEEJaA1X7v1D+0hdWyRPbvxv8y9/Zf4YHvKBvEj4dhTV+IxJI+WLJRvKkQ1 rvQeIq7pdrPLy9PgJPr7VAKHbJATmUzbIS36+7vYxpI8nxZcvUkiRE9AjOCeEGpxFObm 0kWT0JywSvwjY52RtCcj+njE0K5zstOxg1HbI2OGm3Ao3ZNVDH+svyrm5opNtUdZT1DB C3Xmfy6yzqpkiqFGmRYIpszQ3/xwXp8hOGkkuO9ZEZYbh66Xst2anBdXKfd7Z/Byg96E mCEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oiO5oNvvyneKbtGtvgIPhk2yPowBzz1y7czxQX6rDtY=; b=s2JGBcBGGHSn1TuU+hJJv1RsrhfENwLPQRP02deqvhT4ZQ+iYYb1+TldaxbGtQ9dtl kf9u/+bkxtz3wyA69iM0+QXKBwpAoeap7MozKPVL6ro5zeYOB+1sGLVbiwmhD2Pcs/l6 yL8lD+7Q4kG4v3kTqZLXqQVHPIqILslOwIlLqmzo8FiFRmPwgLeuTq1Kgigjr9FXTXnD E/KLXqoKtjXgXTOrP8IWzp6ChjqkktoohYmFUIL6L0Rl0WrMc6VPoOzKI4uz8MsIKYiM p7/lhnPteKp6VlAWY4a8XgR5VaUQ4sXjNdGieTmEtyuWBVKGX4XP4tgX8maOSqVq6E4M KTAQ== X-Gm-Message-State: APjAAAX8V9Au2Cd5frXSGSDG8pJ6tjs5fzTYn81g+nqXQg4frei51EPA p4sz8bsXlHOhhI3oF0bl9qWY//Qy X-Google-Smtp-Source: APXvYqxB3jcYyI0iGwKM1IxJT1mUuM8rhv+/5orT92CwTi6xf+oDsfM64zlpjvfnBE9NQGreb/GkTQ== X-Received: by 2002:a1c:4b18:: with SMTP id y24mr5443758wma.111.1552746892853; Sat, 16 Mar 2019 07:34:52 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 16 Mar 2019 16:34:19 +0200 Message-Id: <20190316143421.8194-17-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190316143421.8194-1-marcel.apfelbaum@gmail.com> References: <20190316143421.8194-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH PULL 16/18] hw/rdma: Use {} instead of {0} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, kamalheib1@gmail.com, yuval.shaia@oracle.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Kamal Heib Initialize structs with {} instead of {0} to make sure that all code is using the same convention. Reviewed-by: Marcel Apfelbaum Signed-off-by: Kamal Heib Reviewed-by: Yuval Shaia Message-Id: <20190314153031.7197-4-kamalheib1@gmail.com> Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 18 +++++++++--------- hw/rdma/vmw/pvrdma_cmd.c | 2 +- hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 90983d2846..d1660b6474 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -57,7 +57,7 @@ static void dummy_comp_handler(void *ctx, struct ibv_wc *= wc) static inline void complete_work(enum ibv_wc_status status, uint32_t vendo= r_err, void *ctx) { - struct ibv_wc wc =3D {0}; + struct ibv_wc wc =3D {}; =20 wc.status =3D status; wc.vendor_err =3D vendor_err; @@ -273,7 +273,7 @@ static void stop_backend_thread(RdmaBackendThread *thre= ad) =20 static void start_comp_thread(RdmaBackendDev *backend_dev) { - char thread_name[THR_NAME_LEN] =3D {0}; + char thread_name[THR_NAME_LEN] =3D {}; =20 stop_backend_thread(&backend_dev->comp_thread); =20 @@ -483,7 +483,7 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev, struct ibv_sge new_sge[MAX_SGE]; uint32_t bctx_id; int rc; - struct ibv_send_wr wr =3D {0}, *bad_wr; + struct ibv_send_wr wr =3D {}, *bad_wr; =20 if (!qp->ibqp) { /* This field is not initialized for QP0 and QP1 */ if (qp_type =3D=3D IBV_QPT_SMI) { @@ -600,7 +600,7 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev, struct ibv_sge new_sge[MAX_SGE]; uint32_t bctx_id; int rc; - struct ibv_recv_wr wr =3D {0}, *bad_wr; + struct ibv_recv_wr wr =3D {}, *bad_wr; =20 if (!qp->ibqp) { /* This field does not get initialized for QP0 and QP= 1 */ if (qp_type =3D=3D IBV_QPT_SMI) { @@ -737,7 +737,7 @@ int rdma_backend_create_qp(RdmaBackendQP *qp, uint8_t q= p_type, uint32_t max_recv_wr, uint32_t max_send_sge, uint32_t max_recv_sge) { - struct ibv_qp_init_attr attr =3D {0}; + struct ibv_qp_init_attr attr =3D {}; =20 qp->ibqp =3D 0; =20 @@ -782,7 +782,7 @@ int rdma_backend_create_qp(RdmaBackendQP *qp, uint8_t q= p_type, int rdma_backend_qp_state_init(RdmaBackendDev *backend_dev, RdmaBackendQP = *qp, uint8_t qp_type, uint32_t qkey) { - struct ibv_qp_attr attr =3D {0}; + struct ibv_qp_attr attr =3D {}; int rc, attr_mask; =20 attr_mask =3D IBV_QP_STATE | IBV_QP_PKEY_INDEX | IBV_QP_PORT; @@ -821,7 +821,7 @@ int rdma_backend_qp_state_rtr(RdmaBackendDev *backend_d= ev, RdmaBackendQP *qp, union ibv_gid *dgid, uint32_t dqpn, uint32_t rq_psn, uint32_t qkey, bool use_qke= y) { - struct ibv_qp_attr attr =3D {0}; + struct ibv_qp_attr attr =3D {}; union ibv_gid ibv_gid =3D { .global.interface_id =3D dgid->global.interface_id, .global.subnet_prefix =3D dgid->global.subnet_prefix @@ -880,7 +880,7 @@ int rdma_backend_qp_state_rtr(RdmaBackendDev *backend_d= ev, RdmaBackendQP *qp, int rdma_backend_qp_state_rts(RdmaBackendQP *qp, uint8_t qp_type, uint32_t sq_psn, uint32_t qkey, bool use_qke= y) { - struct ibv_qp_attr attr =3D {0}; + struct ibv_qp_attr attr =3D {}; int rc, attr_mask; =20 attr.qp_state =3D IBV_QPS_RTS; @@ -1012,7 +1012,7 @@ static void process_incoming_mad_req(RdmaBackendDev *= backend_dev, complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_MAD_BUFF, bctx->up_ctx); } else { - struct ibv_wc wc =3D {0}; + struct ibv_wc wc =3D {}; memset(mad, 0, bctx->sge.length); build_mad_hdr((struct ibv_grh *)mad, (union ibv_gid *)&msg->umad.hdr.addr.gid, &msg->hdr.= sgid, diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 6d56746357..b682e919d5 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -123,7 +123,7 @@ static int query_port(PVRDMADev *dev, union pvrdma_cmd_= req *req, { struct pvrdma_cmd_query_port *cmd =3D &req->query_port; struct pvrdma_cmd_query_port_resp *resp =3D &rsp->query_port_resp; - struct pvrdma_port_attr attrs =3D {0}; + struct pvrdma_port_attr attrs =3D {}; =20 if (cmd->port_num > MAX_PORTS) { return -EINVAL; diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 508d8fca3c..5b9786efbe 100644 --- a/hw/rdma/vmw/pvrdma_qp_ops.c +++ b/hw/rdma/vmw/pvrdma_qp_ops.c @@ -114,7 +114,7 @@ static void pvrdma_qp_ops_comp_handler(void *ctx, struc= t ibv_wc *wc) =20 static void complete_with_error(uint32_t vendor_err, void *ctx) { - struct ibv_wc wc =3D {0}; + struct ibv_wc wc =3D {}; =20 wc.status =3D IBV_WC_GENERAL_ERR; wc.vendor_err =3D vendor_err; --=20 2.17.1