From nobody Sat May 4 20:46:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ao2.it Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552674376256501.91596107191026; Fri, 15 Mar 2019 11:26:16 -0700 (PDT) Received: from localhost ([127.0.0.1]:59650 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4rX3-0006bv-8H for importer@patchew.org; Fri, 15 Mar 2019 14:26:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4r26-0004zk-LJ for qemu-devel@nongnu.org; Fri, 15 Mar 2019 13:54:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4qyI-0005pf-18 for qemu-devel@nongnu.org; Fri, 15 Mar 2019 13:50:18 -0400 Received: from mail.ao2.it ([2001:4b98:dc0:41:216:3eff:fe7c:639b]:39759 helo=ao2.it) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4qyH-0005nj-Ii for qemu-devel@nongnu.org; Fri, 15 Mar 2019 13:50:17 -0400 Received: from localhost ([::1] helo=jcn) by ao2.it with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1h4qxw-0000E9-47; Fri, 15 Mar 2019 18:49:56 +0100 Received: from ao2 by jcn with local (Exim 4.92) (envelope-from ) id 1h4qy9-0000rb-24; Fri, 15 Mar 2019 18:50:09 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ao2.it; s=20180927; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=6q4/KnmMqbC+W4jg1SqvkmTr98JrJiK5TXHCO3Xoccg=; b=JrTqyIoRhSpaALEBGfNIFqhIZyLqZZB9STPgv0ksBB3DwNWTF1JGAGVcaF83TxWxWSoMThMVw6FKr8mXMuLNym4G96j68PgLiygR1rLfY8ACUbhcAxrkMeImAe9SINUehf1bCYjzBBoeZio/XTVg2QC3pgzK8WNF2KulKEwjJnXpjEbpaUuiK375q/i47nD4cGiDLT9PWC+tzFn42EgEB3ls66BArhV4vfbG3bo/wwfhsY/QpFN9/+lbbOQFcFVW6ebh3j5iEyze5n5bBoSPvaFUSJERw6DN39NzEdUWxe9HxlD7y/NDqsWYcP7oNVsmobzEEyJKelWbCPbtCXb/hw==; From: Antonio Ospite To: qemu-devel@nongnu.org Date: Fri, 15 Mar 2019 18:50:05 +0100 Message-Id: <20190315175005.3279-1-ao2@ao2.it> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Face: z*RaLf`X<@C75u6Ig9}{oW$H; 1_\2t5)({*|jhM/Vb; ]yA5\I~93>J<_`<4)A{':UrE Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4b98:dc0:41:216:3eff:fe7c:639b X-Mailman-Approved-At: Fri, 15 Mar 2019 14:25:22 -0400 Subject: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Ospite Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Antonio Ospite The configure script breaks when the qemu source directory is in a path containing white spaces, in particular the list of targets is not correctly generated when calling "./configure --help". To avoid this issue, refuse to run the configure script if there are spaces or colons in the source path, this is also what kbuild from linux does. Buglink: https://bugs.launchpad.net/qemu/+bug/1817345 Signed-off-by: Antonio Ospite --- configure | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 7071f52584..fbd70a0f51 100755 --- a/configure +++ b/configure @@ -295,6 +295,11 @@ libs_qga=3D"" debug_info=3D"yes" stack_protector=3D"" =20 +if printf "%s" "$(realpath "$source_path")" | grep -q "[[:space:]:]"; +then + error_exit "main directory cannot contain spaces nor colons" +fi + if test -e "$source_path/.git" then git_update=3Dyes --=20 2.20.1