From nobody Tue Feb 10 02:54:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552639865037870.1406259266605; Fri, 15 Mar 2019 01:51:05 -0700 (PDT) Received: from localhost ([127.0.0.1]:51984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iYO-0000yE-Lx for importer@patchew.org; Fri, 15 Mar 2019 04:51:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iUb-0006vi-TI for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4iUY-0001B1-7A for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:04 -0400 Received: from [2a01:4f8:141:20d3::2] (port=58394 helo=zapp.schrodt.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4iUW-00017B-41 for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:01 -0400 Received: from schapa.schrodt.org ([46.237.225.84]:39902 helo=zoidberg.machine.schrodt.org) by zapp.schrodt.org with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1h4iUQ-0000zQ-8V; Fri, 15 Mar 2019 09:46:54 +0100 Received: from spheenik by zoidberg.machine.schrodt.org with local (Exim 4.92) (envelope-from ) id 1h4iUQ-000VH2-0A; Fri, 15 Mar 2019 09:46:54 +0100 From: Martin Schrodt To: qemu-devel@nongnu.org Date: Fri, 15 Mar 2019 09:46:53 +0100 Message-Id: <20190315084653.120020-4-martin@schrodt.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190315084653.120020-1-martin@schrodt.org> References: <20190315084653.120020-1-martin@schrodt.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:141:20d3::2 Subject: [Qemu-devel] [PATCH V4 3/3] audio/paaudio: fix microphone input being unusable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index be27c73f09..45295b4e5e 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -605,6 +605,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsetting= s *as, void *drv_opaque) { int error; pa_sample_spec ss; + pa_buffer_attr ba; struct audsettings obt_as =3D *as; PAVoiceIn *pa =3D (PAVoiceIn *) hw; paaudio *g =3D pa->g =3D drv_opaque; @@ -615,6 +616,11 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettin= gs *as, void *drv_opaque) ss.channels =3D as->nchannels; ss.rate =3D as->freq; =20 + ba.fragsize =3D pa_usec_to_bytes(ppdo->latency, &ss); + ba.maxlength =3D -1; + ba.minreq =3D -1; + ba.prebuf =3D -1; + obt_as.fmt =3D pa_to_audfmt (ss.format, &obt_as.endianness); =20 pa->stream =3D qpa_simple_new ( @@ -624,7 +630,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsetting= s *as, void *drv_opaque) ppdo->has_name ? ppdo->name : NULL, &ss, NULL, /* channel map */ - NULL, /* buffering attributes */ + &ba, /* buffering attributes */ &error ); if (!pa->stream) { --=20 2.21.0