From nobody Tue Apr 23 15:51:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155258212394493.7724944579187; Thu, 14 Mar 2019 09:48:43 -0700 (PDT) Received: from localhost ([127.0.0.1]:41459 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4TWy-0005ru-TW for importer@patchew.org; Thu, 14 Mar 2019 12:48:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4TPd-0000QO-Dh for qemu-devel@nongnu.org; Thu, 14 Mar 2019 12:41:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4TGW-0005g8-Od for qemu-devel@nongnu.org; Thu, 14 Mar 2019 12:31:33 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:43830) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4TGV-0005fA-OH for qemu-devel@nongnu.org; Thu, 14 Mar 2019 12:31:32 -0400 Received: by mail-pf1-x436.google.com with SMTP id q17so4183969pfh.10 for ; Thu, 14 Mar 2019 09:31:31 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id s79sm27666621pfa.61.2019.03.14.09.31.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 09:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=dX8h+OIFfP5F+uc8EqaqvTklaR3Uxsr71AJmU2rig7c=; b=Dm5wyBnuhKmn2B8gvhhW0D40S8VHT7jkJj90tZCrXecILS5pCnN6F9qwT9Kh2L9e5N +h7PY/he6FjcUCHljKmMiTiPAwLqjhRhhtq1zGcP3Lel1Oh7ncymbebnEhVFM1b+6SrO ElwQBWiePNPV+spy7W842AVP3zGV7Jp0Ie9G4ls7Bvl9O0Yh1PLHWe6/iUY6lgnbvjCk 8bkTnabAlHF4/x2JWNmakO+q38IHqWZRDjITFxslAJ4P0QC/kenikdGxbz3O0dabBTwW rkr3ORzinake3kuvzdRTCT6lR7HvayeQUHfKshlE4P8ST0/Z8zahMiiuVjpFbVj/J8TA RDhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dX8h+OIFfP5F+uc8EqaqvTklaR3Uxsr71AJmU2rig7c=; b=cEWIzlA7T3HHzlimPLS3wOqQHqwDy7g2Oxzlj+Ayvm3YRX/xg3/rntC5PrtBXxqOuw 68SBSZHfkoxJs8mlJ+20AKjoepdYcMi9wvU5r2QROgd5x0UETMUpLgjU7hiknc+nQBCk HCekPvqFOqAtyetRUbxh9jYt3glzTl9RwWuWpOnD4qp2uLgk8/f73vxEsgYF1mAzb2uA KCoaGD8269QhDb7DYY6zjdXzRLBJHXa4FUxt2J3NVLDUQFlYM2aNNNsdxBlx4cQ/vVgi KvNcT2AlEtC0xmlcqG550m6yCdJfRzeOvfyUC7eqyPffCgCJYgwioEJ7/wTE3sl0rF1e 7YgQ== X-Gm-Message-State: APjAAAX8+YUSe360Iea2f0jtuYN+axS9AxJPzNgGlKywsHxacbbZPceB 2+lB6VAkIyJJjLalXHibppEy1DDEMXM= X-Google-Smtp-Source: APXvYqyF6qe5Q8HbeBk0XcJhsMEmhb7nxmTTeqkqpmiNhE4JGZDVb9zWNtULEPwp32fsN63QEMCyFA== X-Received: by 2002:a63:2c50:: with SMTP id s77mr29049403pgs.440.1552581090204; Thu, 14 Mar 2019 09:31:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 14 Mar 2019 09:31:27 -0700 Message-Id: <20190314163127.2980-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::436 Subject: [Qemu-devel] [PATCH for-4.0] target/arm: Add sve_access_check to ADDVL, ADDPL, RDVL X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This failed to trap when required, which allowed an EL0 guest to execute with inconsistent data loaded into ZCR_EL1. Reported-by: Amir Charif Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- target/arm/translate-sve.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 3a2eb51566..245cd82621 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -943,24 +943,30 @@ static bool trans_INDEX_rr(DisasContext *s, arg_INDEX= _rr *a) =20 static bool trans_ADDVL(DisasContext *s, arg_ADDVL *a) { - TCGv_i64 rd =3D cpu_reg_sp(s, a->rd); - TCGv_i64 rn =3D cpu_reg_sp(s, a->rn); - tcg_gen_addi_i64(rd, rn, a->imm * vec_full_reg_size(s)); + if (sve_access_check(s)) { + TCGv_i64 rd =3D cpu_reg_sp(s, a->rd); + TCGv_i64 rn =3D cpu_reg_sp(s, a->rn); + tcg_gen_addi_i64(rd, rn, a->imm * vec_full_reg_size(s)); + } return true; } =20 static bool trans_ADDPL(DisasContext *s, arg_ADDPL *a) { - TCGv_i64 rd =3D cpu_reg_sp(s, a->rd); - TCGv_i64 rn =3D cpu_reg_sp(s, a->rn); - tcg_gen_addi_i64(rd, rn, a->imm * pred_full_reg_size(s)); + if (sve_access_check(s)) { + TCGv_i64 rd =3D cpu_reg_sp(s, a->rd); + TCGv_i64 rn =3D cpu_reg_sp(s, a->rn); + tcg_gen_addi_i64(rd, rn, a->imm * pred_full_reg_size(s)); + } return true; } =20 static bool trans_RDVL(DisasContext *s, arg_RDVL *a) { - TCGv_i64 reg =3D cpu_reg(s, a->rd); - tcg_gen_movi_i64(reg, a->imm * vec_full_reg_size(s)); + if (sve_access_check(s)) { + TCGv_i64 reg =3D cpu_reg(s, a->rd); + tcg_gen_movi_i64(reg, a->imm * vec_full_reg_size(s)); + } return true; } =20 --=20 2.17.2