From nobody Mon Feb 9 15:12:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15525399957671022.2671554768433; Wed, 13 Mar 2019 22:06:35 -0700 (PDT) Received: from localhost ([127.0.0.1]:56992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4IZc-0003oo-AV for importer@patchew.org; Thu, 14 Mar 2019 01:06:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4IPB-0004ak-F9 for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4IPA-0007Rt-GH for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:45 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:33575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4IPA-0007RP-7D for qemu-devel@nongnu.org; Thu, 14 Mar 2019 00:55:44 -0400 Received: by mail-pg1-x542.google.com with SMTP id h11so3168991pgl.0 for ; Wed, 13 Mar 2019 21:55:44 -0700 (PDT) Received: from localhost.localdomain (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id d9sm16185027pgq.6.2019.03.13.21.55.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 21:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=I39zQahYJfO4v9BtHWnWSXDEM3G+gAshBbiSOHHVUzY=; b=c4zxkyFcR1EPcjyQUpS85K+hU1gkfAYx9NGMRqQyEC1y1uwU0Ao9Y5MVCSLZorrX6O +gcPAGlmHwsjYSzuEBZDM4A/CzZOdz8a8EPMdoCEYE1TntJsxoFyYLdlwe2aSrPGnFeW PQm8iNoCQpi+MQCFtWNMTvGnSKiRFCnktTjohAOCV3fTgdoMcW1qLbbHYSvkofJyXM1V 1JlJac2v6WluNjf1ywbdMOOCHhlnCOy/HrrOVeAGihrvbxOB1ISB6aZiXeLtmU66bxdc pPXGNUb8TGdlxn+8BL6zOCzxcoYWdW4dQjFASgfLqEROmtmzYMUlqKJ33OaUAjOXixIP q5VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=I39zQahYJfO4v9BtHWnWSXDEM3G+gAshBbiSOHHVUzY=; b=D1mNJttzGOc2eZIjSPZZe+8wMwqtZP1jtlrxYNDblv5R6bo6QF+hTpqDHhM/hdEliM S81XDjJL8fFT31gPGIl0e3tiAikQzrLFUciJwN6vOsY0hfvOBGT45vrUIT5pSCgZTEpj WZVfjNJuEsPqi1w8/vH7L8RnS4g+nerQRcvTJn7zMNgPF+a86kNBosHoaiGW73zNuLdW orn3eXncDDKEbjGkifGzCotRU0HVOlWV78Dv07MNj8UV4Ua+rUdhqYWVuDOrL2UPx9+m IiqEe5ZltzH/b22ahnHC0YQrH7HEKtm74YZvX8kae/yTiTng1UAUyep3m8c9ytd6VUe4 Mp0A== X-Gm-Message-State: APjAAAX2Z/oZ74GBpATaA9/HWWHMfi4KukK6Wj9Cmc2SXUx4WLCyoKQL rn2gpVyLNwkaMh9f5sOTgUootIEtzHo= X-Google-Smtp-Source: APXvYqwVT+PTVW8ZBk8uRPh5NQ1y47wXEh9bgLNZc7Nstsv4atABpcWciAyewNBklmhAOUeKKZDjSg== X-Received: by 2002:a17:902:6b47:: with SMTP id g7mr50367586plt.100.1552539342964; Wed, 13 Mar 2019 21:55:42 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 13 Mar 2019 21:55:24 -0700 Message-Id: <20190314045526.13342-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190314045526.13342-1-richard.henderson@linaro.org> References: <20190314045526.13342-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: [Qemu-devel] [PATCH v2 12/14] linux-user/aarch64: Use qemu_getrandom for arm_init_pauth_key X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use a better interface for random numbers than rand * 3. Cc: Laurent Vivier Cc: Peter Maydell Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/aarch64/cpu_loop.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/linux-user/aarch64/cpu_loop.c b/linux-user/aarch64/cpu_loop.c index d75fd9d3e2..ad30cab52d 100644 --- a/linux-user/aarch64/cpu_loop.c +++ b/linux-user/aarch64/cpu_loop.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "qemu.h" #include "cpu_loop-common.h" +#include "qemu/random.h" =20 #define get_user_code_u32(x, gaddr, env) \ ({ abi_long __r =3D get_user_u32((x), (gaddr)); \ @@ -147,22 +148,9 @@ void cpu_loop(CPUARMState *env) } } =20 -static uint64_t arm_rand64(void) -{ - int shift =3D 64 - clz64(RAND_MAX); - int i, n =3D 64 / shift + (64 % shift !=3D 0); - uint64_t ret =3D 0; - - for (i =3D 0; i < n; i++) { - ret =3D (ret << shift) | rand(); - } - return ret; -} - void arm_init_pauth_key(ARMPACKey *key) { - key->lo =3D arm_rand64(); - key->hi =3D arm_rand64(); + qemu_getrandom(key, sizeof(*key), false); } =20 void target_cpu_copy_regs(CPUArchState *env, struct target_pt_regs *regs) --=20 2.17.1