From nobody Tue Apr 23 15:41:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552512564674380.9084351278925; Wed, 13 Mar 2019 14:29:24 -0700 (PDT) Received: from localhost ([127.0.0.1]:51179 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4BR9-00064O-MS for importer@patchew.org; Wed, 13 Mar 2019 17:29:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4BHB-0006dU-UO for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4BHB-0003s4-28 for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:01 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:49110) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4BHA-0003rH-Pw for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:00 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id ABA42D857; Wed, 13 Mar 2019 22:18:59 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XO6tv6yjtGOq; Wed, 13 Mar 2019 22:18:58 +0100 (CET) Received: from function (105.251.129.77.rev.sfr.net [77.129.251.105]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 983C3D858; Wed, 13 Mar 2019 22:18:58 +0100 (CET) Received: from samy by function with local (Exim 4.92) (envelope-from ) id 1h4BH7-0001qC-4H; Wed, 13 Mar 2019 22:18:57 +0100 X-Virus-Scanned: Debian amavisd-new at aquilenet.fr From: Samuel Thibault To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Wed, 13 Mar 2019 22:18:55 +0100 Message-Id: <20190313211857.7032-2-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190313211857.7032-1-samuel.thibault@ens-lyon.org> References: <20190313211857.7032-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.233.100.1 Subject: [Qemu-devel] [PULL 1/1] configure: remove slirp submodule support that doesn't exist yet X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jan.kiszka@siemens.com, Samuel Thibault , stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 The slirp code is not yet split off into a separate repository, so configuring QEMU to use slirp as a submodule is premature. This causes the non-existant "slirp" to be requested from git when syncing submodules. This in turn appears to be cause of non-deterministic failures some developers are seeing with QEMU's submodule sync process. Signed-off-by: Daniel P. Berrang=C3=A9 Message-Id: <20190313173157.30504-1-berrange@redhat.com> Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Samuel Thibault --- configure | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/configure b/configure index cab830a4c9..355eebfc5d 100755 --- a/configure +++ b/configure @@ -1109,8 +1109,6 @@ for opt do ;; --disable-slirp) slirp=3D"no" ;; - --enable-slirp=3Dgit) slirp=3D"git" - ;; --enable-slirp=3Dsystem) slirp=3D"system" ;; --disable-vde) vde=3D"no" @@ -5780,8 +5778,6 @@ case "$slirp" in "" | yes) if $pkg_config slirp; then slirp=3Dsystem - elif test -e "${source_path}/.git" && test $git_update =3D 'yes' ; then - slirp=3Dgit elif test -e "${source_path}/slirp/Makefile" ; then slirp=3Dinternal elif test -z "$slirp" ; then @@ -5799,10 +5795,7 @@ case "$slirp" in esac =20 case "$slirp" in - git | internal) - if test "$slirp" =3D git; then - git_submodules=3D"${git_submodules} slirp" - fi + internal) mkdir -p slirp slirp_cflags=3D"-I\$(SRC_PATH)/slirp/src -I\$(BUILD_DIR)/slirp/src" slirp_libs=3D"-L\$(BUILD_DIR)/slirp -lslirp" @@ -6464,7 +6457,7 @@ if test "$slirp" !=3D "no"; then echo "SLIRP_CFLAGS=3D$slirp_cflags" >> $config_host_mak echo "SLIRP_LIBS=3D$slirp_libs" >> $config_host_mak fi -if [ "$slirp" =3D "git" -o "$slirp" =3D "internal" ]; then +if [ "$slirp" =3D "internal" ]; then echo "config-host.h: subdir-slirp" >> $config_host_mak fi if test "$vde" =3D "yes" ; then --=20 2.20.1 From nobody Tue Apr 23 15:41:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552512526858421.3652932716361; Wed, 13 Mar 2019 14:28:46 -0700 (PDT) Received: from localhost ([127.0.0.1]:51177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4BQW-0005cf-Ip for importer@patchew.org; Wed, 13 Mar 2019 17:28:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4BHC-0006do-9j for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4BHB-0003sQ-CL for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:02 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:49118) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4BHB-0003rZ-5n for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:01 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 35E4ED858; Wed, 13 Mar 2019 22:19:00 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2LFvfBW5V5AT; Wed, 13 Mar 2019 22:18:59 +0100 (CET) Received: from function (105.251.129.77.rev.sfr.net [77.129.251.105]) by hera.aquilenet.fr (Postfix) with ESMTPSA id AB99FD859; Wed, 13 Mar 2019 22:18:58 +0100 (CET) Received: from samy by function with local (Exim 4.92) (envelope-from ) id 1h4BH7-0001qE-7f; Wed, 13 Mar 2019 22:18:57 +0100 X-Virus-Scanned: Debian amavisd-new at aquilenet.fr From: Samuel Thibault To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Wed, 13 Mar 2019 22:18:56 +0100 Message-Id: <20190313211857.7032-3-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190313211857.7032-1-samuel.thibault@ens-lyon.org> References: <20190313211857.7032-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.233.100.1 Subject: [Qemu-devel] [PULL 1/2] slirp: remove empty state.h X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Samuel Thibault , stefanha@redhat.com, jan.kiszka@siemens.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20190313173949.2369-1-marcandre.lureau@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Samuel Thibault --- slirp/src/state.c | 1 - slirp/src/state.h | 0 2 files changed, 1 deletion(-) delete mode 100644 slirp/src/state.h diff --git a/slirp/src/state.c b/slirp/src/state.c index f5dd80cdc8..c3e3f0b671 100644 --- a/slirp/src/state.c +++ b/slirp/src/state.c @@ -23,7 +23,6 @@ */ #include "slirp.h" #include "vmstate.h" -#include "state.h" #include "stream.h" =20 static int slirp_tcp_post_load(void *opaque, int version) diff --git a/slirp/src/state.h b/slirp/src/state.h deleted file mode 100644 index e69de29bb2..0000000000 --=20 2.20.1 From nobody Tue Apr 23 15:41:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552512619525822.167111290915; Wed, 13 Mar 2019 14:30:19 -0700 (PDT) Received: from localhost ([127.0.0.1]:51188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4BS3-0006kM-IH for importer@patchew.org; Wed, 13 Mar 2019 17:30:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4BHE-0006g8-S8 for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4BHD-0003ut-RX for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:04 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:49132) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4BHD-0003tH-Jc for qemu-devel@nongnu.org; Wed, 13 Mar 2019 17:19:03 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D353AD859; Wed, 13 Mar 2019 22:19:01 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B9bulV3WuvgJ; Wed, 13 Mar 2019 22:18:59 +0100 (CET) Received: from function (105.251.129.77.rev.sfr.net [77.129.251.105]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CC27AD85A; Wed, 13 Mar 2019 22:18:58 +0100 (CET) Received: from samy by function with local (Exim 4.92) (envelope-from ) id 1h4BH7-0001qG-AJ; Wed, 13 Mar 2019 22:18:57 +0100 X-Virus-Scanned: Debian amavisd-new at aquilenet.fr From: Samuel Thibault To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Wed, 13 Mar 2019 22:18:57 +0100 Message-Id: <20190313211857.7032-4-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190313211857.7032-1-samuel.thibault@ens-lyon.org> References: <20190313211857.7032-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.233.100.1 Subject: [Qemu-devel] [PULL 2/2] configure: remove slirp submodule support that doesn't exist yet X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jan.kiszka@siemens.com, Samuel Thibault , stefanha@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 The slirp code is not yet split off into a separate repository, so configuring QEMU to use slirp as a submodule is premature. This causes the non-existant "slirp" to be requested from git when syncing submodules. This in turn appears to be cause of non-deterministic failures some developers are seeing with QEMU's submodule sync process. Signed-off-by: Daniel P. Berrang=C3=A9 Message-Id: <20190313173157.30504-1-berrange@redhat.com> Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Samuel Thibault --- configure | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/configure b/configure index cab830a4c9..355eebfc5d 100755 --- a/configure +++ b/configure @@ -1109,8 +1109,6 @@ for opt do ;; --disable-slirp) slirp=3D"no" ;; - --enable-slirp=3Dgit) slirp=3D"git" - ;; --enable-slirp=3Dsystem) slirp=3D"system" ;; --disable-vde) vde=3D"no" @@ -5780,8 +5778,6 @@ case "$slirp" in "" | yes) if $pkg_config slirp; then slirp=3Dsystem - elif test -e "${source_path}/.git" && test $git_update =3D 'yes' ; then - slirp=3Dgit elif test -e "${source_path}/slirp/Makefile" ; then slirp=3Dinternal elif test -z "$slirp" ; then @@ -5799,10 +5795,7 @@ case "$slirp" in esac =20 case "$slirp" in - git | internal) - if test "$slirp" =3D git; then - git_submodules=3D"${git_submodules} slirp" - fi + internal) mkdir -p slirp slirp_cflags=3D"-I\$(SRC_PATH)/slirp/src -I\$(BUILD_DIR)/slirp/src" slirp_libs=3D"-L\$(BUILD_DIR)/slirp -lslirp" @@ -6464,7 +6457,7 @@ if test "$slirp" !=3D "no"; then echo "SLIRP_CFLAGS=3D$slirp_cflags" >> $config_host_mak echo "SLIRP_LIBS=3D$slirp_libs" >> $config_host_mak fi -if [ "$slirp" =3D "git" -o "$slirp" =3D "internal" ]; then +if [ "$slirp" =3D "internal" ]; then echo "config-host.h: subdir-slirp" >> $config_host_mak fi if test "$vde" =3D "yes" ; then --=20 2.20.1