From nobody Mon Nov 10 01:30:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552458571296955.1360100451644; Tue, 12 Mar 2019 23:29:31 -0700 (PDT) Received: from localhost ([127.0.0.1]:39180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3xOK-00029p-9B for importer@patchew.org; Wed, 13 Mar 2019 02:29:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3xLg-0000f1-UD for qemu-devel@nongnu.org; Wed, 13 Mar 2019 02:26:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3xLd-00020O-Ph for qemu-devel@nongnu.org; Wed, 13 Mar 2019 02:26:44 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:45424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3xLb-0001zb-2y for qemu-devel@nongnu.org; Wed, 13 Mar 2019 02:26:40 -0400 Received: by mail-pg1-x543.google.com with SMTP id 125so770710pgc.12 for ; Tue, 12 Mar 2019 23:26:38 -0700 (PDT) Received: from localhost.localdomain (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id m64sm25593889pfi.149.2019.03.12.23.26.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 23:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gpelhTrFHIRILhcge+m6UkRTeSiVlbqBCdoqAwCZgvk=; b=UJUiu3MjA//pbGAQqYY3Hhn1Bj/L3YPaBdYg1kaOQqB9hF7OvaeUgTFTDByKdPNcxL bc6Q1dE6z+u2xsUCtFNFMTtQpH07pYyc8KcSTImqAU0QoUPX2zFcqEVnQqJksF6QJo38 SDEUsA/ds6UuEj8sHx15IN2dZsFmM0qTce8flhmWb2KzsoaW350EgUgt9rPgg0J4/Zv+ 3AGV5TgYKLJhAN/CUj4HUrrDU5oC73lqLxVW1gy0I0CUPpqlqH801l4/NmB2HTU09l9J lxl+X7JbvERkQcnfjBrnbP6ht3BJg9D+R8+T3uA2+fuT365eX6YhS1r/hHbgJi36NcFZ E9gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gpelhTrFHIRILhcge+m6UkRTeSiVlbqBCdoqAwCZgvk=; b=LhZkFjg8OIvra2faMLDlgEyr8y725ArJQnkenA+VlmHvpOFpHp9/Bn5Ut/0fV1Sjx5 aDCwu+bsUN4xWRM4l53RxZ305sJTtuh/n9QRIPQ8SJk/cJdJUTvhK2vHPtdh5OnV/Jgb xB9HqIoTXug9fYnsYHBsfRnJgEMQpjrwcSoyUbfhiR5EQKR3WdiIdhZ4KETk9uVFvpFD 702QeDKSIZx+9XFZ9gAXGhzmL//naKGN0y7nKsyzmsq0X58VrWaGgaUcMMjm/Ma1pmaM 6fNeT+pqYzzb7kDyWD6ZENMP2I0w1/rMK4rgwJcr6xjJGFJarNI+gv3KKojj/QyjTpp7 3BXg== X-Gm-Message-State: APjAAAWSRs+oxG0on6aHTqVLVHMrLHFfrevPjreotrW9buODKJHSO5Yf PDACO3B/zCyZ8rqaG3oDdOh0n5iuPF4= X-Google-Smtp-Source: APXvYqxNA2RIxbsfqfi5e5dTeZK//SXbhJy5DEqrYEUHkAntVKeoboppZnqdOYplolxWpCkYFkZA/w== X-Received: by 2002:a17:902:8203:: with SMTP id x3mr43823533pln.159.1552458397416; Tue, 12 Mar 2019 23:26:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 12 Mar 2019 23:26:27 -0700 Message-Id: <20190313062630.30568-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190313062630.30568-1-richard.henderson@linaro.org> References: <20190313062630.30568-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 Subject: [Qemu-devel] [PATCH for-4.1 4/7] linux-user/aarch64: Use qemu_getrandom for arm_init_pauth_key X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, david@redhat.com, laurent@vivier.eu, armbru@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use a better interface for random numbers than rand * 3. Signed-off-by: Richard Henderson --- linux-user/aarch64/cpu_loop.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/linux-user/aarch64/cpu_loop.c b/linux-user/aarch64/cpu_loop.c index d75fd9d3e2..ad30cab52d 100644 --- a/linux-user/aarch64/cpu_loop.c +++ b/linux-user/aarch64/cpu_loop.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "qemu.h" #include "cpu_loop-common.h" +#include "qemu/random.h" =20 #define get_user_code_u32(x, gaddr, env) \ ({ abi_long __r =3D get_user_u32((x), (gaddr)); \ @@ -147,22 +148,9 @@ void cpu_loop(CPUARMState *env) } } =20 -static uint64_t arm_rand64(void) -{ - int shift =3D 64 - clz64(RAND_MAX); - int i, n =3D 64 / shift + (64 % shift !=3D 0); - uint64_t ret =3D 0; - - for (i =3D 0; i < n; i++) { - ret =3D (ret << shift) | rand(); - } - return ret; -} - void arm_init_pauth_key(ARMPACKey *key) { - key->lo =3D arm_rand64(); - key->hi =3D arm_rand64(); + qemu_getrandom(key, sizeof(*key), false); } =20 void target_cpu_copy_regs(CPUArchState *env, struct target_pt_regs *regs) --=20 2.17.1