[Qemu-devel] [PATCH v2 0/4] block/qcow2-bitmap: Enable resize with persistent bitmaps

Vladimir Sementsov-Ogievskiy posted 4 patches 5 years ago
Failed in applying to current master (apply log)
docs/interop/qcow2.txt     |  18 ++-
block/qcow2.h              |   1 +
block/qcow2-bitmap.c       |  67 ++++++++-
block/qcow2.c              |   4 +-
tests/qemu-iotests/246     | 114 ++++++++++++++
tests/qemu-iotests/246.out | 295 +++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/group   |   1 +
7 files changed, 491 insertions(+), 9 deletions(-)
create mode 100755 tests/qemu-iotests/246
create mode 100644 tests/qemu-iotests/246.out
[Qemu-devel] [PATCH v2 0/4] block/qcow2-bitmap: Enable resize with persistent bitmaps
Posted by Vladimir Sementsov-Ogievskiy 5 years ago
Hi!

This is my counter-propasal on
"[PATCH 0/5] block/qcow2-bitmap: Enable resize with persistent bitmaps" by John.

It does bitmap resize, but don't flush bitmaps during resize, postponing this
controversial thing.

Based-on: https://github.com/jnsnow/qemu bitmaps

John Snow (2):
  block/qcow2-bitmap: Allow resizes with persistent bitmaps
  tests/qemu-iotests: add bitmap resize test 246

Vladimir Sementsov-Ogievskiy (2):
  docs/interop/qcow2: Improve bitmap flag in_use specification
  block/qcow2-bitmap: Don't check size for IN_USE bitmap

 docs/interop/qcow2.txt     |  18 ++-
 block/qcow2.h              |   1 +
 block/qcow2-bitmap.c       |  67 ++++++++-
 block/qcow2.c              |   4 +-
 tests/qemu-iotests/246     | 114 ++++++++++++++
 tests/qemu-iotests/246.out | 295 +++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/group   |   1 +
 7 files changed, 491 insertions(+), 9 deletions(-)
 create mode 100755 tests/qemu-iotests/246
 create mode 100644 tests/qemu-iotests/246.out

-- 
2.18.0


Re: [Qemu-devel] [PATCH v2 0/4] block/qcow2-bitmap: Enable resize with persistent bitmaps
Posted by John Snow 5 years ago

On 3/11/19 2:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi!
> 
> This is my counter-propasal on
> "[PATCH 0/5] block/qcow2-bitmap: Enable resize with persistent bitmaps" by John.
> 
> It does bitmap resize, but don't flush bitmaps during resize, postponing this
> controversial thing.
> 
> Based-on: https://github.com/jnsnow/qemu bitmaps
> 
> John Snow (2):
>   block/qcow2-bitmap: Allow resizes with persistent bitmaps
>   tests/qemu-iotests: add bitmap resize test 246
> 
> Vladimir Sementsov-Ogievskiy (2):
>   docs/interop/qcow2: Improve bitmap flag in_use specification
>   block/qcow2-bitmap: Don't check size for IN_USE bitmap
> 
>  docs/interop/qcow2.txt     |  18 ++-
>  block/qcow2.h              |   1 +
>  block/qcow2-bitmap.c       |  67 ++++++++-
>  block/qcow2.c              |   4 +-
>  tests/qemu-iotests/246     | 114 ++++++++++++++
>  tests/qemu-iotests/246.out | 295 +++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  7 files changed, 491 insertions(+), 9 deletions(-)
>  create mode 100755 tests/qemu-iotests/246
>  create mode 100644 tests/qemu-iotests/246.out
> 

Alright, in the interest of moving forward I will stage this, we can
figure out if it's a problem when I am not sick :)

--js