From nobody Fri May 3 06:20:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552313232806470.8456044573286; Mon, 11 Mar 2019 07:07:12 -0700 (PDT) Received: from localhost ([127.0.0.1]:34119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3La5-0005Py-IE for importer@patchew.org; Mon, 11 Mar 2019 10:07:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LSb-0008Ss-E1 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3LSa-0000Sy-Er for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:21 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3LSa-0000S9-7H for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:20 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190311135918euoutp0279aea9f58c738e61e4ddd1abdcdb121c~K7DqsJuR22095420954euoutp02R for ; Mon, 11 Mar 2019 13:59:18 +0000 (GMT) Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190311135917eucas1p13d922e62c3630559952a8d0c0029375b~K7DqUvazf1241212412eucas1p1N; Mon, 11 Mar 2019 13:59:17 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 8D.C9.04294.5B9668C5; Mon, 11 Mar 2019 13:59:17 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d~K7DpbCc_u0722607226eucas1p2p; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190311135916eusmtrp2043b0a3508cfc11146193d2d2805741d~K7DpM0zcV3045630456eusmtrp23; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 95.1D.04128.4B9668C5; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190311135916eusmtip10ea80427009260620fc948bfca039738~K7DooSwJd1278712787eusmtip10; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190311135918euoutp0279aea9f58c738e61e4ddd1abdcdb121c~K7DqsJuR22095420954euoutp02R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1552312758; bh=2r1LDYdyh1zFXd/AmW3qbVCJPimzSpTwh/QVpbLabVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P3xozHNOKFkQy8kp4QWS2UPYIMbfgjpExSw29mSeiAfobSHSQkoM6J5Oaf+76GTF9 blZe28iYfnIYPvcrmz3R6hstTXTZsja5JQ+WL6QoYZQJrQMJ6b+zE+gsoBORVZBrL5 vOLUTzxAFog4ogj+oNldWJtekyLoFvwiQhC/R2kw= X-AuditID: cbfec7f4-835ff700000010c6-2a-5c8669b5f589 From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Eduardo Habkost Date: Mon, 11 Mar 2019 16:58:47 +0300 Message-Id: <20190311135850.6537-2-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311135850.6537-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7djPc7pbM9tiDFb+0LB482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcxWWT kpqTWZZapG+XwJVxaBtvwSPJilUNe5gaGJsEuxg5OSQETCQuTT/L2sXIxSEksIJRYsKGBWwQ zhdGiY/vN0E5nxklpvzdxgjTcvBVA1TLcqCqx8uZIZwfjBKLZpxhBaliE9CROLX6CFiHiEC+ xIbGRrAiZoGvjBIXj7xjA0kIC4RI7D52FKyIRUBVYvfcW0wgNq+AlcSF2SvYINbJS6zecIAZ xOYUsJaY2PGIHaJGUOLkzCcsIDYzUE3z1tlgCyQE2tklbvy8BnWri8T7w/tYIWxhiVfHt7BD 2DIS/3fOZ4Kw6yXut7xkhGjuYJSYfugfVMJeYsvrc0ANHEAbNCXW79KHCDtK/JpxFCwsIcAn ceOtIMQNfBKTtk1nhgjzSnS0CUFUq0j8PricGcKWkrj57jPUBR4Sx57sY57AqDgLyTezkHwz C2HvAkbmVYziqaXFuempxUZ5qeV6xYm5xaV56XrJ+bmbGIEp5vS/4192MO76k3SIUYCDUYmH NyG5NUaINbGsuDL3EKMEB7OSCO9Ot7YYId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzVDA+ihQTS E0tSs1NTC1KLYLJMHJxSDYzr22qVNPqT3rN/mlPQOPlScJRJ37kwh7eBM9Z2L9qdHn5VsvJk vemzyxxrZqWG54tmxcrWOdkrRlvFefiun2D8NjuXPeuy4T81DsdeV6uMVwJJKd6n1jf9NzvL zHOhsHLrxhX669j/BNqIV3HvFZ/3fr1Y6LYaCasl65IDevoZzr/aVLPhhRJLcUaioRZzUXEi AASng/otAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4Xd0tmW0xBke3aVi8ebOGyaLhXqjF lfaf7Banj3YwWzy7dZLZYkFbO6vF/m3/WC2O9+5gceDweHJtM5PH+31X2Tz6tqxiDGCO0rMp yi8tSVXIyC8usVWKNrQw0jO0tNAzMrHUMzQ2j7UyMlXSt7NJSc3JLEst0rdL0Ms4tI234JFk xaqGPUwNjE2CXYycHBICJhIHXzWwdjFycQgJLGWUuPNgEStEQkrix68LULawxJ9rXWwQRd8Y JT5dbmAHSbAJ6EicWn2EEcQWEciX2NDYyAxSxCzwk1Hixc1tQB0cHMICQRItr6tAalgEVCV2 z73FBGLzClhJXJi9gg1igbzE6g0HmEFsTgFriYkdj8DmCwHVdO7bzg5RLyhxcuYTFhCbGai+ eets5gmMArOQpGYhSS1gZFrFKJJaWpybnltspFecmFtcmpeul5yfu4kRGAnbjv3csoOx613w IUYBDkYlHl6OxNYYIdbEsuLK3EOMEhzMSiK8O93aYoR4UxIrq1KL8uOLSnNSiw8xmgI9MZFZ SjQ5HxileSXxhqaG5haWhubG5sZmFkrivOcNKqOEBNITS1KzU1MLUotg+pg4OKUaGBdNloqS 5v6f22bdEpnXNPXfkZUnPx148L0wSdaqLqipN7mkQP2bvQvXfvNWLv2aRUGhKh6/c8q09/z1 1zF5bhGek/TxHN+qu8I3xTfczA/oe/yFL7S+/MGNvaUfp6/daPDh6kLr848+9L7nYAx4dP/j tny/+ym2+sp+zzK9OHgc+LsKOX+7KbEUZyQaajEXFScCAIet3u2aAgAA X-CMS-MailID: 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d References: <20190311135850.6537-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v3 1/4] hostmem-memfd: disable for systems wihtout sealing support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) If seals are not supported, memfd_create() will fail. Furthermore, there is no way to disable it in this case because '.seal' property is not registered. This issue leads to vhost-user-test failures on RHEL 7.2: qemu-system-x86_64: -object memory-backend-memfd,id=3Dmem,size=3D2M,: \ failed to create memfd: Invalid argument and actually breaks the feature on such systems. Let's restrict memfd backend to systems with sealing support. Signed-off-by: Ilya Maximets --- backends/hostmem-memfd.c | 18 ++++++++---------- tests/vhost-user-test.c | 5 +++-- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index 98c9bf3240..46b15b916a 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -154,15 +154,13 @@ memfd_backend_class_init(ObjectClass *oc, void *data) "Huge pages size (ex: 2M, 1G= )", &error_abort); } - if (qemu_memfd_check(MFD_ALLOW_SEALING)) { - object_class_property_add_bool(oc, "seal", - memfd_backend_get_seal, - memfd_backend_set_seal, - &error_abort); - object_class_property_set_description(oc, "seal", - "Seal growing & shrinking", - &error_abort); - } + object_class_property_add_bool(oc, "seal", + memfd_backend_get_seal, + memfd_backend_set_seal, + &error_abort); + object_class_property_set_description(oc, "seal", + "Seal growing & shrinking", + &error_abort); } =20 static const TypeInfo memfd_backend_info =3D { @@ -175,7 +173,7 @@ static const TypeInfo memfd_backend_info =3D { =20 static void register_types(void) { - if (qemu_memfd_check(0)) { + if (qemu_memfd_check(MFD_ALLOW_SEALING)) { type_register_static(&memfd_backend_info); } } diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 0c965b3b1e..3817966010 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -178,7 +178,8 @@ static void append_mem_opts(TestServer *server, GString= *cmd_line, int size, enum test_memfd memfd) { if (memfd =3D=3D TEST_MEMFD_AUTO) { - memfd =3D qemu_memfd_check(0) ? TEST_MEMFD_YES : TEST_MEMFD_NO; + memfd =3D qemu_memfd_check(MFD_ALLOW_SEALING) ? TEST_MEMFD_YES + : TEST_MEMFD_NO; } =20 if (memfd =3D=3D TEST_MEMFD_YES) { @@ -930,7 +931,7 @@ static void register_vhost_user_test(void) "virtio-net", test_read_guest_mem, &opts); =20 - if (qemu_memfd_check(0)) { + if (qemu_memfd_check(MFD_ALLOW_SEALING)) { opts.before =3D vhost_user_test_setup_memfd; qos_add_test("vhost-user/read-guest-mem/memfd", "virtio-net", --=20 2.17.1 From nobody Fri May 3 06:20:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552313236103575.7689629281142; Mon, 11 Mar 2019 07:07:16 -0700 (PDT) Received: from localhost ([127.0.0.1]:34121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3La9-0005R1-6a for importer@patchew.org; Mon, 11 Mar 2019 10:07:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LSf-00004s-C1 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3LSd-0000UZ-Sf for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:24 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:46885) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3LSd-0000Tp-K7 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:23 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190311135920euoutp01da8fa0ffdf62aa7431f41a385f0a6dff~K7DtEAwTp1023410234euoutp01S for ; Mon, 11 Mar 2019 13:59:20 +0000 (GMT) Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190311135920eucas1p1596093e2e687e972acedd04c20aabb0e~K7DskxsP31391413914eucas1p1v; Mon, 11 Mar 2019 13:59:20 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 3D.17.04441.8B9668C5; Mon, 11 Mar 2019 13:59:20 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190311135919eucas1p11c7fad66884a0303b2637cd2d2b05cad~K7Dr1eugh2584425844eucas1p1F; Mon, 11 Mar 2019 13:59:19 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190311135919eusmtrp286389f8703aa5847567096006271cab5~K7DrnaeTE3045230452eusmtrp2e; Mon, 11 Mar 2019 13:59:19 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F7.44.04284.7B9668C5; Mon, 11 Mar 2019 13:59:19 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190311135918eusmtip12b7960c74e1a0eab3e0bdb128877b982~K7DrBdume1044510445eusmtip1D; Mon, 11 Mar 2019 13:59:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190311135920euoutp01da8fa0ffdf62aa7431f41a385f0a6dff~K7DtEAwTp1023410234euoutp01S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1552312760; bh=GEubV4Xl2+w4QqD4xxZ2I4ZswHS5mSjjUIfJbjJnB+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QSvkkXgp5f3u85YeaFBxm+hTYeItIoBaLC3REOOgU5SIjaBkyr93JwsjPfgz/edbs OQCfWLzjL9WG8a99KuYgOSCYCexOIFEPEcTWI7r2F6/ehX9ayq7gJUqWCjJE2j17ss RXX+2dPpg8nIi3qDI6Z4EEIWrGo78BHIDNdrTIP8= X-AuditID: cbfec7f2-5e3ff70000001159-cc-5c8669b88fb0 From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Eduardo Habkost Date: Mon, 11 Mar 2019 16:58:48 +0300 Message-Id: <20190311135850.6537-3-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311135850.6537-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsWy7djP87o7MttiDJqeMFm8ebOGyaLhXqjF lfaf7Banj3YwWzy7dZLZYkFbO6vF/m3/WC2O9+5gceDweHJtM5PH+31X2Tz6tqxiDGCO4rJJ Sc3JLEst0rdL4MpY1d/BVrCRteJSwxv2BsZVLF2MHBwSAiYSJ/eKdDFycQgJrGCUuN95kB3C +cIoMXXxfyCHE8j5zCgxuSsCpmHZmiiImuWMEi9OHmeCcH4wSmzYdBKsgU1AR+LU6iOMILaI QL7EhsZGZpAiZoGvjBIXj7xjA0kIC1hL/P7TDtbAIqAq0fV2HjPIBl4BK4n7zYUgYQkBeYnV Gw4wg9icQOUTOx6BlfMKCEqcnPmEBcRmBqpp3jqbGaJ+HrvElzZ7CNtFYt+3W+wQtrDEq+Nb oGwZif875zNB2PUS91teMoLcJiHQwSgx/dA/qIS9xJbX59hB7mEW0JRYv0sf4nlHiR2z/CFM PokbbwUhLuCTmLRtOjNEmFeio00IYoaKxO+Dy6EOk5K4+e4z1AEeEn8/nGCZwKg4C8kvs5D8 Mgth7QJG5lWM4qmlxbnpqcWGeanlesWJucWleel6yfm5mxiBieX0v+OfdjB+vZR0iFGAg1GJ hzchuTVGiDWxrLgy9xCjBAezkgjvTre2GCHelMTKqtSi/Pii0pzU4kOM0hwsSuK81QwPooUE 0hNLUrNTUwtSi2CyTBycUg2M5h1fZTxjnGKeK97k182Pu+W2gPngpFCjx0/Ud9aHTVFxZ9C6 wuDcxi41K/SuhLS+ZZON1gvFuBIVh2lfZ398cXat4a1jMwV0df9YXo502cv6srRhnqQEx5ak p8++dXlZfIgtXzHf9OWeEHlet7t7ZjZvll6c9p3lenZEdGN4VNA/xzimiWFKLMUZiYZazEXF iQA29VW+KAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xu7rbM9tiDPa9ErB482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcpWdT lF9akqqQkV9cYqsUbWhhpGdoaaFnZGKpZ2hsHmtlZKqkb2eTkpqTWZZapG+XoJexqr+DrWAj a8WlhjfsDYyrWLoYOTgkBEwklq2J6mLk4hASWMooMXtZG3sXIydQXErix68LrBC2sMSfa11s EEXfGCVuXfvDCJJgE9CROLX6CJgtIpAvsaGxkRmkiFngJ6PEi5vb2EASwgLWEr//tINNZRFQ leh6O48ZZDOvgJXE/eZCiAXyEqs3HGAGsTmByid2PAIrFwIq6dy3HczmFRCUODnzCdjRzALq EuvnCYGEmYFam7fOZp7AKDgLSdUshKpZSKoWMDKvYhRJLS3OTc8tNtQrTswtLs1L10vOz93E CIyabcd+bt7BeGlj8CFGAQ5GJR5ejsTWGCHWxLLiytxDjBIczEoivDvd2mKEeFMSK6tSi/Lj i0pzUosPMZoCfTaRWUo0OR8Y0Xkl8YamhuYWlobmxubGZhZK4rznDSqjhATSE0tSs1NTC1KL YPqYODilGhgldH307P4Xlp8xfH7x4ekjDROnsGSEfvnTvT5Gcdemdj4PYcPbimGsC67OOCez MDX5hXCRLx+LjZ3T8Vn8d/vVrLkKLCxu/vpeb+d9fonqqboO//PTTotpqcbWn7Bqd2NIZej4 bLhzv+Anyc/3nj4JnvP9UmBvSGL+4ld2R9X2d6y9z13/Zp0SS3FGoqEWc1FxIgCFU5CXsAIA AA== X-CMS-MailID: 20190311135919eucas1p11c7fad66884a0303b2637cd2d2b05cad X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190311135919eucas1p11c7fad66884a0303b2637cd2d2b05cad X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190311135919eucas1p11c7fad66884a0303b2637cd2d2b05cad References: <20190311135850.6537-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 210.118.77.11 Subject: [Qemu-devel] [PATCH v3 2/4] memfd: always check for MFD_CLOEXEC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) QEMU always sets this flag unconditionally. We need to check if it's supported. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 8debd0d037..d74ce4d793 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -188,7 +188,7 @@ bool qemu_memfd_alloc_check(void) bool qemu_memfd_check(unsigned int flags) { #ifdef CONFIG_LINUX - int mfd =3D memfd_create("test", flags); + int mfd =3D memfd_create("test", flags | MFD_CLOEXEC); =20 if (mfd >=3D 0) { close(mfd); --=20 2.17.1 From nobody Fri May 3 06:20:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552313348905508.8008698203814; Mon, 11 Mar 2019 07:09:08 -0700 (PDT) Received: from localhost ([127.0.0.1]:34131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3Lc0-0006dV-Tm for importer@patchew.org; Mon, 11 Mar 2019 10:09:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LSf-00004v-EC for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3LSe-0000Um-FY for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:25 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:46893) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3LSe-0000US-7Q for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:24 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190311135923euoutp016c07d9da816abb9b5a0391593bbebd94~K7DvbAwJe1017010170euoutp01Y for ; Mon, 11 Mar 2019 13:59:23 +0000 (GMT) Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190311135923eucas1p29365e3378914cdd702295646473a154c~K7DvDNRgp2985429854eucas1p29; Mon, 11 Mar 2019 13:59:23 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id B8.02.04806.AB9668C5; Mon, 11 Mar 2019 13:59:22 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190311135922eucas1p2e131e72beea41ae584761ea5a62a948c~K7DuSIN7L0098700987eucas1p2v; Mon, 11 Mar 2019 13:59:22 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190311135921eusmtrp2f5dcef0e3690c35a58a0e94929e812ae~K7DuEGrbE3045630456eusmtrp2H; Mon, 11 Mar 2019 13:59:21 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B9.44.04284.9B9668C5; Mon, 11 Mar 2019 13:59:21 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190311135921eusmtip1eb0feabe7206860c4e2e8b66946f0a7e~K7DtgD4Gi1279912799eusmtip16; Mon, 11 Mar 2019 13:59:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190311135923euoutp016c07d9da816abb9b5a0391593bbebd94~K7DvbAwJe1017010170euoutp01Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1552312763; bh=G6qVNsagLahNnT1E1keUV+wN4Fdw+aYdI7s4h8/TiWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iX1IU1VJooFqeOdBCIgxmHF5yUegJ/txnlBv/1yMtcN8Rd/kZ4qJkeSl6a3WR2MtK CXMWksp46EKElwxbSgqnqM17qsfQd4KaskFaktgrsJ18nyZU1KxQUlFZLVREBR1lHL YgKBtOdTjD00oHv7dQqW1Gl404W8JgV5La4TVib8= X-AuditID: cbfec7f5-79db79c0000012c6-8d-5c8669ba2f56 From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Eduardo Habkost Date: Mon, 11 Mar 2019 16:58:49 +0300 Message-Id: <20190311135850.6537-4-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311135850.6537-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7djP87q7MttiDCa907F482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcxWWT kpqTWZZapG+XwJXx+G4zS8ErlooJF1ewNjB+Ye5i5OCQEDCRaLls38XIySEksIJRYvulvC5G LiD7C6PEh2uL2CGcz4wSfx9vZwGpAmlYf7YdKrGcUWLinz5GCOcHo8TvN6vYQarYBHQkTq0+ wghiiwjkS2xobGQGKWIW+MoocfHIOzaQhLCAi8SrN3fAxrIIqErc75jABGLzClhJXH21Hmqd vMTqDQeYQWxOAWuJiR2P2CFqBCVOznwCVsMMVNO8dTbYAgmBeewSt46fZoRodpG40HUMapCw xKvjW9ghbBmJ/zvnM0HY9RL3W14yQjR3MEpMP/QPKmEvseX1OXZQKDELaEqs36UPEXaUOHN2 Fwsk8PgkbrwVhLiBT2LStunQMOWV6GgTgqhWkfh9cDkzhC0lcfPdZ3aIEg+JJX9EJjAqzkLy zCwkz8xCWLuAkXkVo3hqaXFuemqxcV5quV5xYm5xaV66XnJ+7iZGYHo5/e/41x2M+/4kHWIU 4GBU4uFNSG6NEWJNLCuuzD3EKMHBrCTCu9OtLUaINyWxsiq1KD++qDQntfgQozQHi5I4bzXD g2ghgfTEktTs1NSC1CKYLBMHp1QD41zPolP54ZNzJ8gopQj91nVcqvfj3rn5m06FuPsd2jbL KqO9O3o1664NDZ8lnN+wxT75Fz7PZfNvyd9mW056OBZHSXBx/49XmBL840BvXslhznvfQ9h8 xb+7ndWP8WnOehA9s2f2/PPJh1p/7T2osl1016HJZ0qUF357szXvMbORuPNvS4l5r5RYijMS DbWYi4oTAYG5+S8rAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t/xu7o7M9tiDP58tLB482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcpWdT lF9akqqQkV9cYqsUbWhhpGdoaaFnZGKpZ2hsHmtlZKqkb2eTkpqTWZZapG+XoJfx+G4zS8Er looJF1ewNjB+Ye5i5OSQEDCRWH+2nb2LkYtDSGApo8Sjh7NZIBJSEj9+XWCFsIUl/lzrYoMo +sYosXz3GrBuNgEdiVOrjzCC2CIC+RIbGhuZQYqYBX4ySry4uY0NJCEs4CLx6s0dsKksAqoS 9zsmMIHYvAJWEldfrYfaJi+xesMBsKGcAtYSEzsesYPYQkA1nfu2s0PUC0qcnPkEqJ4DaIG6 xPp5QiBhZqDW5q2zmScwCs5CUjULoWoWkqoFjMyrGEVSS4tz03OLDfWKE3OLS/PS9ZLzczcx AiNn27Gfm3cwXtoYfIhRgINRiYeXI7E1Rog1say4MvcQowQHs5II7063thgh3pTEyqrUovz4 otKc1OJDjKZAr01klhJNzgdGdV5JvKGpobmFpaG5sbmxmYWSOO95g8ooIYH0xJLU7NTUgtQi mD4mDk6pBsYYD9/aEN0n78tVGNbEuztt3t8QZJS99PTH9jXVuV+PfZ1Tn+92sTpCnUPe/Ln5 6lWW3I63Syw25h6aHFtm8cJIamHm4QmL9DJ8bsqa9S698kfqdT6TD8vk9fen7n2V2PObo/tl uv/ePJ8pr6d6PbTnN2zr8z+44zzLdGG1v/Yz7RSjp3vlTlNiKc5INNRiLipOBAB1oOgCsgIA AA== X-CMS-MailID: 20190311135922eucas1p2e131e72beea41ae584761ea5a62a948c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190311135922eucas1p2e131e72beea41ae584761ea5a62a948c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190311135922eucas1p2e131e72beea41ae584761ea5a62a948c References: <20190311135850.6537-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 210.118.77.11 Subject: [Qemu-devel] [PATCH v3 3/4] memfd: set up correct errno if not supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) qemu_memfd_create() prints the value of 'errno' which is not set in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/memfd.c b/util/memfd.c index d74ce4d793..393d23da96 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -40,6 +40,7 @@ static int memfd_create(const char *name, unsigned int fl= ags) #ifdef __NR_memfd_create return syscall(__NR_memfd_create, name, flags); #else + errno =3D ENOSYS; return -1; #endif } --=20 2.17.1 From nobody Fri May 3 06:20:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552313351450415.34507215929784; Mon, 11 Mar 2019 07:09:11 -0700 (PDT) Received: from localhost ([127.0.0.1]:34133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3Lc3-0006eg-67 for importer@patchew.org; Mon, 11 Mar 2019 10:09:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LSi-00008X-Lx for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3LSh-0000WU-RN for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:28 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45239) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3LSh-0000W0-Kl for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:27 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190311135926euoutp020c61c692d9e4f6d53c79afd4d910e3df~K7DyYG0eb2092420924euoutp02f for ; Mon, 11 Mar 2019 13:59:26 +0000 (GMT) Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190311135926eucas1p279821241ce856ec044541406dcfc8a97~K7Dx8xS1-3183531835eucas1p2A; Mon, 11 Mar 2019 13:59:26 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9F.02.04806.DB9668C5; Mon, 11 Mar 2019 13:59:25 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d~K7DxBPPG-0058600586eucas1p2s; Mon, 11 Mar 2019 13:59:25 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190311135924eusmtrp214999deb66165486fc8dee24231db424~K7DwyOFK13070130701eusmtrp2K; Mon, 11 Mar 2019 13:59:24 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D2.2D.04128.CB9668C5; Mon, 11 Mar 2019 13:59:24 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190311135924eusmtip197e858d65249e5b56175d47ecb80d5c8~K7DwLxQ-e1279912799eusmtip18; Mon, 11 Mar 2019 13:59:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190311135926euoutp020c61c692d9e4f6d53c79afd4d910e3df~K7DyYG0eb2092420924euoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1552312766; bh=w4Jv8ksWorck56mIfI6cvuADBi/bwNFiq1e9hNPUSn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YNqCr79qNzgCCGN8LrWMZ0B+dgpNz/cHVQUyDkCWxTOXOYfweLM5TK3w4arCeuRuH T/Da2w1Yodi6OCVz87KJ/8IrJMtHThr8hQQOQzgLzzcPLCpSFmzfywtkhnSoKKnWNS qJ+uyWhP00+wbLM7vGErVEQNtPZ1NlVRhlJTF660= X-AuditID: cbfec7f5-367ff700000012c6-9f-5c8669bd3c50 From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Eduardo Habkost Date: Mon, 11 Mar 2019 16:58:50 +0300 Message-Id: <20190311135850.6537-5-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311135850.6537-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7djPc7p7M9tiDJZ+NrF482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcxWWT kpqTWZZapG+XwJXx/1UHe8ENroqWM0YNjM/Yuxg5OSQETCQe3JsEZHNxCAmsYJT48mgHM0hC SOALo8SbVxoQic+MEpPnHWOD6Zh66wALRGI5o8SFS9+g2n8wSnzbOo8RpIpNQEfi1OojYLaI QL7EhsZGZpAiZoGvjBIXj7wDGsXBISxgKnF2Lx9IDYuAqsSCpcfB6nkFrCR+v/nDArFNXmL1 hgNgJ3EKWEtM7HjEDlEjKHFy5hOwGmagmuats8HmSwjMY5d4d6uDGaLZReLb8kaoQcISr45v gXpaRuL/zvlMEHa9xP2Wl4wQzR2MEtMP/YNK2EtseX2OHeRQZgFNifW79CHCjhJv/k1hBAlL CPBJ3HgrCHEDn8SkbdOZIcK8Eh1tQhDVKhK/Dy6HukZK4ua7z1AXeEicn/KaeQKj4iwk38xC 8s0shL0LGJlXMYqnlhbnpqcWG+ellusVJ+YWl+al6yXn525iBKaX0/+Of93BuO9P0iFGAQ5G JR7ehOTWGCHWxLLiytxDjBIczEoivDvd2mKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ81YzPIgW EkhPLEnNTk0tSC2CyTJxcEo1MGpxc3L+9z9l+iCnsX6jjOeJjhPrfrz9ahb5xS+7bqmAtZrz txmTvXTFHy4xejXBe/f7aWfE31q6HNvLISmkk/GgUUBdQdC0tEegOU6Nz3XarXu3O37uOFyV IHze3PFd5V3Nsvo3Ad/yF3bKMyVlL1JsWLMj5NPFtdlH/vVZ97EefHxR0e3yCiWW4oxEQy3m ouJEAFrUOY8rAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xu7p7MttiDB6sMrJ482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcpWdT lF9akqqQkV9cYqsUbWhhpGdoaaFnZGKpZ2hsHmtlZKqkb2eTkpqTWZZapG+XoJfx/1UHe8EN roqWM0YNjM/Yuxg5OSQETCSm3jrA0sXIxSEksJRRYsPWh0wQCSmJH78usELYwhJ/rnWxQRR9 Y5S4OvciWDebgI7EqdVHGEFsEYF8iQ2NjcwgRcwCPxklXtzcBtTBwSEsYCpxdi8fSA2LgKrE gqXHwep5Bawkfr/5wwKxQF5i9YYDzCA2p4C1xMSOR2DzhYBqOvdtZ4eoF5Q4OfMJC8hIZgF1 ifXzhEDCzECtzVtnM09gFJyFpGoWQtUsJFULGJlXMYqklhbnpucWG+kVJ+YWl+al6yXn525i BEbNtmM/t+xg7HoXfIhRgINRiYeXI7E1Rog1say4MvcQowQHs5II7063thgh3pTEyqrUovz4 otKc1OJDjKZAr01klhJNzgdGdF5JvKGpobmFpaG5sbmxmYWSOO95g8ooIYH0xJLU7NTUgtQi mD4mDk6pBkad8sQjnVEi5Q+9jzvKP5lzS9G4X/Op0owUIdXFiaGqaUfKDDX3Loo7W1P7bFu9 8vYJ196eFnukeeu75uzM+kcbSz7yen58qL1cZJK9TXLG2g9SP+Tnm3A8E5xzRv/Ppb2RqjM4 M8tEJwYuEje3nhG74IVteYzMpO4Fd7tyF9Vs+Hmk+nTKw2QlluKMREMt5qLiRACt6jRNsAIA AA== X-CMS-MailID: 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d References: <20190311135850.6537-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v3 4/4] memfd: improve error messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This gives more information about the failure. Additionally 'ENOSYS' returned for a non-Linux platforms instead of 'errno', which is not initilaized in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 393d23da96..00334e5b21 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -71,14 +71,18 @@ int qemu_memfd_create(const char *name, size_t size, bo= ol hugetlb, } mfd =3D memfd_create(name, flags); if (mfd < 0) { + error_setg_errno(errp, errno, + "failed to create memfd with flags 0x%x", flags); goto err; } =20 if (ftruncate(mfd, size) =3D=3D -1) { + error_setg_errno(errp, errno, "failed to resize memfd to %zu", siz= e); goto err; } =20 if (seals && fcntl(mfd, F_ADD_SEALS, seals) =3D=3D -1) { + error_setg_errno(errp, errno, "failed to add seals 0x%x", seals); goto err; } =20 @@ -88,8 +92,9 @@ err: if (mfd >=3D 0) { close(mfd); } +#else + error_setg_errno(errp, ENOSYS, "failed to create memfd"); #endif - error_setg_errno(errp, errno, "failed to create memfd"); return -1; } =20 --=20 2.17.1