From nobody Sun Nov 9 23:03:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552264561334557.6692557021327; Sun, 10 Mar 2019 17:36:01 -0700 (PDT) Received: from localhost ([127.0.0.1]:53082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h38v8-00022g-Au for importer@patchew.org; Sun, 10 Mar 2019 20:35:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h38qm-0007eU-DV for qemu-devel@nongnu.org; Sun, 10 Mar 2019 20:31:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h38qj-0003Va-NK for qemu-devel@nongnu.org; Sun, 10 Mar 2019 20:31:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40100) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h38qj-0003VD-G3 for qemu-devel@nongnu.org; Sun, 10 Mar 2019 20:31:25 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AEDCBC057E68; Mon, 11 Mar 2019 00:31:24 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-18.brq.redhat.com [10.40.204.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37F07177AC; Mon, 11 Mar 2019 00:31:20 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, Laszlo Ersek Date: Mon, 11 Mar 2019 01:30:49 +0100 Message-Id: <20190311003052.13778-3-philmd@redhat.com> In-Reply-To: <20190311003052.13778-1-philmd@redhat.com> References: <20190311003052.13778-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 11 Mar 2019 00:31:24 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/5] roms/edk2: Avoid bashism in script X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "Michael S . Tsirkin" , =?UTF-8?q?Michal=20Pr=C3=ADvozn=C3=ADk?= , Gerd Hoffmann , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Use the POSIX '=3D' to evaluate equality. This fixes building the roms with a dash shell: $ make -C roms efi [...] cp edk2/Build/ArmVirtQemu-ARM/DEBUG_GCC5/FV/QEMU_EFI.fd \ ../pc-bios/edk2-arm-code.fd truncate --size=3D64M ../pc-bios/edk2-arm-code.fd /bin/sh: 111: [: i686: unexpected operator /bin/sh: 112: [: i686: unexpected operator /bin/sh: 116: [: i686: unexpected operator Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- roms/edk2-funcs.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roms/edk2-funcs.sh b/roms/edk2-funcs.sh index 7fc62f074c..402fc126fb 100644 --- a/roms/edk2-funcs.sh +++ b/roms/edk2-funcs.sh @@ -108,8 +108,8 @@ qemu_edk2_get_cross_prefix() =20 host_arch=3D$(uname -m) =20 - if [ "$gcc_arch" =3D=3D "$host_arch" ] || - ( [ "$gcc_arch" =3D=3D i686 ] && [ "$host_arch" =3D=3D x86_64 ] ); th= en + if [ "$gcc_arch" =3D "$host_arch" ] || + ( [ "$gcc_arch" =3D i686 ] && [ "$host_arch" =3D x86_64 ] ); then # no cross-compiler needed : else --=20 2.20.1