From nobody Sun Nov 9 21:33:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552178338206206.3508829729932; Sat, 9 Mar 2019 16:38:58 -0800 (PST) Received: from localhost ([127.0.0.1]:38110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mUR-0006K6-76 for importer@patchew.org; Sat, 09 Mar 2019 19:38:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mQE-0003LE-5q for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2mQD-00019p-I8 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:34 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:34853) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2mQD-00018h-BX for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:33 -0500 Received: by mail-wm1-x344.google.com with SMTP id y15so1053858wma.0 for ; Sat, 09 Mar 2019 16:34:33 -0800 (PST) Received: from x1.local (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 12sm29164462wme.25.2019.03.09.16.34.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 16:34:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6EFDx1Ev8Jm1dskiynS+IlHGsfAUsRu7928CIVPKffc=; b=Tf+D2KGItY1CNm5P6l12ZyfVgIlUpWjR+xLzjgNT3oQdpKEMzHgSQDAtU+30sYbanN 8DgJi9SYJbwPxnjQCFzdvOw5fBNAr/w+fKrJsyrYjd0VIODPhJHwB1vSWNpZ3y03CjD2 P+2QRs1wp/YZZcZWIgUw2/hmyPGgE1eruBwEJuVTemrNpbtIczAgoMXUrsHI/zntZIYA JBqRYQ6VKNcELMFxcoeMtULNJzNvxuMjWqJRehbbssS322NtgzNgkAxO/yADX43Wg1OQ 5Ls3TmdOvcxNyfzgKnlhwk7uHGGXBhltsSNs3YeCRkKHudNFRU1WSl/7Kj8XrxCaurkj ye8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=6EFDx1Ev8Jm1dskiynS+IlHGsfAUsRu7928CIVPKffc=; b=TzpvZ4rdfw3vJC8WMyn38vQdKURMRRTMucikzQGYZ01CdZ3fo+zU3vPGuiDpo/UQzl tcfTmmbtlC2mW3UoFhdHHhOupCd/9EIaQUXsQD0sRsThFISesxDPkksKb0Hs7itUCt7h 4Uez69KLfa7ydvYcGGvWDaaufUMzOaj83DwURiCV2OIEJyi5BHqsEP61BmtLgUiMswNj 64BOMv71BgrlNNe77NaWtnLzHM+X7OVWp9KzXnUvGweJBPTchBwfg+5wH9SFVb7jhP/S tErkw+P18NChegu38x/aKyHuv/IBp4njWWtRtAYil+LcE0bAgCFU4NoY2EyTmAra3Lkg dK4g== X-Gm-Message-State: APjAAAVCPOuhCdwC8mWCBw4mTzvbzHrqf+4bb6sBDHC5qat4obnTxeKT UDMSQHzhEPN8kL2/OeWZ80M= X-Google-Smtp-Source: APXvYqzl4jhodFUpg+kmyxl8YMsBuQdhHBCYt8K4e/UKtmKVr1hBtRH6YIvfeJhreBkYbhvj0xJrcg== X-Received: by 2002:a7b:c3d7:: with SMTP id t23mr12619406wmj.49.1552178072281; Sat, 09 Mar 2019 16:34:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Laurent Vivier , Richard Henderson Date: Sun, 10 Mar 2019 01:34:23 +0100 Message-Id: <20190310003428.11723-2-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190310003428.11723-1-f4bug@amsat.org> References: <20190310003428.11723-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH 1/6] target/m68k: Reduce the l1 TCGLabel scope X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/m68k/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 6217a683f1..ab801b6ceb 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -3019,7 +3019,6 @@ DISAS_INSN(branch) int32_t offset; uint32_t base; int op; - TCGLabel *l1; =20 base =3D s->pc; op =3D (insn >> 8) & 0xf; @@ -3035,7 +3034,7 @@ DISAS_INSN(branch) } if (op > 1) { /* Bcc */ - l1 =3D gen_new_label(); + TCGLabel *l1 =3D gen_new_label(); gen_jmpcc(s, ((insn >> 8) & 0xf) ^ 1, l1); gen_jmp_tb(s, 1, base + offset); gen_set_label(l1); --=20 2.19.1 From nobody Sun Nov 9 21:33:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552178196907426.6189611339738; Sat, 9 Mar 2019 16:36:36 -0800 (PST) Received: from localhost ([127.0.0.1]:38091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mS9-0004aI-SH for importer@patchew.org; Sat, 09 Mar 2019 19:36:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mQF-0003LS-I5 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2mQE-0001Be-SH for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:35 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:46145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2mQE-0001AW-LI for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:34 -0500 Received: by mail-wr1-x444.google.com with SMTP id i16so1245644wrs.13 for ; Sat, 09 Mar 2019 16:34:34 -0800 (PST) Received: from x1.local (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 12sm29164462wme.25.2019.03.09.16.34.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 16:34:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/UgiOQlOFdophtvSKCC146YFT3gwmbg4t5c9DQQff6w=; b=O5ATfzPhybv/90GTyU4VsuhRG4UYh0vzov1+BgBX6bkmu9jVenYYau6Od+abbZUGSG iAulKQu61tPtoeSxcZJDmRuhxA5Xgcn4bxQDs1EZYce4H99QOdgbrN8oLDLsbB11bQCk LlHVFJPspBHZpVpB10LoESAlRQs16MpHeCfLy5Z67cM3ALHFLOwgqacVT0IFpXE9QpbK jJd/FXKWZcpKPJ4lvKJUC69zCriMu9/Asht0a2NLZTXJvFH8rli69pQqyODjtBuSWgvL MKm4c7sD8TAtZp2HCJbaPfD6ZPREaTLFpqBv4h7jX8hMhr8f8gHazj6uBjurqWCx//QO 6nxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/UgiOQlOFdophtvSKCC146YFT3gwmbg4t5c9DQQff6w=; b=iBif9p3Rfu0JZ6davtQHLpVl4XHyA8SB5JNqVp9dYaSbH+ZV9wVbZOQEvv+jo6pJDx sIQmqsO+xrkxwQh+xu5FOFB1H/H/N6pIe8tmH7P8uEqKCCv49ctn6drYaNVjLIUoCDzf myPX+VDBFO6nV8nZ6UkemkIEn3pK6big9wc4I88PhgNGydWuvgYiW0U+fXrhMO7vFyZY hBMFE5P+QWGEGr1svr06TF22Vo3827dJmrdaoMq0y0N/lva/4LlteOYIXJn7Ra9Cy4gG m3zzxgG/yS2Cb73jqEW0VvAFMW9Rjt+cGBt51bpn8vhDEuo4//zF+xBmUdz+7dnVWoLb XGAg== X-Gm-Message-State: APjAAAXrcKCZtCgVhyrDy+Nua67EpgfoatizomZjBZt4IFmTjcV2NWGq XHc+us3vB6XbxhtD7jHiCBE= X-Google-Smtp-Source: APXvYqwuUHaEm+vWWFha1wcOSqOyLsN8Sqj6b4pQS1cOICBCkRQ0tmIEbJldj9lwrFpPmGtOUrV9cg== X-Received: by 2002:adf:c752:: with SMTP id b18mr15776896wrh.105.1552178073526; Sat, 09 Mar 2019 16:34:33 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Laurent Vivier , Richard Henderson Date: Sun, 10 Mar 2019 01:34:24 +0100 Message-Id: <20190310003428.11723-3-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190310003428.11723-1-f4bug@amsat.org> References: <20190310003428.11723-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH 2/6] target/m68k: Optimize the partset instruction using deposit_i32() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/translate.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ab801b6ceb..55766fd7ef 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -720,17 +720,15 @@ static void gen_partset_reg(int opsize, TCGv reg, TCG= v val) TCGv tmp; switch (opsize) { case OS_BYTE: - tcg_gen_andi_i32(reg, reg, 0xffffff00); tmp =3D tcg_temp_new(); tcg_gen_ext8u_i32(tmp, val); - tcg_gen_or_i32(reg, reg, tmp); + tcg_gen_deposit_i32(reg, tmp, reg, 8, 24); tcg_temp_free(tmp); break; case OS_WORD: - tcg_gen_andi_i32(reg, reg, 0xffff0000); tmp =3D tcg_temp_new(); tcg_gen_ext16u_i32(tmp, val); - tcg_gen_or_i32(reg, reg, tmp); + tcg_gen_deposit_i32(reg, tmp, reg, 16, 16); tcg_temp_free(tmp); break; case OS_LONG: --=20 2.19.1 From nobody Sun Nov 9 21:33:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552178338937722.3789101159566; Sat, 9 Mar 2019 16:38:58 -0800 (PST) Received: from localhost ([127.0.0.1]:38112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mUT-0006MS-Um for importer@patchew.org; Sat, 09 Mar 2019 19:38:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mQG-0003Lr-LS for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2mQF-0001DN-Vl for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:36 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:45060) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2mQF-0001Bs-P3 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:35 -0500 Received: by mail-wr1-x434.google.com with SMTP id o7so1246755wrp.12 for ; Sat, 09 Mar 2019 16:34:35 -0800 (PST) Received: from x1.local (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 12sm29164462wme.25.2019.03.09.16.34.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 16:34:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EcZjsflD4aXSqfY5TL+VmzuYelayH5XT9DFOcJNXcWs=; b=oVSooEevXVQps7Q/Q0gMa3esLrfbPoXaujtk//buXmj/8ZsJktPAG7df5+Sl+693lG NFsPE1CCtb1FlCas/sEDQHUoPkAlocoUdiqkgDxpbhJRXg362w3P0zb4By/l2mFQZt10 9hPXvfe5Y8PQaurQDv5cxh9YGpxF+bQy9zjgCRZgK5SCctWIZ9zWQylof8I/+TeVPwjI wXZSoS6UEcAPF4aGGZPDh4leZnybhM2ILyq6JNsQoDTnoMr7RauraaAdqsFRGmO9MIta w7Zg18qP5ZR6EadIJP+UkspUOWQ2uG18SkW6iVHAeqYqTboL/tcgvNU2hgeJVqdrKaD2 L+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=EcZjsflD4aXSqfY5TL+VmzuYelayH5XT9DFOcJNXcWs=; b=i2dx3FlgbZ+GIv2MCCWi9PXHEKAFr9/i7szL57tGG5y4NUILFF9xwQzeW7Mpzm4mxc wLxKsdK+Tgf0rB3BxWGgxih9Uk8/7qiTgLX1nsd+kFJY2LWE2HwwTtJ0s56QlfaIxqW1 v86LzguQhdT6sz5CPHQexqmLoFzslcneUT1cXSC9GzCeIfUY3sh2bVFb6omkw6P0VESN MpYgqJP3QqBQQpBqxFvWC+dNNq05n9NyzNfajQ4hBqaxkHEAnHm6bzXWJChJF43X/4kj Z3qCgBFvHE8UMFlV8MHAvB6UHkiN+aIiDRum9B82wRmQnPsCC1kMGLFt1J26NWbcRfnl MPOw== X-Gm-Message-State: APjAAAVX3EhJFgfqND4yHsKldLJvyKt0hhNtw15EIsHA6BUkjs9XKoBU ZdRo7yBxCjGwClhCqkocdfU= X-Google-Smtp-Source: APXvYqzCSALqRBrgZ1+Nzd1u0oKcp2t31UIp27ZI8wQYsfPGO1DMSYY5Oo3aNt6MPBft/MGlYCwNTQ== X-Received: by 2002:a5d:518b:: with SMTP id k11mr2570192wrv.177.1552178074783; Sat, 09 Mar 2019 16:34:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Laurent Vivier , Richard Henderson Date: Sun, 10 Mar 2019 01:34:25 +0100 Message-Id: <20190310003428.11723-4-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190310003428.11723-1-f4bug@amsat.org> References: <20190310003428.11723-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::434 Subject: [Qemu-devel] [PATCH 3/6] target/m68k: Fix a tcg_temp leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The function gen_get_ccr() returns a tcg_temp created with tcg_temp_new(). Free it with tcg_temp_free(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- Laurent/Richard, feel free to squash this with the next patch, but IMHO having it split as a previous step makes the next patch easier to review. --- target/m68k/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 55766fd7ef..ea95d55a11 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -2224,6 +2224,7 @@ static TCGv gen_get_sr(DisasContext *s) sr =3D tcg_temp_new(); tcg_gen_andi_i32(sr, QREG_SR, 0xffe0); tcg_gen_or_i32(sr, sr, ccr); + tcg_temp_free(ccr); return sr; } =20 --=20 2.19.1 From nobody Sun Nov 9 21:33:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552178201619823.433240521517; Sat, 9 Mar 2019 16:36:41 -0800 (PST) Received: from localhost ([127.0.0.1]:38093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mSD-0004cm-Br for importer@patchew.org; Sat, 09 Mar 2019 19:36:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mQH-0003Mh-Rt for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2mQH-0001F4-4l for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:37 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:51433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2mQG-0001DX-U4 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:37 -0500 Received: by mail-wm1-x341.google.com with SMTP id n19so1050877wmi.1 for ; Sat, 09 Mar 2019 16:34:36 -0800 (PST) Received: from x1.local (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 12sm29164462wme.25.2019.03.09.16.34.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 16:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9ppiZydzuJZfRra/Eep6XgXkNNmKKSwsF0Yu2yJlfH0=; b=YjpAsmaC3NwthpGKzxoa+IbR6Gc2Yr+Dx0ubmxYK1qR4ipY45GMmO8hiHsSS5ibSxc awRF1wNBQt6VulGiHIQgt45jy5Jqwo+CYeAyN4R7kkQh6v1ld1UfOKhYKplp8S5ArWId pPpO5H17vta88Xv1ZKwI0FY6vTCyytqvJzM6ZCAwQhhgL0kJV12p2yyn0/Sz7zzQT6S0 iFHOCztLAv677OZPISyCmkMsvOJWsK52FrAT1Q6INy1iCRYWsAGzIqHeMz8ysu/OhVV/ tFt9wG35IM8movetluwbv/TVorMCck9BdB+P1Sf48KJVFMqNKSnKT8fJYwH9bi7GEzj5 VH3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9ppiZydzuJZfRra/Eep6XgXkNNmKKSwsF0Yu2yJlfH0=; b=dzuyh8mMNAlwBAzNlzutPwdSN/SGA70EKPzu6nKFe7HHTNnFSi88N5Cf/fbCrJBRnF AXBJ81Rz+2EWqycQlfgNXoJPdU485gVmG+77nopy31/uiX67ytNVTad0h7PSlI8qqTUi hon/k6fVscl+wpKrJj/l0/8ZXi8JcCTlSuBAqwv8rJ2VD0GaXA2CJRvFLjyp3tfzsMnx 7RFIX7e3HM+3C6Gr1qVeV50m32PSdbWb7Qp0Z8zEV60rqH/VcGHa+ZKCXpWZp3nKpVi8 QohFNHDHEHldX3m6QDfwEmWAzdh4/Hen4zzobS+zTyK75XUQ0Ju8tVMBsvzsnN0NOlfp XybQ== X-Gm-Message-State: APjAAAVe+4KF/nt/CxyxzOGDz1eat4y1xedRovqpTeuHyZfjNKOM5EZ8 AY7sdc8iPmIbr0PPyy2GPkM= X-Google-Smtp-Source: APXvYqw462AesrjY4Yj6JuU6AMGpnFhCKsU6WerNtmcv5xGr7uzHa+Ek9xHAdcxA5aeJ0IFMe625Rg== X-Received: by 2002:a1c:480a:: with SMTP id v10mr12367391wma.57.1552178075853; Sat, 09 Mar 2019 16:34:35 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Laurent Vivier , Richard Henderson Date: Sun, 10 Mar 2019 01:34:26 +0100 Message-Id: <20190310003428.11723-5-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190310003428.11723-1-f4bug@amsat.org> References: <20190310003428.11723-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH 4/6] target/m68k: Optimize get_sr() using deposit_i32() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Doing so we free one tcg_temp. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/translate.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ea95d55a11..f43ac07b7f 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -2217,15 +2217,11 @@ static TCGv gen_get_ccr(DisasContext *s) =20 static TCGv gen_get_sr(DisasContext *s) { - TCGv ccr; - TCGv sr; + TCGv dest; =20 - ccr =3D gen_get_ccr(s); - sr =3D tcg_temp_new(); - tcg_gen_andi_i32(sr, QREG_SR, 0xffe0); - tcg_gen_or_i32(sr, sr, ccr); - tcg_temp_free(ccr); - return sr; + dest =3D gen_get_ccr(s); + tcg_gen_deposit_i32(dest, dest, QREG_SR, 5, 11); + return dest; } =20 static void gen_set_sr_im(DisasContext *s, uint16_t val, int ccr_only) --=20 2.19.1 From nobody Sun Nov 9 21:33:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155217834299540.2975684613333; Sat, 9 Mar 2019 16:39:02 -0800 (PST) Received: from localhost ([127.0.0.1]:38114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mUY-0006QN-1g for importer@patchew.org; Sat, 09 Mar 2019 19:39:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mQI-0003Nu-V5 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2mQI-0001GK-4U for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:38 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:34621) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2mQH-0001FD-UI for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:38 -0500 Received: by mail-wr1-x442.google.com with SMTP id f14so1284413wrg.1 for ; Sat, 09 Mar 2019 16:34:37 -0800 (PST) Received: from x1.local (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 12sm29164462wme.25.2019.03.09.16.34.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 16:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lGz9YZRWGrXDP3+rBti57r/rIWAYSgdccohb1TG0B8I=; b=ZtMkXkH9KD7P/9dluRYhSFaoBMBY1jpuXbtmZcfjq9m4Xwo0ov/ePMGmEwNZ8sv8oQ 8q0FDiuLF7SvLawqs3cMErRn3wOomHaAts45W9tyWBWO2oK5GPeWNADTouwnJutrymTi ehUB9RNzs3X5cJFcu0r/McXsSOW8qQfudo1eP5/pncs5tOX2NoDtaJ4/Ev9KL8Nmtk4Q uIj9qAe1mV8O9ksHFN3na7SyulmmQ9bELYlqW53f/dutOHRVXUH+bORm43U/AQML9Fov PETGQZHdLnOy1As6p3/pRyQqnAN1GEB8pxqwQUV9t3mcf3aQ+yZ8XL+MA7Ng/Sm5z7tz UQzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=lGz9YZRWGrXDP3+rBti57r/rIWAYSgdccohb1TG0B8I=; b=ry5zBzZaSOkXGXBnGQiDZ0172TYmdwVl78pws6TfPQORyWGqqJz9pIKfziUR16xHDP /dvqQZDUeIXvfQt8BxGlIzRqjfweVHtx5zCiCVsrQ3cG9sCuA/wnGYJZQjaYaEHpqi6k RfKYfB/nD3+KPulJEH8gZ9ZRV3f9xE9iXopic3/ii1HOe8DkLnZXfbDWaTMcmnNTDhfv ViPxZt/llbz56Ttt8CkARwh4qf+E6Mw/e0bnnZCGqYrIHBkNBkIvxC7A1sr2z6VGwAhq 9u8lL2jbsX6pD78OoClnlWIPCOE9G9Tk6ixdPHWQPvxsQg3HkGk5jlZhzA5uvx+1UsXK xiJw== X-Gm-Message-State: APjAAAWTTwQjjkRxEwfHerXZ2/FysIkrdUWBrRmGx62A30vQTjGGzlDP V7Mn/cCDTvsBGhIIWyLYvsQ= X-Google-Smtp-Source: APXvYqzpSyJpLRaVAgZUm55R+RzbfwVdxBDRgnTZaTiqrvGzjjdXcmzad2F2Vwi7GG4svIs2vUqHzw== X-Received: by 2002:adf:cd04:: with SMTP id w4mr15719868wrm.25.1552178076929; Sat, 09 Mar 2019 16:34:36 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Laurent Vivier , Richard Henderson Date: Sun, 10 Mar 2019 01:34:27 +0100 Message-Id: <20190310003428.11723-6-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190310003428.11723-1-f4bug@amsat.org> References: <20190310003428.11723-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH 5/6] target/m68k: Optimize rotate_x() using extract_i32() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Optimize rotate_x() using tcg_gen_extract_i32(). We can now free the 'sz' tcg_temp earlier. Since it is allocated with tcg_const_i32(), free it with tcg_temp_free_i32(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/m68k/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index f43ac07b7f..b51b8a2a12 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -3686,6 +3686,7 @@ static TCGv rotate_x(TCGv reg, TCGv shift, int left, = int size) tcg_gen_sub_i32(shl, shl, shift); /* shl =3D size + 1 - shift */ tcg_gen_sub_i32(shx, sz, shift); /* shx =3D size - shift */ } + tcg_temp_free_i32(sz); =20 /* reg =3D (reg << shl) | (reg >> shr) | (x << shx); */ =20 @@ -3701,9 +3702,7 @@ static TCGv rotate_x(TCGv reg, TCGv shift, int left, = int size) /* X =3D (reg >> size) & 1 */ =20 X =3D tcg_temp_new(); - tcg_gen_shr_i32(X, reg, sz); - tcg_gen_andi_i32(X, X, 1); - tcg_temp_free(sz); + tcg_gen_extract_i32(X, reg, size, 1); =20 return X; } --=20 2.19.1 From nobody Sun Nov 9 21:33:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552178461621973.7697140929063; Sat, 9 Mar 2019 16:41:01 -0800 (PST) Received: from localhost ([127.0.0.1]:38160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mWQ-00084T-8s for importer@patchew.org; Sat, 09 Mar 2019 19:40:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mQK-0003OO-7M for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2mQJ-0001I6-6r for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:40 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:33763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2mQJ-0001H3-0O for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:39 -0500 Received: by mail-wr1-x443.google.com with SMTP id i8so1291180wrm.0 for ; Sat, 09 Mar 2019 16:34:38 -0800 (PST) Received: from x1.local (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 12sm29164462wme.25.2019.03.09.16.34.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 16:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VwkVuDXOE1qqDiObBHK25pvVhgEHDqOLPb9q+LOY5J8=; b=DNHlMhEkF/5WTq7QGf45CnJ7LZvJ3wvAOuhbk20Y1zWpTsUuoecXKTVZtZEoANLp1C wy7qOSlvNwuMHCs5RlVcRVdeQE0ioGNX8RI3NNsOgNGSdPJAmaetC7S539aLpIjUBW7h BdDi5bb7+VIYVTpZYQaO/0oOoREnOp0yHpYtD74YAfyQd0EWlKiqEjzL7NjZtcqV3vVc PzY+WWKmE1bIxu6H99O4oV9jPeK4DKrFdSxbgkx3TEiJ3kiqdIUo+grXyYD7E9uBHdbd FS/luramUkPcqHf01eLxlvfgwt+oxZvx/vV8uyDXmfKYFMEakBL5R4NieSdcjYSeKIwE 1Gsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VwkVuDXOE1qqDiObBHK25pvVhgEHDqOLPb9q+LOY5J8=; b=B1Hi7lrkvZCpDuum0HVGY6ldgSfFD7B6xyWjsuItQvlJteSLKz0vWUZm6u19srLr+H JhT/pQxTTT+GG3XjQkJcGMbhly2kwEti3hga6W4GA5dcUvPEQnCZq9Dc11e/BYPrZWms 6LW9aW7RkYEeRpiP+BtzKv97+ZIAdlNx6o86lkB9+xNl6m96iW8WETfFz0qK65bxuo5Y nMDUeJfff4GCeLh6H7RIq4Cbdysclbg2X2VuzX1TtP2g3jRovKUa7x7+cw+EymBYxuwQ ugUy6ks9ZpdDkeo+S2y7pPXTzTOuCbpD8DjCN7BPtJgJZ0taynjt6i9RvMH0/vM2AIE8 ObVQ== X-Gm-Message-State: APjAAAXDoiCF6cnv0OK8A9MZNlUt1IafLHCATXF0eKrZmFhQHWBCxLTu WmQkX1GKVlGFDlFJaYKXrIs= X-Google-Smtp-Source: APXvYqy5ONk1rvjgFHFQkgYlXI4OtPdoWEiY21CWmb52HdwzGmyyS8XrR7mcwaAf22Z+kM5sUV8ffA== X-Received: by 2002:a5d:52ca:: with SMTP id r10mr16273171wrv.187.1552178078107; Sat, 09 Mar 2019 16:34:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Laurent Vivier , Richard Henderson Date: Sun, 10 Mar 2019 01:34:28 +0100 Message-Id: <20190310003428.11723-7-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190310003428.11723-1-f4bug@amsat.org> References: <20190310003428.11723-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH 6/6] target/m68k: Reduce the scope of the 'zero' tcg_temp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Reduce the scope of the 'zero' tcg_temp. Since this tcg_temp is allocated with tcg_const_i32(), free it using tcg_temp_free_i32(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index b51b8a2a12..3f27079379 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -3664,7 +3664,7 @@ static void rotate_x_flags(TCGv reg, TCGv X, int size) /* Result of rotate_x() is valid if 0 <=3D shift <=3D size */ static TCGv rotate_x(TCGv reg, TCGv shift, int left, int size) { - TCGv X, shl, shr, shx, sz, zero; + TCGv X, shl, shr, shx, sz; =20 sz =3D tcg_const_i32(size); =20 @@ -3672,14 +3672,14 @@ static TCGv rotate_x(TCGv reg, TCGv shift, int left= , int size) shl =3D tcg_temp_new(); shx =3D tcg_temp_new(); if (left) { + TCGv zero =3D tcg_const_i32(0); tcg_gen_mov_i32(shl, shift); /* shl =3D shift */ tcg_gen_movi_i32(shr, size + 1); tcg_gen_sub_i32(shr, shr, shift); /* shr =3D size + 1 - shift */ tcg_gen_subi_i32(shx, shift, 1); /* shx =3D shift - 1 */ /* shx =3D shx < 0 ? size : shx; */ - zero =3D tcg_const_i32(0); tcg_gen_movcond_i32(TCG_COND_LT, shx, shx, zero, sz, shx); - tcg_temp_free(zero); + tcg_temp_free_i32(zero); } else { tcg_gen_mov_i32(shr, shift); /* shr =3D shift */ tcg_gen_movi_i32(shl, size + 1); --=20 2.19.1