From nobody Sun Nov 9 20:19:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552061330643718.1461517933433; Fri, 8 Mar 2019 08:08:50 -0800 (PST) Received: from localhost ([127.0.0.1]:46171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2I37-0006SR-2P for importer@patchew.org; Fri, 08 Mar 2019 11:08:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2I26-00063U-H5 for qemu-devel@nongnu.org; Fri, 08 Mar 2019 11:07:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2I25-0007P7-Sp for qemu-devel@nongnu.org; Fri, 08 Mar 2019 11:07:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11040) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h2I25-0007OL-MH for qemu-devel@nongnu.org; Fri, 08 Mar 2019 11:07:37 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 886B7F3FAD for ; Fri, 8 Mar 2019 16:07:36 +0000 (UTC) Received: from localhost (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFCF2608AB; Fri, 8 Mar 2019 16:07:32 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Fri, 8 Mar 2019 17:07:31 +0100 Message-Id: <20190308160731.23312-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 08 Mar 2019 16:07:36 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] migration: fix small leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Spotted by ASAN, during make check. Fixes: 9aca82ba3108d15529a2e0f5b0996cac309a7216 ("migration: Create socket-address parameter") Cc: Juan Quintela Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Xu --- migration/migration.h | 2 +- migration/migration.c | 2 +- migration/socket.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index 99e99e56bd..1b10b19a67 100644 --- a/migration/migration.h +++ b/migration/migration.h @@ -308,7 +308,7 @@ void migrate_send_rp_resume_ack(MigrationIncomingState = *mis, uint32_t value); =20 void dirty_bitmap_mig_before_vm_start(void); void init_dirty_bitmap_incoming_migration(void); -void migrate_add_address(SocketAddress *address); +void migrate_add_address(const SocketAddress *address); =20 int foreach_not_ignored_block(RAMBlockIterFunc func, void *opaque); =20 diff --git a/migration/migration.c b/migration/migration.c index df6fd8e0e5..9cc2036796 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -335,7 +335,7 @@ void migration_incoming_enable_colo(void) migration_colo_enabled =3D true; } =20 -void migrate_add_address(SocketAddress *address) +void migrate_add_address(const SocketAddress *address) { MigrationIncomingState *mis =3D migration_incoming_get_current(); SocketAddressList *addrs; diff --git a/migration/socket.c b/migration/socket.c index 239527fb1f..49bacf78fd 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -199,6 +199,7 @@ static void socket_start_incoming_migration(SocketAddre= ss *saddr, return; } migrate_add_address(address); + qapi_free_SocketAddress(address); } } =20 --=20 2.21.0.4.g36eb1cb9cf