Type: series
Message-id: 20190308125823.32535-1-kwolf@redhat.com
Subject: [Qemu-devel] [PULL 00/33] Block layer patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190308125823.32535-1-kwolf@redhat.com -> patchew/20190308125823.32535-1-kwolf@redhat.com
Switched to a new branch 'test'
4bb6226f2f qcow2 spec: Describe string header extensions
615652354e qemu-iotests: Add dependency to qemu-nbd tool
bb7df6697f ahci-test: Add dependency to qemu-img tool
9e3c778958 qemu-iotests: amend with external data file
ccb66c8914 qemu-iotests: General tests for qcow2 with external data file
cede04e7d6 qemu-iotests: Preallocation with external data file
6a8336715b qcow2: Implement data-file-raw create option
c1a4c1383e qcow2: Store data file name in the image
bfdea0ab40 qcow2: Creating images with external data file
5ce421feac qcow2: Add basic data-file infrastructure
4b3216710b qcow2: Support external data file in qemu-img check
b016112b72 qcow2: Return error for snapshot operation with data file
ea86017d4a qcow2: External file I/O
4711358cec qcow2: Prepare qcow2_co_block_status() for data file
6104835f98 qcow2: Return 0/-errno in qcow2_alloc_compressed_cluster_offset()
b2e920c0da qcow2: Don't assume 0 is an invalid cluster offset
936fb9acb6 qcow2: Prepare count_contiguous_clusters() for external data file
74abbbbb5c qcow2: Prepare qcow2_get_cluster_type() for external data file
3c010fea65 qcow2: Pass bs to qcow2_get_cluster_type()
12a30eba73 qcow2: Basic definitions for external data files
353b4c8be4 qcow2: Extend spec for external data files
1fce7e36ba qcow2: Simplify preallocation code
8ad238a072 qemu-iotests: Test qcow2 preallocation modes
e2459b19a2 qemu-iotests: Ensure GNU sed is used
3cb3e9c79e qemu-iotests: Improve portability by searching bash in the $PATH
4b820b2b6f tests/bios-tables: Improve portability by searching bash in the $PATH
d298d1526b tests/multiboot: Improve portability by searching bash in the $PATH
cf6a77287e iotests: check whitelisted formats
f1976b9982 iotests: ask QEMU for supported formats
9e854b4f66 block: iterate_format with account of whitelisting
fc2570bf3e iotests: open notrun files in text mode
e494e1ce33 qcow2: Default to 4KB for the qcow2 cache entry size
94b513a92e iotests: use iotests.VM in 238

=== OUTPUT BEGIN ===
1/33 Checking commit 94b513a92e25 (iotests: use iotests.VM in 238)
2/33 Checking commit e494e1ce336f (qcow2: Default to 4KB for the qcow2 cache entry size)
3/33 Checking commit fc2570bf3e74 (iotests: open notrun files in text mode)
4/33 Checking commit 9e854b4f664c (block: iterate_format with account of whitelisting)
5/33 Checking commit f1976b998299 (iotests: ask QEMU for supported formats)
6/33 Checking commit cf6a77287eeb (iotests: check whitelisted formats)
7/33 Checking commit d298d1526b59 (tests/multiboot: Improve portability by searching bash in the $PATH)
8/33 Checking commit 4b820b2b6f0d (tests/bios-tables: Improve portability by searching bash in the $PATH)
9/33 Checking commit 3cb3e9c79e71 (qemu-iotests: Improve portability by searching bash in the $PATH)
10/33 Checking commit e2459b19a22c (qemu-iotests: Ensure GNU sed is used)
11/33 Checking commit 8ad238a072fa (qemu-iotests: Test qcow2 preallocation modes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
new file mode 100755

total: 0 errors, 1 warnings, 93 lines checked

Patch 11/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/33 Checking commit 1fce7e36bab2 (qcow2: Simplify preallocation code)
13/33 Checking commit 353b4c8be4b8 (qcow2: Extend spec for external data files)
14/33 Checking commit 12a30eba7358 (qcow2: Basic definitions for external data files)
WARNING: line over 80 characters
#86: FILE: block/qcow2.h:224:
+    QCOW2_AUTOCLEAR_DATA_FILE_RAW       = 1 << QCOW2_AUTOCLEAR_DATA_FILE_RAW_BITNR,

total: 0 errors, 1 warnings, 187 lines checked

Patch 14/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/33 Checking commit 3c010fea653f (qcow2: Pass bs to qcow2_get_cluster_type())
WARNING: line over 80 characters
#213: FILE: block/qcow2-refcount.c:1871:
+            QCow2ClusterType cluster_type = qcow2_get_cluster_type(bs, l2_entry);

total: 0 errors, 1 warnings, 188 lines checked

Patch 15/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/33 Checking commit 74abbbbb5c25 (qcow2: Prepare qcow2_get_cluster_type() for external data file)
WARNING: Block comments use a leading /* on a separate line
#19: FILE: block/qcow2.h:524:
+        /* Offset 0 generally means unallocated, but it is ambiguous with

WARNING: Block comments use a trailing */ on a separate line
#22: FILE: block/qcow2.h:527:
+         * rely on QCOW_OFLAG_COPIED to disambiguate. */

total: 0 errors, 2 warnings, 16 lines checked

Patch 16/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/33 Checking commit 936fb9acb6c6 (qcow2: Prepare count_contiguous_clusters() for external data file)
18/33 Checking commit b2e920c0dab5 (qcow2: Don't assume 0 is an invalid cluster offset)
19/33 Checking commit 6104835f982f (qcow2: Return 0/-errno in qcow2_alloc_compressed_cluster_offset())
20/33 Checking commit 4711358cec4c (qcow2: Prepare qcow2_co_block_status() for data file)
21/33 Checking commit ea86017d4a54 (qcow2: External file I/O)
WARNING: Block comments use a leading /* on a separate line
#413: FILE: block/qcow2.c:3591:
+        /* With a data file, preallocation means just allocating the metadata

WARNING: Block comments use a trailing */ on a separate line
#414: FILE: block/qcow2.c:3592:
+         * and forwarding the truncate request to the data file */

total: 0 errors, 2 warnings, 417 lines checked

Patch 21/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/33 Checking commit b016112b727c (qcow2: Return error for snapshot operation with data file)
23/33 Checking commit 4b3216710b0e (qcow2: Support external data file in qemu-img check)
24/33 Checking commit 5ce421feaca7 (qcow2: Add basic data-file infrastructure)
25/33 Checking commit bfdea0ab4078 (qcow2: Creating images with external data file)
26/33 Checking commit c1a4c1383ebd (qcow2: Store data file name in the image)
27/33 Checking commit 6a8336715bac (qcow2: Implement data-file-raw create option)
WARNING: Block comments use a leading /* on a separate line
#25: FILE: block/qcow2-cluster.c:1786:
+    /* If we have to stay in sync with an external data file, zero out

WARNING: Block comments use a trailing */ on a separate line
#26: FILE: block/qcow2-cluster.c:1787:
+     * s->data_file first. */

WARNING: Block comments use a leading /* on a separate line
#63: FILE: block/qcow2.c:2615:
+    /* Adding a backing file means that the external data file alone won't be

WARNING: Block comments use a trailing */ on a separate line
#64: FILE: block/qcow2.c:2616:
+     * enough to make sense of the content */

total: 0 errors, 4 warnings, 382 lines checked

Patch 27/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/33 Checking commit cede04e7d602 (qemu-iotests: Preallocation with external data file)
29/33 Checking commit ccb66c891473 (qemu-iotests: General tests for qcow2 with external data file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100755

total: 0 errors, 1 warnings, 329 lines checked

Patch 29/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/33 Checking commit 9e3c778958f5 (qemu-iotests: amend with external data file)
31/33 Checking commit bb7df6697f5f (ahci-test: Add dependency to qemu-img tool)
32/33 Checking commit 615652354e73 (qemu-iotests: Add dependency to qemu-nbd tool)
33/33 Checking commit 4bb6226f2fc2 (qcow2 spec: Describe string header extensions)
=== OUTPUT END ===

Test command exited with code: 0