From nobody Sun Nov 9 20:21:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551989660425683.0402046768719; Thu, 7 Mar 2019 12:14:20 -0800 (PST) Received: from localhost ([127.0.0.1]:59005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zP9-0006ua-Sa for importer@patchew.org; Thu, 07 Mar 2019 15:14:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zNr-0006Hw-0F for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1zNq-0001yH-Ak for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:50 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:39468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1zNq-0001xO-3B for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:50 -0500 Received: by mail-pf1-x442.google.com with SMTP id i20so12289261pfo.6 for ; Thu, 07 Mar 2019 12:12:50 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id h126sm18567484pfc.135.2019.03.07.12.12.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 12:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hUIwo5oMb7uZbiT38UJGxEQTjQHyGRKs7fFvsrLbEyY=; b=e4jNmMIYyd16D2oHclzMSZdXtLyg+JF92FdlO4x8tJWfdbwrg2qqzavwOjWvAyJT86 0O0a1fOkYnZazCsVTSyoZjO+B2tfSamJ/vGnKj8JjYZQnozRiWovdheILQxaLkdSqmm4 Fyxixq98yDwXQP1qOIwIcKwSd3Klpfc57I+rcbeN1qUkPtIIZTwzdKXefzy9bSAP36Hr bo2yci5GTIkgFVPX2Ws8IzuvoeARU0x/ypCFozXjO/lyhRdp/oJp9CLQLiZ3YNIhOTM9 ahHck+q08/LlaFjYEKYtGkvw/oEDe1II9Ddoy5DRVqPDKjceJjG7DW4n0ZxujK0obrL0 pH/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hUIwo5oMb7uZbiT38UJGxEQTjQHyGRKs7fFvsrLbEyY=; b=M5e04dugnbApt0uAlD/bpaFpLosH8cgxmrfwwBHMAPsenkmtWcEiuyoO1wxl3pqELO 2lTNLzAS4d7imEM0lKzwW2sH7UEsF+S7gAjv4SdCgFbCEgKQBxDH1Wkfr4ywXJzXlxdE TU2o4VyZU2V4oduZpR05XJYLJrOCpdSxfiKHXinzr5KzW8NDCgIRk0IajR8jqq495gTE TvJAheC4heTq7E9sN3E/6sSpQwjyrmTXKVY7wndYs7LUbvwQna2wtPK8oyzaKvEDROvj FCw9dKVbUU3xCaSQbP0hjcWt8H0gPy3vXuKezpI+h0zs8jww+XBSQZ3xxBsDA62iY64c Dydw== X-Gm-Message-State: APjAAAXpGMdTZeAbdcCKSM+WPJU9VW46e+XsQVxHwRHYBCVpy/lzatq0 bUG/0fRYJ+xpYjCpytOGIPQ6ABz7aUQ= X-Google-Smtp-Source: APXvYqy3gBl8pckDRLxDcB4EhhhsX893JtfwbPpFlfsYxOwbBFyhvI0fwRatKzhaiFSynZ51SiKKYw== X-Received: by 2002:a17:902:8d97:: with SMTP id v23mr14211979plo.274.1551989568410; Thu, 07 Mar 2019 12:12:48 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 12:12:43 -0800 Message-Id: <20190307201244.8971-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307201244.8971-1-richard.henderson@linaro.org> References: <20190307201244.8971-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 Subject: [Qemu-devel] [PATCH 1/2] target/arm: Put system registers in "system" group X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The system group is predefined within gdb. While the spec seems to allow arbitrary group names, that seems to mess up the addition of all registers to any groups. Signed-off-by: Richard Henderson --- target/arm/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index 0c64c0292e..67c8874b3b 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -113,7 +113,7 @@ static void arm_gen_one_xml_reg_tag(GString *s, Dynamic= GDBXMLInfo *dyn_xml, { g_string_append_printf(s, "name); g_string_append_printf(s, " bitsize=3D\"%d\"", bitsize); - g_string_append_printf(s, " group=3D\"cp_regs\"/>"); + g_string_append_printf(s, " group=3D\"system\"/>"); dyn_xml->num_cpregs++; dyn_xml->cpregs_keys[dyn_xml->num_cpregs - 1] =3D ri_key; } --=20 2.17.2 From nobody Sun Nov 9 20:21:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551989753438220.351871760451; Thu, 7 Mar 2019 12:15:53 -0800 (PST) Received: from localhost ([127.0.0.1]:59050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zQh-0008Bg-S8 for importer@patchew.org; Thu, 07 Mar 2019 15:15:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1zNs-0006IA-5a for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1zNr-0001z9-J3 for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:52 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:35112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1zNr-0001yX-BX for qemu-devel@nongnu.org; Thu, 07 Mar 2019 15:12:51 -0500 Received: by mail-pf1-x443.google.com with SMTP id j5so12296868pfa.2 for ; Thu, 07 Mar 2019 12:12:51 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id h126sm18567484pfc.135.2019.03.07.12.12.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 12:12:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=efdSzmGfbpW7WQYecr4f/sOH11ZNMvPyJ3hMSinoX5c=; b=saBm9G9kQfPAjSDBx+xBQ4v7Um/5Iw+yU1Ys1jF4wmiLg3G3FJLRZUzxa2xwr3nvTw mWfWwwfyHXo7FY98utrxTgyJtjvlZko/xz/P8AC2yBURucokJX0XaL8VXJc851RAnRZv yPpuLA/FeTx1X3S5Xzip0HvweZTcRDBaoG1USBlKgjETUm8FSdvhNAa39odw2eacZPCm hBoMRs6NujZiaWzqtQ7zVvZ2PywuedrGrYC5uzHaOnTkikj4v8Bt1HJ4mqmohtJcirY/ /izfl/od452E36cktWqhKmzcYXss+jX++R7fWxhoeeM6hZ/vDosVbieHbrNsbLmQi8jQ wT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=efdSzmGfbpW7WQYecr4f/sOH11ZNMvPyJ3hMSinoX5c=; b=npa50rkFbIPEuK/J0+e0HNroRNlFE78nOrssoeFXRPEIY9piQbvQTdUCMKfPK1CDLZ qM2QHtWaSuS8oGeByHB8cH3AoPjdU0Z3E+Quo7xlVoidw+4g7K/xZcoA8QCwKNrDaZ/C 1xk8/0+v1vHCtdNkNxlYw5d5VTBN43cciGyCGeawf3D6A6iymu6CV1IhztJ8VH+ySiMH 5m9Cv+BwfAOUnh8fhxzTwhjC4M8p6fQqhEm9WOKa5SaMH4jVLmtp3xAelEcp3auMBILv Z6+QeCzP5rAcMb8Tvm2US7RoOV+ag1Bs4O/renUqX1Mgkfc9/J8sVbj9Lb909l/ded2A 2URw== X-Gm-Message-State: APjAAAVnoI79fH9BfsO2bcugZLozGh8/u1SVJ80YrhU/rNCbIAivvG0+ eHXwL0gJtaGS0a/aqClNmaQgU1Ffsrg= X-Google-Smtp-Source: APXvYqzcx8XX4rje+90QQguEOkuxCwtK7J0z2Lpsyi+mQPfsjjSdhfxVGUU4BAYnjkYRCGw37M5EXA== X-Received: by 2002:a65:5c01:: with SMTP id u1mr13046252pgr.197.1551989569876; Thu, 07 Mar 2019 12:12:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 12:12:44 -0800 Message-Id: <20190307201244.8971-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307201244.8971-1-richard.henderson@linaro.org> References: <20190307201244.8971-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH 2/2] target/arm: Don't add system-registers.xml for user-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The system registers aren't that interesting for debugging user binaries. Avoid adding them in this case. Signed-off-by: Richard Henderson --- target/arm/helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 2607d39ad1..ca5632d26f 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -221,6 +221,7 @@ static void write_raw_cp_reg(CPUARMState *env, const AR= MCPRegInfo *ri, } } =20 +#ifndef CONFIG_USER_ONLY static int arm_gdb_get_sysreg(CPUARMState *env, uint8_t *buf, int reg) { ARMCPU *cpu =3D arm_env_get_cpu(env); @@ -243,6 +244,7 @@ static int arm_gdb_set_sysreg(CPUARMState *env, uint8_t= *buf, int reg) { return 0; } +#endif =20 static bool raw_accessors_invalid(const ARMCPRegInfo *ri) { @@ -6694,9 +6696,11 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *= cpu) gdb_register_coprocessor(cs, vfp_gdb_get_reg, vfp_gdb_set_reg, 19, "arm-vfp.xml", 0); } +#ifndef CONFIG_USER_ONLY gdb_register_coprocessor(cs, arm_gdb_get_sysreg, arm_gdb_set_sysreg, arm_gen_dynamic_xml(cs), "system-registers.xml", 0); +#endif } =20 /* Sort alphabetically by type name, except for "any". */ --=20 2.17.2