From nobody Tue Feb 10 15:28:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551970598710775.6033423374374; Thu, 7 Mar 2019 06:56:38 -0800 (PST) Received: from localhost ([127.0.0.1]:53197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1uRm-0002Di-E5 for importer@patchew.org; Thu, 07 Mar 2019 09:56:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1uDJ-0006oe-Qo for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1uDI-0003XF-WE for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:37 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:39259) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1uDI-0003Wk-Oy for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:36 -0500 Received: by mail-pg1-x544.google.com with SMTP id h8so11414959pgp.6 for ; Thu, 07 Mar 2019 06:41:36 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id p2sm6222838pgs.7.2019.03.07.06.41.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 06:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eu3UcP6XYcEcl5Ty9GSI2+W4Hww6Yf+5rGz/kG2iBME=; b=Ul4DdExqLJVgxo2SFABsdWSRA8W6xTZGHff8KB3Gd1mx7dK+XCe9FT321+Qahlw5At tunxOdPVLeph+Z0rgAv3EnegXB3KG+bDbIJy6Pp6BvpOt+BjXYFL4/JFw2YDyuVf6kg/ FlaI/PkS3CJ7h4OJXlv/hZ8X+5Kn0bTnxx6HrrDEH0oGxXkm+votZn4loRPKdXaX2gdD 2iR8nBl+JePlQDK12GCRTYpL84Xb36YTqoqf5OaEYfaC5pVCYO8hU6S5a3Jdywz5Ct4G HFuj5IUtMdVfbWlbYZxKXxPT8Y/VRTRjLRrN+XjSZoZcBnYgpEJ22pTLX27O4T1yPTmp tiog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eu3UcP6XYcEcl5Ty9GSI2+W4Hww6Yf+5rGz/kG2iBME=; b=RsKJXjJx3XiPsV7OCCSiDzB6h3BHTxT61EoPVxFxPZpNUS4AM/hA9zI8wMHqU1GKI5 e90DWo6zEqakoFsmJgLau0ZOOZMpNvtmffex7qzd7qwnHKaok5ZQwW5RMmuDC9Y05kb0 MP2dFtJ0PgaM7oChTQmelQCKQDiYbMyY7fClCt5f4sGGBURPCXXyJ92gH4oYlHvKU+QP KnIZ3DA2s+y0Ev7hYHVI9okOkbKaoiclS22KcvNuu+LRrrJtJC/QTfatqUxBF4OgUor5 ZxVSfbg02unBLCYI+HDs0EsO30SOSt2/ryn2dsy6Y7Judee75tgCcVOYq+Fsg59/92v0 s1mQ== X-Gm-Message-State: APjAAAUTNPuJaECRYxxgDapDfpOaoJpuOcK+TjiD2e1OojXFWM63M/wJ 30qdv9B/aQk5R6VjYynKitYE7QHxpHU= X-Google-Smtp-Source: APXvYqwBjAjmdsIjeOevsjKJmVj2Cb7kXmsEucIO5F6ZH7cvsmL7bbRnf0IAqZGseXAzlIz3jqoeVA== X-Received: by 2002:a62:ea0f:: with SMTP id t15mr13288137pfh.124.1551969695523; Thu, 07 Mar 2019 06:41:35 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 06:41:23 -0800 Message-Id: <20190307144126.31847-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307144126.31847-1-richard.henderson@linaro.org> References: <20190307144126.31847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 Subject: [Qemu-devel] [PATCH 6/9] tcg/arm: Support INDEX_op_extract2_i32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tcg/arm/tcg-target.h | 2 +- tcg/arm/tcg-target.inc.c | 25 +++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h index 4ee6c98958..17e771374d 100644 --- a/tcg/arm/tcg-target.h +++ b/tcg/arm/tcg-target.h @@ -116,7 +116,7 @@ extern bool use_idiv_instructions; #define TCG_TARGET_HAS_deposit_i32 use_armv7_instructions #define TCG_TARGET_HAS_extract_i32 use_armv7_instructions #define TCG_TARGET_HAS_sextract_i32 use_armv7_instructions -#define TCG_TARGET_HAS_extract2_i32 0 +#define TCG_TARGET_HAS_extract2_i32 1 #define TCG_TARGET_HAS_movcond_i32 1 #define TCG_TARGET_HAS_mulu2_i32 1 #define TCG_TARGET_HAS_muls2_i32 1 diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index 2245a8aeb9..6873b0cf95 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/arm/tcg-target.inc.c @@ -2064,6 +2064,27 @@ static inline void tcg_out_op(TCGContext *s, TCGOpco= de opc, case INDEX_op_sextract_i32: tcg_out_sextract(s, COND_AL, args[0], args[1], args[2], args[3]); break; + case INDEX_op_extract2_i32: + /* ??? These optimization vs zero should be generic. */ + /* ??? But we can't substitute 2 for 1 in the opcode stream yet. = */ + if (const_args[1]) { + if (const_args[2]) { + tcg_out_movi(s, TCG_TYPE_REG, args[0], 0); + } else { + tcg_out_dat_reg(s, COND_AL, ARITH_MOV, args[0], 0, + args[2], SHIFT_IMM_LSL(32 - args[3])); + } + } else if (const_args[2]) { + tcg_out_dat_reg(s, COND_AL, ARITH_MOV, args[0], 0, + args[1], SHIFT_IMM_LSR(args[3])); + } else { + /* We can do extract2 in 2 insns, vs the 3 required otherwise.= */ + tcg_out_dat_reg(s, COND_AL, ARITH_MOV, TCG_REG_TMP, 0, + args[2], SHIFT_IMM_LSL(32 - args[3])); + tcg_out_dat_reg(s, COND_AL, ARITH_ORR, args[0], TCG_REG_TMP, + args[1], SHIFT_IMM_LSR(args[3])); + } + break; =20 case INDEX_op_div_i32: tcg_out_sdiv(s, COND_AL, args[0], args[1], args[2]); @@ -2108,6 +2129,8 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpc= ode op) =3D { .args_ct_str =3D { "s", "s", "s", "s" } }; static const TCGTargetOpDef br =3D { .args_ct_str =3D { "r", "rIN" } }; + static const TCGTargetOpDef ext2 + =3D { .args_ct_str =3D { "r", "rZ", "rZ" } }; static const TCGTargetOpDef dep =3D { .args_ct_str =3D { "r", "0", "rZ" } }; static const TCGTargetOpDef movc @@ -2174,6 +2197,8 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpc= ode op) return &br; case INDEX_op_deposit_i32: return &dep; + case INDEX_op_extract2_i32: + return &ext2; case INDEX_op_movcond_i32: return &movc; case INDEX_op_add2_i32: --=20 2.17.2