From nobody Sun Nov 9 21:51:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551959828003830.3030277618118; Thu, 7 Mar 2019 03:57:08 -0800 (PST) Received: from localhost ([127.0.0.1]:49812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1rds-0003dV-FF for importer@patchew.org; Thu, 07 Mar 2019 06:56:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1rZ0-0008NJ-2Z for qemu-devel@nongnu.org; Thu, 07 Mar 2019 06:51:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1rYz-0003UX-3U for qemu-devel@nongnu.org; Thu, 07 Mar 2019 06:51:50 -0500 Received: from hera.aquilenet.fr ([2a0c:e300::1]:35456) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1rYy-0003TM-Q8 for qemu-devel@nongnu.org; Thu, 07 Mar 2019 06:51:48 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AE577B16B; Thu, 7 Mar 2019 12:51:45 +0100 (CET) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LlLnkaG-AKu5; Thu, 7 Mar 2019 12:51:44 +0100 (CET) Received: from function (dhcp-13-128.lip.ens-lyon.fr [140.77.13.128]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DC0A3B15C; Thu, 7 Mar 2019 12:51:43 +0100 (CET) Received: from samy by function with local (Exim 4.92) (envelope-from ) id 1h1rYt-0000Dd-A9; Thu, 07 Mar 2019 12:51:43 +0100 X-Virus-Scanned: Debian amavisd-new at aquilenet.fr From: Samuel Thibault To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 12:51:31 +0100 Message-Id: <20190307115143.780-2-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190307115143.780-1-samuel.thibault@ens-lyon.org> References: <20190307115143.780-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a0c:e300::1 Subject: [Qemu-devel] [PULLv2 01/12] slirp: Fix build with gcc 9 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jan.kiszka@siemens.com, Samuel Thibault , Greg Kurz , stefanha@redhat.com, peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Greg Kurz Build fails with gcc 9: CC slirp/ndp_table.o slirp/ndp_table.c: In function =E2=80=98ndp_table_add=E2=80=99: slirp/ndp_table.c:31:23: error: taking address of packed member of =E2=80= =98struct ndpentry=E2=80=99 may result in an unaligned pointer value [-Werr= or=3Daddress-of-packed-member] 31 | if (in6_equal(&ndp_table->table[i].ip_addr, &ip_addr)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ slirp/ndp_table.c: In function =E2=80=98ndp_table_search=E2=80=99: slirp/ndp_table.c:75:23: error: taking address of packed member of =E2=80= =98struct ndpentry=E2=80=99 may result in an unaligned pointer value [-Werr= or=3Daddress-of-packed-member] 75 | if (in6_equal(&ndp_table->table[i].ip_addr, &ip_addr)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors The ndpentry structure isn't used to model on-the-wire data or anything else that would care for the struct layout. It doesn't need to be packed actually. Just drop SLIRP_PACKED. Signed-off-by: Greg Kurz Message-Id: <155143315831.102868.17515265400523392682.stgit@bahia.lan> Reviewed-by: Peter Maydell Signed-off-by: Samuel Thibault --- slirp/slirp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 752a4cd8c8..8068ba1d1e 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -106,7 +106,7 @@ bool arp_table_search(Slirp *slirp, uint32_t ip_addr, struct ndpentry { unsigned char eth_addr[ETH_ALEN]; /* sender hardware address */ struct in6_addr ip_addr; /* sender IP address */ -} SLIRP_PACKED; +}; =20 #define NDP_TABLE_SIZE 16 =20 --=20 2.20.1