[Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch

Markus Armbruster posted 4 patches 5 years ago
Test asan failed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190307093723.655-1-armbru@redhat.com
Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>
hw/block/pflash_cfi01.c | 41 ++++++++++++++++++++++++++++++++++-------
hw/block/pflash_cfi02.c | 40 ++++++++++++++++++++++++++++++++++------
2 files changed, 68 insertions(+), 13 deletions(-)
[Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch
Posted by Markus Armbruster 5 years ago
This is Alex's "[PATCH v5] hw/block: better reporting on pflash
backing file mismatch" with the padding split off into its own patch,
and both resulting patches applied to pflash_cfi02.c.  I downgraded it
to RFC for two reasons:

1. I think the padding patches should not be applied.  I'll reply to
PATCH 2 to explain why.

2. I left the update of pflash_cfi02.c as separate fixup patches, so
we can easily ignore them while we discuss 1.

v6:
* Split padding into its own patch.
* Delete "It should be padded to a multiple of the flash block size."
  comment.  Happy to put it back if you can enlighten me about its
  purpose.
* Improve both commit messages.
* New fixup patches to pflash_cfi02.c.

Alex Bennée (2):
  hw/block: better reporting on pflash backing file mismatch
  hw/block: Pad undersized read-only images with 0xFF

Markus Armbruster (2):
  fixup! hw/block: better reporting on pflash backing file mismatch
  fixup! hw/block: Pad undersized read-only images with 0xFF

 hw/block/pflash_cfi01.c | 41 ++++++++++++++++++++++++++++++++++-------
 hw/block/pflash_cfi02.c | 40 ++++++++++++++++++++++++++++++++++------
 2 files changed, 68 insertions(+), 13 deletions(-)

-- 
2.17.2


Re: [Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch
Posted by no-reply@patchew.org 5 years ago
Patchew URL: https://patchew.org/QEMU/20190307093723.655-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307093723.655-1-armbru@redhat.com
Subject: [Qemu-devel] [RFC PATCH v6 0/4] hw/block: better reporting on pflash backing file mismatch

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190307093723.655-1-armbru@redhat.com -> patchew/20190307093723.655-1-armbru@redhat.com
Switched to a new branch 'test'
48c4518e34 fixup! hw/block: Pad undersized read-only images with 0xFF
b542c515b5 fixup! hw/block: better reporting on pflash backing file mismatch
936dbecaad hw/block: Pad undersized read-only images with 0xFF
0a12006a6e hw/block: better reporting on pflash backing file mismatch

=== OUTPUT BEGIN ===
1/4 Checking commit 0a12006a6e45 (hw/block: better reporting on pflash backing file mismatch)
2/4 Checking commit 936dbecaade4 (hw/block: Pad undersized read-only images with 0xFF)
3/4 Checking commit b542c515b53b (fixup! hw/block: better reporting on pflash backing file mismatch)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 46 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 48c4518e348b (fixup! hw/block: Pad undersized read-only images with 0xFF)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 34 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307093723.655-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com