From nobody Sun Nov 9 20:17:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551816106074929.9348158544719; Tue, 5 Mar 2019 12:01:46 -0800 (PST) Received: from localhost ([127.0.0.1]:48572 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1GFv-0002OH-2l for importer@patchew.org; Tue, 05 Mar 2019 15:01:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1GA8-0006MV-RW for qemu-devel@nongnu.org; Tue, 05 Mar 2019 14:55:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1GA8-0005yg-9G for qemu-devel@nongnu.org; Tue, 05 Mar 2019 14:55:40 -0500 Received: from smtp.duncanthrax.net ([2001:470:70c5:1111::170]:36718) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1GA8-0005xw-13 for qemu-devel@nongnu.org; Tue, 05 Mar 2019 14:55:40 -0500 Received: from [134.3.47.207] (helo=t470p.stackframe.org) by smtp.eurescom.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1h1GA6-0004To-VI; Tue, 05 Mar 2019 20:55:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=duncanthrax.net; s=dkim; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=a9j/sIffMTSILrFz2BTa0TVHvNMYCzaT1s2lIjoCt70=; b=d66GOmKerGL39Kln4fZe37wYUT ULSqsT2oOirLP6vWbtyomcdA12rO/lXWM4NPdKLfFchKbRO3XBgLeVGK9UkuNkq7W4uvzvosweNzv RkBiM0O5DONWJR0q3Sw8qhHkA4jNufgsayUBI5IiUCrJHhhqVfDWbtKZTAUxpGbCWC2Q=; From: Sven Schnelle To: Paolo Bonzini Date: Tue, 5 Mar 2019 20:55:19 +0100 Message-Id: <20190305195519.24303-6-svens@stackframe.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190305195519.24303-1-svens@stackframe.org> References: <20190305195519.24303-1-svens@stackframe.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:70c5:1111::170 Subject: [Qemu-devel] [PATCH v2 5/5] lsi: return dfifo value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Sven Schnelle , QEMU Developers Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Code was assigning DFIFO, but didn't return the value to users. Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 7d66d1a870..3783779da6 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1688,7 +1688,7 @@ static uint8_t lsi_reg_readb(LSIState *s, int offset) break; CASE_GET_REG32(temp, 0x1c) case 0x20: /* DFIFO */ - ret =3D 0; + ret =3D s->dfifo; break; case 0x21: /* CTEST4 */ ret =3D s->ctest4; --=20 2.20.1