From nobody Sun Nov 9 17:53:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551799520715736.5313971819442; Tue, 5 Mar 2019 07:25:20 -0800 (PST) Received: from localhost ([127.0.0.1]:44439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1BwQ-0006Y1-In for importer@patchew.org; Tue, 05 Mar 2019 10:25:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1BvI-00065C-Og for qemu-devel@nongnu.org; Tue, 05 Mar 2019 10:24:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1BvI-0002Ja-1c for qemu-devel@nongnu.org; Tue, 05 Mar 2019 10:24:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61097) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1BvH-0002Dj-Ps for qemu-devel@nongnu.org; Tue, 05 Mar 2019 10:24:03 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6128B3081244; Tue, 5 Mar 2019 15:15:05 +0000 (UTC) Received: from localhost (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2987160F8D; Tue, 5 Mar 2019 15:15:01 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Tue, 5 Mar 2019 16:15:00 +0100 Message-Id: <20190305151500.25038-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 05 Mar 2019 15:15:05 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] linux-user: fix "may be used uninitialized" warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Riku Voipio , alex.bennee@linaro.org, Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Fixes: /home/elmarco/src/qemu/linux-user/syscall.c: In function =E2=80=98do_ioctl_= rt=E2=80=99: /home/elmarco/src/qemu/linux-user/syscall.c:4773:9: error: =E2=80=98host_rt= _dev_ptr=E2=80=99 may be used uninitialized in this function [-Werror=3Dmay= be-uninitialized] if (*host_rt_dev_ptr !=3D 0) { ^~~~~~~~~~~~~~~~ /home/elmarco/src/qemu/linux-user/syscall.c:4774:9: error: =E2=80=98target_= rt_dev_ptr=E2=80=99 may be used uninitialized in this function [-Werror=3Dm= aybe-uninitialized] unlock_user((void *)*host_rt_dev_ptr, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ *target_rt_dev_ptr, 0); ~~~~~~~~~~~~~~~~~~~~~~ Based on previous discussion from patch "linux-users/syscall: make do_ioctl_rt safer" by Alex Benn=C3=A9e. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5bbb72f3d5..a15340b302 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -4723,8 +4723,8 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uin= t8_t *buf_temp, const int *dst_offsets, *src_offsets; int target_size; void *argptr; - abi_ulong *target_rt_dev_ptr; - unsigned long *host_rt_dev_ptr; + abi_ulong *target_rt_dev_ptr =3D NULL; + unsigned long *host_rt_dev_ptr =3D NULL; abi_long ret; int i; =20 @@ -4770,6 +4770,9 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uin= t8_t *buf_temp, unlock_user(argptr, arg, 0); =20 ret =3D get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp)); + + assert(host_rt_dev_ptr !=3D NULL); + assert(target_rt_dev_ptr !=3D NULL); if (*host_rt_dev_ptr !=3D 0) { unlock_user((void *)*host_rt_dev_ptr, *target_rt_dev_ptr, 0); --=20 2.21.0