From nobody Sun Nov 9 20:19:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551633964288760.469870409832; Sun, 3 Mar 2019 09:26:04 -0800 (PST) Received: from localhost ([127.0.0.1]:42149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0Us8-00066V-SA for importer@patchew.org; Sun, 03 Mar 2019 12:25:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0UqA-0004vl-Vu for qemu-devel@nongnu.org; Sun, 03 Mar 2019 12:23:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0UqA-0001qG-1C for qemu-devel@nongnu.org; Sun, 03 Mar 2019 12:23:54 -0500 Received: from mail.default.ilande.uk0.bigv.io ([2001:41c9:1:41f::167]:42478) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h0Uq9-0001ot-PP; Sun, 03 Mar 2019 12:23:53 -0500 Received: from host86-184-243-112.range86-184.btcentralplus.com ([86.184.243.112] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1h0Uq7-0003k5-7t; Sun, 03 Mar 2019 17:23:51 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, richard.henderson@linaro.org Date: Sun, 3 Mar 2019 17:23:39 +0000 Message-Id: <20190303172343.13406-5-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190303172343.13406-1-mark.cave-ayland@ilande.co.uk> References: <20190303172343.13406-1-mark.cave-ayland@ilande.co.uk> X-SA-Exim-Connect-IP: 86.184.243.112 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:41c9:1:41f::167 Subject: [Qemu-devel] [PATCH 4/8] target/ppc: introduce avrh_offset() and avrl_offset() functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" These will become more useful later, but initially use this as an aid to simplify the offset calculation by replacing the HOST_TARGET_BIGENDIAN sections with the VsrD macro. Signed-off-by: Mark Cave-Ayland --- target/ppc/cpu.h | 10 ++++++++++ target/ppc/translate.c | 24 ++++++++++-------------- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index d0580c6b6d..326593e0e7 100644 --- a/target/ppc/cpu.h +++ b/target/ppc/cpu.h @@ -2603,6 +2603,16 @@ static inline uint64_t *cpu_vsrl_ptr(CPUPPCState *en= v, int i) return (uint64_t *)((uintptr_t)env + vsrl_offset(i)); } =20 +static inline int avrh_offset(int i) +{ + return offsetof(CPUPPCState, vsr[32 + i].VsrD(0)); +} + +static inline int avrl_offset(int i) +{ + return offsetof(CPUPPCState, vsr[32 + i].VsrD(1)); +} + static inline ppc_avr_t *cpu_avr_ptr(CPUPPCState *env, int i) { return &env->vsr[32 + i]; diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3b1992faf1..f646f359e7 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -6687,24 +6687,20 @@ static inline void set_fpr(int regno, TCGv_i64 src) =20 static inline void get_avr64(TCGv_i64 dst, int regno, bool high) { -#ifdef HOST_WORDS_BIGENDIAN - tcg_gen_ld_i64(dst, cpu_env, offsetof(CPUPPCState, - vsr[32 + regno].u64[(high ? 0 : = 1)])); -#else - tcg_gen_ld_i64(dst, cpu_env, offsetof(CPUPPCState, - vsr[32 + regno].u64[(high ? 1 : = 0)])); -#endif + if (high) { + tcg_gen_ld_i64(dst, cpu_env, avrh_offset(regno)); + } else { + tcg_gen_ld_i64(dst, cpu_env, avrl_offset(regno)); + } } =20 static inline void set_avr64(int regno, TCGv_i64 src, bool high) { -#ifdef HOST_WORDS_BIGENDIAN - tcg_gen_st_i64(src, cpu_env, offsetof(CPUPPCState, - vsr[32 + regno].u64[(high ? 0 : = 1)])); -#else - tcg_gen_st_i64(src, cpu_env, offsetof(CPUPPCState, - vsr[32 + regno].u64[(high ? 1 : = 0)])); -#endif + if (high) { + tcg_gen_st_i64(src, cpu_env, avrh_offset(regno)); + } else { + tcg_gen_st_i64(src, cpu_env, avrl_offset(regno)); + } } =20 #include "translate/fp-impl.inc.c" --=20 2.11.0