From nobody Sun Nov 9 17:49:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551378669845678.9956515768289; Thu, 28 Feb 2019 10:31:09 -0800 (PST) Received: from localhost ([127.0.0.1]:44692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzQSa-0002Cc-R7 for importer@patchew.org; Thu, 28 Feb 2019 13:31:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzQFm-0000ZH-5w for qemu-devel@nongnu.org; Thu, 28 Feb 2019 13:18:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzQFV-0002IX-Sk for qemu-devel@nongnu.org; Thu, 28 Feb 2019 13:17:53 -0500 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:33366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzQFV-0002BE-Jz for qemu-devel@nongnu.org; Thu, 28 Feb 2019 13:17:37 -0500 Received: by mail-oi1-x230.google.com with SMTP id z14so17318413oid.0 for ; Thu, 28 Feb 2019 10:17:23 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id k25sm2751654otl.58.2019.02.28.10.17.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 10:17:17 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 06D481808F8; Thu, 28 Feb 2019 18:17:14 +0000 (UTC) Received: by t430.minyard.net (Postfix, from userid 1000) id EC7DC3028D0; Thu, 28 Feb 2019 12:17:13 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=PxmXlovPy4UmaSiUNVr3SIc5dpi6UCs2xw4qY2YArSI=; b=T2vgCc9A4AVM8ALK6GKWK7Jh8myVbohLokBhPkpxhCuj6KY8pcjViPbfX5W7n1TAyc D+ZwXatULKxEYWmVe5oalrJhT6XidSel2oF14l6ha0vp7LntbF95bHB7WFHHh6wDdK4t tpjscK99kudzxH1qZdVCxxtWszEYodQzQLUBn/6pDH0OAMTiJvOA/z1pr0lhQiNEfxvu aQm4htgRppUb1XLkh00Fl8G7WhwaNrpfU7rPTp6RGI64J66dV9bvDywP5fEk71EVWkCg U5oz6zosoywFtaPaLQgDzzLzb05cgZQFMZkqo7NA1OjymxsQAjGSvjH4tsIE5PLy/8hv fC6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=PxmXlovPy4UmaSiUNVr3SIc5dpi6UCs2xw4qY2YArSI=; b=I845CVB8C0+psPdqGV1eXKf5GNt45f/6Uzs+lVIiiWDht7aIZXOoAEePZZWCwvLOrC UdjmaZwe51M+gW7/gwmHhEjeaOHS6GKbLbOO7toPyDkJ7wl1uErCZH0CoQ5M9UOvqUEt hSbN6IvcN7VVwCjRGJq+fV6SiLfU4dH+aGSEKSHJp2otgcOVHxpJCfOuv1rbogARIiRl FdZhLXr8XkovAmmTpfihiHgJrru/gk0MEaS791uo0IozBgtfEL27uVnG+VCUplmzNtsM BcHGhzYKe957H8EGM7JZLnwmohD8/JPzAo39JdlhqUYBcs4kAcnGDp/6IcJW/2haV/wa MyPQ== X-Gm-Message-State: APjAAAWpvlToVUQLLmQ0ixeAkmHU2KHXg3JJQHZqE2YpVlvZ0z7Ca6m0 9I1x5UAN3R9ahQsXZ1DY6w== X-Google-Smtp-Source: APXvYqwTjuTMyyqzpPIE+cOBuTI/ITKTP4e5QinZ4NJlNXbbpQfu+9iXWz0kdWI+VXO3aZ6ZZuBbGQ== X-Received: by 2002:aca:c682:: with SMTP id w124mr678200oif.117.1551377842194; Thu, 28 Feb 2019 10:17:22 -0800 (PST) From: minyard@acm.org To: Peter Maydell Date: Thu, 28 Feb 2019 12:16:59 -0600 Message-Id: <20190228181710.2477-9-minyard@acm.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190228181710.2477-1-minyard@acm.org> References: <20190228181710.2477-1-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::230 Subject: [Qemu-devel] [PULL 08/19] i2c:smbus_eeprom: Get rid of the quick command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , QEMU Developers , minyard@acm.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard It's not necessary, it won't be called if it's NULL. Signed-off-by: Corey Minyard --- hw/i2c/smbus_eeprom.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index 760594b3f1..2f90287b69 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -38,13 +38,6 @@ typedef struct SMBusEEPROMDevice { uint8_t offset; } SMBusEEPROMDevice; =20 -static void eeprom_quick_cmd(SMBusDevice *dev, uint8_t read) -{ -#ifdef DEBUG - printf("eeprom_quick_cmd: addr=3D0x%02x read=3D%d\n", dev->i2c.address= , read); -#endif -} - static uint8_t eeprom_receive_byte(SMBusDevice *dev) { SMBusEEPROMDevice *eeprom =3D (SMBusEEPROMDevice *) dev; @@ -97,7 +90,6 @@ static void smbus_eeprom_class_initfn(ObjectClass *klass,= void *data) SMBusDeviceClass *sc =3D SMBUS_DEVICE_CLASS(klass); =20 dc->realize =3D smbus_eeprom_realize; - sc->quick_cmd =3D eeprom_quick_cmd; sc->receive_byte =3D eeprom_receive_byte; sc->write_data =3D eeprom_write_data; dc->props =3D smbus_eeprom_properties; --=20 2.17.1