From nobody Sun Nov 9 14:48:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551328608467710.2162745733548; Wed, 27 Feb 2019 20:36:48 -0800 (PST) Received: from localhost ([127.0.0.1]:60169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzDQt-0006Fy-Um for importer@patchew.org; Wed, 27 Feb 2019 23:36:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzDQ2-0005wg-LE for qemu-devel@nongnu.org; Wed, 27 Feb 2019 23:35:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzDQ1-0002d7-W3 for qemu-devel@nongnu.org; Wed, 27 Feb 2019 23:35:38 -0500 Received: from ozlabs.ru ([107.173.13.209]:51527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzDQ1-0002b6-Pq for qemu-devel@nongnu.org; Wed, 27 Feb 2019 23:35:37 -0500 Received: from fstn1-p1.ozlabs.ibm.com (localhost [IPv6:::1]) by ozlabs.ru (Postfix) with ESMTP id AD39FAE80054; Wed, 27 Feb 2019 23:35:04 -0500 (EST) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Thu, 28 Feb 2019 15:35:03 +1100 Message-Id: <20190228043503.68494-1-aik@ozlabs.ru> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 107.173.13.209 Subject: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The configure script checks multiple times whether it works in a git repository and it does this by "test -e "${source_path}/.git" in 4 cases but in one case where it tries to enable werror "-d" is used there which fails on git worktrees as .git is a file then and not a directory. This changes the test to "-e" as other occurrences. Signed-off-by: Alexey Kardashevskiy --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 05d72f1..f481ff9 100755 --- a/configure +++ b/configure @@ -1835,7 +1835,7 @@ fi # Consult white-list to determine whether to enable werror # by default. Only enable by default for git builds if test -z "$werror" ; then - if test -d "$source_path/.git" && \ + if test -e "$source_path/.git" && \ { test "$linux" =3D "yes" || test "$mingw32" =3D "yes"; }; then werror=3D"yes" else --=20 2.17.1