From nobody Sun Feb 8 07:04:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155118297130366.18452860780201; Tue, 26 Feb 2019 04:09:31 -0800 (PST) Received: from localhost ([127.0.0.1]:53849 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gybY8-0001KT-45 for importer@patchew.org; Tue, 26 Feb 2019 07:09:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyb6J-0005UF-03 for qemu-devel@nongnu.org; Tue, 26 Feb 2019 06:40:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyb6G-0007XT-GB for qemu-devel@nongnu.org; Tue, 26 Feb 2019 06:40:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3422) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyb6G-0007SK-79; Tue, 26 Feb 2019 06:40:40 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EFAC3003AF9; Tue, 26 Feb 2019 11:40:27 +0000 (UTC) Received: from t460s.redhat.com (ovpn-117-93.ams2.redhat.com [10.36.117.93]) by smtp.corp.redhat.com (Postfix) with ESMTP id D98B36013D; Tue, 26 Feb 2019 11:40:25 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Date: Tue, 26 Feb 2019 12:39:11 +0100 Message-Id: <20190226113915.20150-30-david@redhat.com> In-Reply-To: <20190226113915.20150-1-david@redhat.com> References: <20190226113915.20150-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 26 Feb 2019 11:40:27 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v1 29/33] s390x/tcg: Implement VECTOR STORE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , David Hildenbrand , Thomas Huth , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add a FIXME regarding exceptions during the second store. Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index ab3309c54b..2b18f4ab54 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -1035,6 +1035,8 @@ F(0xe78d, VSEL, VRR_e, V, 0, 0, 0, 0, vsel, 0, IF_VEC) /* VECTOR SIGN EXTEND TO DOUBLEWORD */ F(0xe75f, VSEG, VRR_a, V, 0, 0, 0, 0, vseg, 0, IF_VEC) +/* VECTOR STORE */ + F(0xe70e, VST, VRX, V, la2, 0, 0, 0, vst, 0, IF_VEC) =20 #ifndef CONFIG_USER_ONLY /* COMPARE AND SWAP AND PURGE */ diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.in= c.c index 23cdae0970..69b12e79a1 100644 --- a/target/s390x/translate_vx.inc.c +++ b/target/s390x/translate_vx.inc.c @@ -137,6 +137,17 @@ static void load_vec_element(DisasContext *s, uint8_t = reg, uint8_t enr, tcg_temp_free_i64(tmp); } =20 +static void store_vec_element(DisasContext *s, uint8_t reg, uint8_t enr, + TCGv_i64 addr, TCGMemOp es) +{ + TCGv_i64 tmp =3D tcg_temp_new_i64(); + + read_vec_element_i64(tmp, reg, enr, es); + tcg_gen_qemu_st_i64(tmp, addr, get_mem_index(s), MO_TE | es); + + tcg_temp_free_i64(tmp); +} + static void get_vec_element_ptr_i64(TCGv_ptr ptr, uint8_t reg, TCGv_i64 en= r, uint8_t es) { @@ -764,3 +775,14 @@ static DisasJumpType op_vseg(DisasContext *s, DisasOps= *o) tcg_temp_free_i64(tmp); return DISAS_NEXT; } + +static DisasJumpType op_vst(DisasContext *s, DisasOps *o) +{ + /* + * FIXME: On exceptions we must not modify any memory. + */ + store_vec_element(s, get_field(s->fields, v1), 0, o->addr1, MO_64); + gen_addi_and_wrap_i64(s, o->addr1, o->addr1, 8); + store_vec_element(s, get_field(s->fields, v1), 1, o->addr1, MO_64); + return DISAS_NEXT; +} --=20 2.17.2